From: Morgan Smith <morgan.j.smith@outlook.com>
To: daanturo <daanturo@gmail.com>
Cc: luangruo@yahoo.com, 53200@debbugs.gnu.org
Subject: bug#53200: 29.0.50; C-S-u shortcut fails with 'PGTK' enable
Date: Sun, 22 May 2022 13:44:54 -0400 [thread overview]
Message-ID: <DM5PR03MB31631BB143E669B830459B61C5D59@DM5PR03MB3163.namprd03.prod.outlook.com> (raw)
In-Reply-To: <2ac4ad1d-711a-ce8b-7553-9e9c446f28f1@gmail.com> (daanturo@gmail.com's message of "Sun, 22 May 2022 23:25:05 +0700")
Hello,
daanturo <daanturo@gmail.com> writes:
> Emacs is unable to recognize any Super-modified keys.
My bad, I gave the wrong git hash. I meant this hash: 1c1ae6ba80.
If you want to re-enable super modified keys you have to make the
following change. If I remember correctly Po Lu thinks this is a
bug in some other software and that the GDK_SUPER_MASK bit should
be set so they don't want to add the GDK_MOD4_MASK bit.
Personally, I think GDK_MOD4_MASK should be added and we should
just add a todo comment to look into it more later.
I suppose the thought is that in theory someone could use MOD4 as
a custom modifier instead of using it as super but realistically I
think someone trying to do that would have lots of problems. It
would be cool if that was possible though so I do support trying
to rid ourselves of odd grandfathered in quirks.
diff --git a/src/pgtkterm.c b/src/pgtkterm.c index
b9d0b7b512..3ef643a075 100644 --- a/src/pgtkterm.c +++
b/src/pgtkterm.c @@ -5018,7 +5018,7 @@ pgtk_gtk_to_emacs_modifiers
(struct pgtk_display_info *dpyinfo, int state)
mod |= mod_ctrl;
if (state & GDK_META_MASK || state & GDK_MOD1_MASK)
mod |= mod_meta;
- if (state & GDK_SUPER_MASK) + if (state & GDK_SUPER_MASK ||
state & GDK_MOD4_MASK)
mod |= mod_super;
if (state & GDK_HYPER_MASK)
mod |= mod_hyper;
@@ -5151,7 +5151,8 @@ key_press_event (GtkWidget *widget, GdkEvent
*event, gpointer *user_data)
/* While super is pressed, the input method will always
always
resend the key events ignoring super. As a workaround, don't
filter key events with super or hyper pressed. */
- if (!(event->key.state & (GDK_SUPER_MASK |
GDK_HYPER_MASK))) + if (!(event->key.state & +
(GDK_SUPER_MASK | GDK_MOD4_MASK | GDK_HYPER_MASK)))
{ if (pgtk_im_filter_keypress (f, &event->key)) return TRUE;
next prev parent reply other threads:[~2022-05-22 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 4:56 bug#53200: 29.0.50; C-S-u shortcut fails with 'PGTK' enable Campbell Barton
2022-01-12 6:24 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-13 7:08 ` Lars Ingebrigtsen
2022-01-13 8:04 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-15 2:01 ` Morgan Smith
2022-05-22 16:25 ` daanturo
2022-05-22 17:44 ` Morgan Smith [this message]
2022-05-23 0:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR03MB31631BB143E669B830459B61C5D59@DM5PR03MB3163.namprd03.prod.outlook.com \
--to=morgan.j.smith@outlook.com \
--cc=53200@debbugs.gnu.org \
--cc=daanturo@gmail.com \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).