From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#50005: 28.0.50; silence a couple byte-compiler warnings in ERC Date: Thu, 12 Aug 2021 13:52:16 +0200 Message-ID: References: <50A0B8E0-2F07-4AAC-8170-27990F9FEAD4@acm.org> <87a6lngccy.fsf@neverwas.me> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27905"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Amin Bandali , 50005@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 12 13:53:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mE9Gn-00070Q-Qa for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Aug 2021 13:53:09 +0200 Original-Received: from localhost ([::1]:44898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mE9Gm-0007F6-9j for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Aug 2021 07:53:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mE9Gg-0007Eu-4x for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 07:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mE9Gf-0002Lr-SB for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 07:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mE9Gf-0007GH-I6 for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 07:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Aug 2021 11:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50005 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50005-submit@debbugs.gnu.org id=B50005.162876915227874 (code B ref 50005); Thu, 12 Aug 2021 11:53:01 +0000 Original-Received: (at 50005) by debbugs.gnu.org; 12 Aug 2021 11:52:32 +0000 Original-Received: from localhost ([127.0.0.1]:37721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mE9G7-0007FT-VI for submit@debbugs.gnu.org; Thu, 12 Aug 2021 07:52:31 -0400 Original-Received: from mail200c50.megamailservers.eu ([91.136.10.210]:45528 helo=mail193c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mE9G2-0007FF-GR for 50005@debbugs.gnu.org; Thu, 12 Aug 2021 07:52:27 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1628769140; bh=B3iOmZf56bwdeLJ0pTCUNLgavctcmGaVrB5/8EoStko=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=bgm5mSVK2BENx6hBZGCRoJsh4Fqh6ddvX99/WOZJBAZOZuSw335u4Ey8/+91wb330 nOV/Rjn+/TeNqiJhgLYJqDV7xnO51R19EMkiUZx/a6sB/e9lD6WsCektnzMQGN6o82 9v/EI6rJKlJu/OgFeyZq4bQzPidz6EchnKccxCVw= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail193c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17CBqHMR015095; Thu, 12 Aug 2021 11:52:18 +0000 In-Reply-To: <87a6lngccy.fsf@neverwas.me> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F2A.61150B74.0010, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=GJV27dFK c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=solvC2KCA7hIJrw-nAAA:9 a=QEXdDO2ut3YA:10 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211658 Archived-At: 12 aug. 2021 kl. 12.56 skrev J.P. : > Thanks, I spotted the weird double-quote mismatch thing earlier, but I > guess I'm still missing something else? The string made it look like backslash were a special character inside = [...]. It isn't; only ^, ] and - are special, each with their own quirky = rules. (Other regexp systems have different rules.) > So, I take this to mean there's no problem with requiring = (autoloading) > rx.el (or regexp-opt.el), right? Correct. Your original problem was the use of `regexp-opt-charset` which = is not autoloaded (and somewhat of an internal function to = regexp-opt.el, but that's debatable). Using plain `regexp-opt` is fine. Most ordinary uses of rx will not even require rx.el to be loaded at = runtime since the macros are expanded during compilation, but = `rx-to-string` is a plain function, autoloaded. > And I guess the `string-to-list' is necessary because >=20 > (rx-to-string '(+ (in "abc")) t) > =E2=87=92 "[a-c]+" >=20 > is still interpreted as a set of character alternatives, whereas >=20 > (rx-to-string '(+ (in ?a ?- ?c)) t) > =E2=87=92 "[ac-]+" >=20 > combines individual character args into just such a set. If you meant (in "a-c") in your first example then yes, quite right -- = the hyphen is special inside strings of the rx `in` construct, but it's = not special as a character argument. No other characters are special. > Do you use ERC, Mattias? If so, are you available to review more > patches? I'm afraid I rarely use it and know nothing about its innards so I'm = probably not the right person to ask -- only came by to help out with = some regexpy things. I have nothing clever to say about your other = changes, sorry! > I'm obviously quite ignorant in the ways of Emacs but am > pushing hard to improve ERC. Some might say that's a recipe for > embarrassment/disaster (though I'm pretty sure I already crossed that > first bridge ages ago). I'd say it's a good sign! Just dive in. > So what do you say, can you help? Wish I could but time probably doesn't permit, sorry. There are much = more experienced hands about. Of course I'll be happy to answer = specifics about parts that I happen to know something about.