From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#69714: [PATCH] Improve ert-font-lock assertion parser Date: Mon, 1 Apr 2024 10:04:44 +0200 Message-ID: References: <8EAA90DF-C567-4ADA-81DB-F074FE73ADAF@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34033"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 69714@debbugs.gnu.org To: Vladimir Kazanov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 01 10:05:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rrCfX-0008g7-G0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Apr 2024 10:05:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rrCf7-0004oY-8t; Mon, 01 Apr 2024 04:05:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrCf5-0004oI-OA for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2024 04:04:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rrCf5-00058D-Dy for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2024 04:04:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rrCf7-0000Ua-VE for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2024 04:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Apr 2024 08:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69714 X-GNU-PR-Package: emacs Original-Received: via spool by 69714-submit@debbugs.gnu.org id=B69714.17119586971874 (code B ref 69714); Mon, 01 Apr 2024 08:05:01 +0000 Original-Received: (at 69714) by debbugs.gnu.org; 1 Apr 2024 08:04:57 +0000 Original-Received: from localhost ([127.0.0.1]:49444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrCf2-0000UA-V2 for submit@debbugs.gnu.org; Mon, 01 Apr 2024 04:04:57 -0400 Original-Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:51252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrCf1-0000Tx-74 for 69714@debbugs.gnu.org; Mon, 01 Apr 2024 04:04:55 -0400 Original-Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-513e25afabaso4058470e87.2 for <69714@debbugs.gnu.org>; Mon, 01 Apr 2024 01:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711958686; x=1712563486; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=clS4gSd6BfrfE/RwWmeZI3qkN8rJKDGFbTHCqv7bmzg=; b=XgS2rbrwMju5+3aqJo7Yb/kQFEt5vtpztlYSd/D0FVZpVsDsSzp2iq/3A9YtLfNBpf GEImta/RvBgtNqJzG8qNN74cRC9F1EZf2gfxwNROGzSbsMoX67GjJpDyLRGrhRMH1hmZ YdI+x1E7th7MzYDsDJLzwCJ2dfAX9DRFWAeJ7RUgEHiQlaxfYoDbvY5koo0IHKf0Y+lj xPBzNIG+4SoTwq6p5AMrT+z0RvrDsesNiRyh9Jc8XTHBOX+QVeETjpDmAisfOIuL/egW VPF5B9oXXVLTeYu62tdJnzL9UDb8otdAizRMbEINBB/VIwLk4/LI0dYChK5SMpJVeLHN fing== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711958686; x=1712563486; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=clS4gSd6BfrfE/RwWmeZI3qkN8rJKDGFbTHCqv7bmzg=; b=WYYJZYcqrl1jKvFQfCOBuQ6+YtT8dT0kb+jsrCp7xFAt5CFPMrzOT3bHrk9Os7Jftq QDb6Fe2sd+Ac4iZ6UlWGrm/O8lXwwSs2zz79IFK0UQ2vEpOaqCBn/F/B5yK2iMbsz41b pOAFGNYJi5QmX1bp7pAcudkwdIbMP8Asp6JcbDwR8Qd99f10rxrVrdZIpWJHgYvLeyLo fN3vm+PqTcYpuXZBDzX2xngVMKgDxWPSz/ieVUiwz/kg5MugSUnNCT3NGVi0wSQYYLEK 1hbdYMCECexp9FR8XxdSZxO0NQ28n8oxKVBz1awD53SJHmy+BViJyw+j53VYyRDQBtDA 5d/Q== X-Forwarded-Encrypted: i=1; AJvYcCUycZwhsld2K++IBa9rUsPRO+vDhD9U9ASlj5jNWMB1EU5XCwgmL2BJO9oGdSwsiZnX9ruIPcIony+iuJSeCB1syuO8m+A= X-Gm-Message-State: AOJu0YwXGXANTwgmOGIUzKe5sC3lvJGUzQQtght42gGjbyboMXhr8uOE uX7ecJ12y03FX9ytwKk8SYm44GZju/wT6w5NxRdRB2ZYk7o2/ha3 X-Google-Smtp-Source: AGHT+IHAmcOT4DQWpnZP3aqr1LBVG/Z1svf+UeQU1ReZCDxA1M8q7Fl8563uuC9zJaWnQJdd81I/lw== X-Received: by 2002:a05:6512:4893:b0:513:d0e2:8a1e with SMTP id eq19-20020a056512489300b00513d0e28a1emr5299818lfb.54.1711958685874; Mon, 01 Apr 2024 01:04:45 -0700 (PDT) Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id br35-20020a056512402300b00516a096a35asm558651lfb.123.2024.04.01.01.04.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2024 01:04:45 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282455 Archived-At: 31 mars 2024 kl. 19.56 skrev Vladimir Kazanov : > (rx "(" > (* whitespace) > - (one-or-more > - (seq (regexp ert-font-lock--face-symbol-re) > - (* whitespace))) > + (opt (regexp ert-font-lock--face-symbol-re)) > + (zero-or-more > + (seq (+ whitespace) > + (regexp ert-font-lock--face-symbol-re))) > + (* whitespace) > ")") Since you want to match zero or more symbols, this can be improved = further: (rx "(" (* whitespace) (* (regexp ert-font-lock--face-symbol-re) (+ whitespace))) ")") (Note that most rx operators have an implicit `seq` inside.) You may want to use =C2=B4rx-define` instead of `defconst` as well -- it = avoids some use of the `regexp` construct and removes some load-time = string building.