From: "Mattias Engdegård" <mattiase@acm.org>
To: "積丹尼 Dan Jacobson" <jidanni@jidanni.org>,
"Eli Zaretskii" <eliz@gnu.org>,
"Stefan Monnier" <monnier@iro.umontreal.ca>,
"Paul Pogonyshev" <pogonyshev@gmail.com>
Cc: 39595@debbugs.gnu.org
Subject: bug#39595: #39595: M-x compile still very line-length weak
Date: Fri, 14 Feb 2020 17:27:39 +0100 [thread overview]
Message-ID: <DD5F2B53-F661-4F29-BE67-CE626EAE607F@acm.org> (raw)
In-Reply-To: <9D8A11CB-9ABE-4A66-87D0-2E445499B74F@acm.org>
Dan, in your example you used a long line of spaces. Presumably that is representative for your particular use, but different message parsers are sensitive to different kinds of long lines:
* 'omake' in compilation-error-regexp-alist is indeed what makes Emacs unusably slow with long lines of spaces.
* 'msft' and 'watcom' are both expensive with long lines of spaces, but not as bad as 'omake'. Maybe these regexps can be tuned further.
* 'msft' occurs twice by mistake; the last one should be removed. This helps a bit.
* 'maven' is still expensive for long lines of non-spaces; see bug#3441. Anchoring the match at line-start would fix it:
(rx bol
(? "["
(or "ERROR" (group "WARNING") (group "INFO"))
"]"
(+ " "))
(group
(not (in "\n "))
(* (or (not (in "\n :"))
(: " "
(not (in "\n/-")))
(: ":"
(not (in "\n ["))))))
":["
(group (+ digit))
","
(group (+ digit))
"] ")
Is that correct? (CC:ing Paul Pogonyshev, who worked on that regexp in bug#20556.)
I suggest we disable omake by default --- although a nice tool, it was never widely used, and OCaml programmers tend to use Dune (or plain Make) these days. The omake rule will still be there for those who need it, but the majority shouldn't bear the cost.
next prev parent reply other threads:[~2020-02-14 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 5:51 bug#39595: M-x compile still very line-length weak 積丹尼 Dan Jacobson
2020-02-14 11:18 ` bug#39595: #39595: " Mattias Engdegård
2020-02-14 16:27 ` Mattias Engdegård [this message]
2020-02-14 17:00 ` Eli Zaretskii
2020-02-14 22:47 ` Mattias Engdegård
2020-02-15 7:35 ` Eli Zaretskii
2020-02-15 16:45 ` Mattias Engdegård
2020-02-16 12:15 ` Mattias Engdegård
2020-02-15 1:28 ` 積丹尼 Dan Jacobson
2020-02-15 13:57 ` Stefan Monnier
2020-02-16 15:37 ` 積丹尼 Dan Jacobson
2020-02-17 11:07 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD5F2B53-F661-4F29-BE67-CE626EAE607F@acm.org \
--to=mattiase@acm.org \
--cc=39595@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jidanni@jidanni.org \
--cc=monnier@iro.umontreal.ca \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).