From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.bugs Subject: bug#18215: 24.4.50; OSX 10.6.8; set-frame-size by pixelwise does not work following `make-fame`. Date: Wed, 13 Aug 2014 12:33:57 +0200 Message-ID: References: <53EB0447.4060402@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1407926126 25835 80.91.229.3 (13 Aug 2014 10:35:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Aug 2014 10:35:26 +0000 (UTC) Cc: "18215@debbugs.gnu.org" <18215@debbugs.gnu.org>, Keith David Bershatsky To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 13 12:35:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XHVtl-0006RJ-Uk for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Aug 2014 12:35:18 +0200 Original-Received: from localhost ([::1]:46502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHVtl-00017o-Gy for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Aug 2014 06:35:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHVtd-00016k-Cx for bug-gnu-emacs@gnu.org; Wed, 13 Aug 2014 06:35:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHVtX-0008SG-F1 for bug-gnu-emacs@gnu.org; Wed, 13 Aug 2014 06:35:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34558) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHVtX-0008R5-Bz for bug-gnu-emacs@gnu.org; Wed, 13 Aug 2014 06:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XHVtW-0007BA-FA for bug-gnu-emacs@gnu.org; Wed, 13 Aug 2014 06:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Jan D." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Aug 2014 10:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18215-submit@debbugs.gnu.org id=B18215.140792604927509 (code B ref 18215); Wed, 13 Aug 2014 10:35:02 +0000 Original-Received: (at 18215) by debbugs.gnu.org; 13 Aug 2014 10:34:09 +0000 Original-Received: from localhost ([127.0.0.1]:41501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XHVse-00079b-5Z for submit@debbugs.gnu.org; Wed, 13 Aug 2014 06:34:08 -0400 Original-Received: from mailfe05.swip.net ([212.247.154.129]:35435 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XHVsZ-000793-PO for 18215@debbugs.gnu.org; Wed, 13 Aug 2014 06:34:05 -0400 X-T2-Spam-Status: No, hits=0.0 required=5.0 Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe05.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 519169353; Wed, 13 Aug 2014 12:33:56 +0200 X-Mailer: iPad Mail (11D257) In-Reply-To: <53EB0447.4060402@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92457 Archived-At: Hi.=20 > 13 aug 2014 kl. 08:23 skrev martin rudalics : >=20 > > Thank you for the new patch. I was able to successfully apply the new > > patch for 'nsterm.m` to a version of Emacs Trunk downloaded tonight > > (08/12/2014). I also tried patching the previous file for `nsfns.m`, > > but received a message that the patch had already been applied. >=20 > Jan applied it as revision 117687 with the slightly misleading commit > message: "Fix default width not being 80, but 77." That was what I fixed. I have not looked at your patches.=20 >=20 > > After patching `nsterm.m` and building Emacs Trunk downloaded tonight > > (08/12/2014), I was not able to set the frame size to 1920 using any > > of the settings previously mentioned relating to bug 18215. I was > > able to achieve a little less than 1920 or several pixels more than > > 1920, but not exactly 1920. >=20 > Do you mean with `set-frame-size' and PIXELWISE non-nil? I have no idea > how size hints work on OSX so that's easily possible. Around line 5843 > nsterm.m has these three lines >=20 > sz.width =3D FRAME_COLUMN_WIDTH (emacsframe); > sz.height =3D FRAME_LINE_HEIGHT (emacsframe); > [win setResizeIncrements: sz]; >=20 > These seem to say that resize increments should happen in multiples of > the frame's character sizes. Note that in Lisp you get the values of > FRAME_LINE_HEIGHT and FRAME_COLUMN_WIDTH via `frame-char-height' and > `frame-char-width' respectively. >=20 > So if you did something like >=20 > sz.width =3D 1; > sz.height =3D 1; > [win setResizeIncrements: sz]; >=20 > instead, this should tell your window manager to resize your frame in > increments of 1 pixel instead. You should be able to try this out by > mouse-dragging the edge of a frame after such change. >=20 > But I'm not sure what happens when you omit the >=20 > [win setResizeIncrements: sz]; >=20 > entirely as in the diffs I sent you. It might leave the hint values at > some earlier default which inhibits pixelwise resizing. >=20 > Note that nsterm.c also has two occurrences of setResizeIncrements in > toggleFullScreen. I'm not sure whether these apply for getting the > entire screen estate. You could try to replace around line 6462 >=20 > sz.width =3D FRAME_COLUMN_WIDTH (f); > sz.height =3D FRAME_LINE_HEIGHT (f); >=20 > with >=20 > sz.width =3D 1; > sz.height =3D 1; >=20 > and look whether maximizing works as expected then. If you remove or set to one, you loose the resize feedback in the title bar (= w x h) during resize.=20 Jan D.=20