From: Simon Lang <simon.lang@outlook.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: 49005-done@debbugs.gnu.org
Subject: bug#49005: 28.0.50; Not possible to jump to first or last completions entry in fido-vertical-mode
Date: Mon, 6 Sep 2021 17:24:48 +0100 [thread overview]
Message-ID: <DBAPR06MB704509E80E7624D7381B778C80D29@DBAPR06MB7045.eurprd06.prod.outlook.com> (raw)
In-Reply-To: <87h7fowaax.fsf@gmail.com>
Fantastic!
sorry for the delayed reply …
> On 17 Aug 2021, at 13:00, João Távora <joaotavora@gmail.com> wrote:
>
> João Távora <joaotavora@gmail.com> writes:
>
>> No, no, makes a lot of sense. I just haven't looked at your code
>> yet in depth.
>>
>> Your implementation seems to repeat some logic, and I'd rather
>> reuse paging code, so maybe you can work on that: reducing code
>> duplication. But as soon as I have time I'll look at this and offer some
>> suggestions.
>>
>> Sorry for the delay, and keep bumping this if I forget.
>
> I've pushed a solution to this in:
>
> commit 96bbd6f0a7f20ae77bcd8a477b54b11ba5b42cc6 (HEAD -> master, origin/master, origin/HEAD)
> Author: João Távora <joaotavora@gmail.com>
> Date: Tue Aug 17 12:48:37 2021 +0100
>
> Jump to first,last completion with M-<, M-> in icomplete-vertical-mode
>
> Fixes: bug#49005
>
> Co-authored-by: Simon Lang <simon.lang@outlook.com>
>
> With the aforementioned de-duplications and binding it to M-< and M->
> so that it also works easily for tty emacsen. Let me know what you
> think.
>
> Thanks,
> João
next prev parent reply other threads:[~2021-09-06 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 15:27 bug#49005: 28.0.50; Not possible to jump to first or last completions entry in fido-vertical-mode Simon Lang
2021-06-30 19:27 ` Simon Lang
2021-06-30 20:08 ` João Távora
2021-08-17 12:00 ` João Távora
2021-09-06 16:24 ` Simon Lang [this message]
[not found] ` <ad80a840df59497f8128bc8a98ca7b05@DBAPR06MB7045.eurprd06.prod.outlook.com>
2021-07-01 8:16 ` Simon Lang
2021-08-17 12:09 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR06MB704509E80E7624D7381B778C80D29@DBAPR06MB7045.eurprd06.prod.outlook.com \
--to=simon.lang@outlook.com \
--cc=49005-done@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).