From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ignacio Casso Newsgroups: gmane.emacs.bugs Subject: bug#54399: 27.2; Problems with (let ((custom-variable ...)) (autoload-function ...)) Date: Thu, 12 May 2022 10:41:56 +0200 Message-ID: References: <83sfqi498s.fsf@gnu.org> <87ilrdg837.fsf@web.de> <87ilqb1nwf.fsf@gnus.org> <83r14zp5jz.fsf@gnu.org> <83o803p2p3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3496"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.10; emacs 29.0.50 Cc: michael_heerdegen@web.de, larsi@gnus.org, 54399@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 12 11:43:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1np5Lv-0000jx-34 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 May 2022 11:43:23 +0200 Original-Received: from localhost ([::1]:57380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1np5Lu-00074c-07 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 May 2022 05:43:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np591-0001HB-6o for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 05:30:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1np590-0006yU-U1 for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 05:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1np590-0008Hp-FG for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 05:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ignacio Casso Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 May 2022 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 54399-submit@debbugs.gnu.org id=B54399.165234775831765 (code B ref 54399); Thu, 12 May 2022 09:30:02 +0000 Original-Received: (at 54399) by debbugs.gnu.org; 12 May 2022 09:29:18 +0000 Original-Received: from localhost ([127.0.0.1]:39691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1np58H-0008GH-Pd for submit@debbugs.gnu.org; Thu, 12 May 2022 05:29:18 -0400 Original-Received: from mail-oln040092074079.outbound.protection.outlook.com ([40.92.74.79]:15491 helo=EUR04-DB3-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1np58G-0008Fz-71 for 54399@debbugs.gnu.org; Thu, 12 May 2022 05:29:16 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XyCSCR0Iv868V8iKBAkZsuP0J3T07Z0iXdUokdT4HICqRGfl3Aexwa6JgGJbcRGtCVr7f3M1QmVI1W69Va0aIDghaHn+BG9TFlgQ1LQN0Hn1IUGP1yaY7SUMgBjtSBuQRrwTIM7JPPwh57Ajp0vxLwS3FIYkF0eQa3QOQtg8bMPBVgrw0LGIbg9JnPxDJFGLSjvD+R3ZsRd46MgSsUmwUf6FaOGUNVyEs83WobiVO+DpNEtj6h6LRFfKfPdjx+r7mxKlgpZfQrUzuS50FZ4Vwukw2ST+48ZJjyFVWg3zEbpF5bqHzOOycNfvDN/AqM8jSJI1Kd+w0doy/fq3YeozHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uXr+E4NYhjcF78xLgz1pvHwuW3S+vb6ZJY4D4v4mGeM=; b=JH15TemrFkuXpgzBMaNGSjTL8ih22QkQ7r1niofm1VfldxONaT1TGkzGiK5ExKCtmhfpaV8c7ZBErsP366DctvTtVQKGvY4jiZo2cpbifNSHIDjp8yCKr5S7nd/awTx6/Jq06BC3/0Bz9Ok7dXrb8qMyMyyBlrBrr3sADioxGQEx2rJ/vryGW/K6Y/g4W7I8s0O7vz+Md8stY2pxdLv/oKWhWchnqmkOQs+zk0T0uVX3zEfW5oGPuUckc+b3a9+mRRQnF0yEWUYKDYD1HflIfBIoR2ECR+sQAbDjVinuWrqBP+z2uAfBTUriTX6yrGhyrHL0outmAHkZmaxbo2CYLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uXr+E4NYhjcF78xLgz1pvHwuW3S+vb6ZJY4D4v4mGeM=; b=ZK72O3M1w1oh+/XWJ0PABV391QjN+Q2/AyYSk5NcgoFqoE9+OsqqASa54/Jx4cG2shcBWKc7kOKT5CFl7fexjnFLFHo8NowFEpw0SAZWMmPJzcyJAnE0Oz37SlsTe/zTBSrvQN36aQxBdtxrFl9uFq85XWnKNrx3gZ4hwurbky7uMtGzjoySEGQJHW9Qkwskdz3HUk2G3bHTvqrVJlcJTuZR8aHFGKCfd50Yu9wJ6Euyv+gerrtlJ+4D9/qfaWEvWOgqS/ndqEL8PHdjrCUKMn8a19uNyfuwKBLJx0PDEIxy863Ilmn5W1WKLy2AU31YZN9yJgiMPEwWhuTUNKnHRQ== Original-Received: from DB6PR0601MB2087.eurprd06.prod.outlook.com (2603:10a6:4:4f::26) by DB6PR06MB3125.eurprd06.prod.outlook.com (2603:10a6:6:3::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Thu, 12 May 2022 09:29:08 +0000 Original-Received: from DB6PR0601MB2087.eurprd06.prod.outlook.com ([fe80::cdbe:e542:a1b6:1a2]) by DB6PR0601MB2087.eurprd06.prod.outlook.com ([fe80::cdbe:e542:a1b6:1a2%2]) with mapi id 15.20.5250.013; Thu, 12 May 2022 09:29:08 +0000 In-reply-to: <83o803p2p3.fsf@gnu.org> X-TMN: [RduXFdx3kD3z1osBpNBdS7Om8nq0GhJa] X-ClientProxiedBy: PR3P251CA0029.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::34) To DB6PR0601MB2087.eurprd06.prod.outlook.com (2603:10a6:4:4f::26) X-Microsoft-Original-Message-ID: <87lev7umjp.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 47d7dabd-eae5-4baf-266e-08da33f9dd0f X-MS-TrafficTypeDiagnostic: DB6PR06MB3125:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vRQMZozC6SHd4aL3gDMdqjXC6qQu6N+puXR6lV1NkMzPdlVJpSKa5wAjuU96gnGsY36z8y3im8MBG0nJpejnZEezs8c72OquTYD2cU1Rr44TbH6BVjwVXqa2M36rGalY0YbGbbiDDKTdjLKiE/PP0v3hWSOYTfmY0oicCC81Lu8obXD6qGDnvukQ1VVZRvIRV4t/mWzzPNkSqYF0kRoKSgdtaXxP9kmTbBeYdJ8QLfRzANNgYGBDqJVQPMGpajfXv8UADVG6Chmrg6vO6NoFgKYxpdpydRW6SRD+6yUsBnmrIK4VNWdOayVFAlbDrj80mMq+Fcz00v1J/2LFAA7dwLM6LzEmagFXQFIbSGr6I2cz6lvtErgE1wzMGj5KiFx5wmk8t+aEossSuqGd879cQBL2bNiw4Is2g7jkNvpI6iwYpSTx9C9mjGdjXy6+y6G1uzpwrbDzVa4C7k0YZ5Z03tj9UUBSXTgYcp1VepC6AnmEyw/ncC5p0Le5aCPiqYxuKqSStp0KB2KTP5/IleQd4ocpjv/HncGny6WeKBH1YPlkubeOV45xNgHgw0dW7E7b1h2HLVLdvLiDJlEeyaq8YQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GxGWdJxv/0nG74J4PuRXY8KSypkrEerOqI3an4hYgi7nYc5rTUsA+rIcoALtIhJrjnYwkPiGa2m/wV9qLym0wJg9ypaLNy5oiCfCsSw7DaUyIikNfN6jjlEmp6tB8eNOgW627tdX/1yUxr0OUU6Yc28VJP1RUaeuEOxkHZYHBEbNUap+qXyNAaOkGgcOuONn5oR3uioPiZquonpjQxUKGA/Dvp/FDH+gmD/mV3KPKc+Ib1fwaXRzadtGiDz/Sva3suUWVoXx2UfNnRh07RmrQ8RiEPbj49AQKOKbw268agz4jGC698F4toWlvbCOv7PiqHMJuv62xeZOUeihw9hs63l/cJtYlt1TCMLPXe3o830vrTcHlec4ZZWMmt9ZOFnt3Dao75lUUWx8ZCV/kDqBjoJ16PENUHo8pT8KM6gld+wrn8dAsYJgICVEAHl9s0FWD4J3Tp6WvVxLP0lvbN8Tk189G7NX/5JoKVZ2NoJ1xIMfQVaYN8aFtYgL6hLolUvKO/co19C+a/mEnrZrtXOAQljfec4tlQopfDm0x3j05etFiD4KhFz5HFP+cy+/1zgALPViLPBG7qjq9ONt+R0hUS97rLwTjOUr2984opVFe8GAUc1UjptdBm0aUMMBYZ1FaUXP4nusvZS5e0+ooydmrN0KlrWpxo6gbFb9NCogOpyRq8repB3gYExNRAJK4mLtMDb3vo1cPWFmHfjX68hV1OPWfDXgJLAE0f+pwgLFbeDycmRQuIFBsLutDm 1XVyVQauhjdrCJKoNM96MqhMFn4F8U2LYGaanNcd1InMZ+UTQ7go7dFvQoUyYDXyGX04tojzBfjjFlYcQGbZFJfMMkU3ZPeXZc X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-6e454.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 47d7dabd-eae5-4baf-266e-08da33f9dd0f X-MS-Exchange-CrossTenant-AuthSource: DB6PR0601MB2087.eurprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 09:29:07.9508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR06MB3125 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232030 Archived-At: > My point is that you seemed to be sating that you suggest a > documentation change, but the changeset actually changes some code. > So I'm not sure anymore what is this changeset about. Perhaps I > forgot what we were discussing at the beginning, since that was quite > some time ago. Can you remind? Sure. It began as a bug report, but after you explained things to me, all that was left were some mismatches between the docstrings of some functions and their actual behavior: they use `default-toplevel-value' and `set-default-toplevel-value' and their docstring said they use `default-value' and `set-default'. And that is mainly what this patch fixes, aside from another error in the docstring of `default-boundp'. The few non-documentation changes are just using the toplevel versions of those functions in some places that were still missing, in functions and places completely equivalent to those that are already using them. This makes the use of those functions more consistent across custom.el, and fixes in those new places the potential bug that those functions were introduced to solve in the first place: calling `defcustom' or customize functions inside a let-binding of the variable in question (e.g., because a function inside the let body autoloads, calling `defcustom') A few further comments on each change: > @@ -114,7 +114,7 @@ custom-initialize-changed > symbol > (eval (car (get symbol 'saved-value))))) > (t > - (set-default symbol (eval exp))))))) > + (set-default-toplevel-value symbol (eval exp))))))) > > (defvar custom-delayed-init-variables nil > "List of variables whose initialization is pending until startup. The docstring of this function actually says that it behaves like `custom-initialize-reset', which is already using `set-default-toplevel-value'. > @@ -717,7 +717,7 @@ custom-set-default > (if custom-local-buffer > (with-current-buffer custom-local-buffer > (set variable value)) > - (set-default variable value))) > + (set-default-toplevel-value variable value))) > > (defun custom-set-minor-mode (variable value) > ":set function for minor mode variables. This would be the only setter function that does not use `set-default-toplevel-value'. > @@ -752,7 +752,7 @@ customize-mark-to-save > @@ -779,7 +779,7 @@ customize-mark-as-set These two I thought that I had remove them. Ignore them, they will not be there in the next version of the patch --Ignacio