From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems Date: Wed, 9 Jun 2021 13:40:18 +0200 Message-ID: References: <51cb-60bf4900-1dd-2840bc80@23790836> <875yyoo9gy.fsf@gnus.org> <87r1hcmu2q.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24289"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48902@debbugs.gnu.org, Lars Ingebrigtsen , Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= , naofumi@yasufuku.dev To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 09 13:41:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqwaC-00065n-MH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 13:41:16 +0200 Original-Received: from localhost ([::1]:40996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqwaB-0000Gn-OT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 07:41:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqwZy-0008Rj-MR for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 07:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49100) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqwZy-0001DZ-Ev for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 07:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqwZy-0008LN-6R for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 07:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Jun 2021 11:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48902 X-GNU-PR-Package: emacs Original-Received: via spool by 48902-submit@debbugs.gnu.org id=B48902.162323882632018 (code B ref 48902); Wed, 09 Jun 2021 11:41:02 +0000 Original-Received: (at 48902) by debbugs.gnu.org; 9 Jun 2021 11:40:26 +0000 Original-Received: from localhost ([127.0.0.1]:60646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqwZN-0008KM-Se for submit@debbugs.gnu.org; Wed, 09 Jun 2021 07:40:26 -0400 Original-Received: from mail71c50.megamailservers.eu ([91.136.10.81]:46042 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqwZL-0008KC-0z for 48902@debbugs.gnu.org; Wed, 09 Jun 2021 07:40:24 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1623238821; bh=Lt1+Yo3QHerkk+tuISTaPFrvQ0bGJlgm9YdU4NwmBIY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=j2OmSZST9ufXBvg+UdUZBbgjKshH4fMzfsOg+FlT6v+9iar/14YDbP32HQvoyCVzg zLhoGNjcdxudn9eIgxU40gTf3cgXllAea8mGTd3h0zkwo/6JvHPo8lVMaQttotsy+B 6OahFjwEGlGS49rVBo3RZVPETZ7mif+ZpcZJ605I= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 159BeIrP017078; Wed, 9 Jun 2021 11:40:20 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F24.60C0A8A5.000A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=UJ+j4xXy c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=hIj89exaAAAA:8 a=B_rbbL6lnIespKWroTwA:9 a=CjuIK1q_8ugA:10 a=lS9wXHQM5UdnNJ4u63Ry:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208285 Archived-At: 8 juni 2021 kl. 22.33 skrev Alan Third : > It's not just allocInitFromFile, I'm looking at the other callers of > image_find_image_file and they all call ENCODE_FILE after it too. >=20 > The only direct caller of image_find_image_fd that actually uses the > contents of the returned string (svg_load) also encodes the file name. >=20 > So I think we could restrict the use of the encoded filename within > image_find_image_fd to *only* when it actually opens the file. Thank you, and I arrived at the same conclusion. > Patch attached. I've tested it here but I only have a couple of images > to try it with. Looks fine, but the image_find_image_file comment needs to be amended = since it says that it returns an encoded string. > I've been looking at the other changes I made in > 747a923b9a35533f98573ad5b01fccf096195079 and I'm not sure they're > correct. They clearly work now, but most of the time it's probably > simple ASCII which should pass easily. >=20 > Before they *all* seem to have assumed the data was UTF8 encoded, > which is surely wrong since most of the time it's coming from Emacs. > It's things like menu item titles. >=20 > These are the use cases stringWithLispString was designed for, right? > The only odd one is image filenames because they're explicitly = encoded? I should think so -- stringWithLispString: was designed as a = general-purpose method to convert from a lisp string to NSString without = changing the contents. Non-Unicode values (which includes raw bytes) = become U+FFFD except surrogates as they can be represented (in a manner = of speaking) in UTF-16, and it turns out to be more useful that way. Furthermore, if we use stringWithLispString: for file names, no special = file name encoding step should be needed on our side, since the NS libs = will perform any needed normalisation (at least if I've understood it = right).