From: "Matz, Daniel A. (JSC-EG511)" <daniel.a.matz@nasa.gov>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "29080@debbugs.gnu.org" <29080@debbugs.gnu.org>
Subject: bug#29080: 25.3; dired-x does not update `shell-command-history'
Date: Tue, 31 Oct 2017 21:40:36 +0000 [thread overview]
Message-ID: <DAB3042E-0436-48D9-87A0-EA55798C1E8F@nasa.gov> (raw)
In-Reply-To: <83po93rqn6.fsf@gnu.org>
> Yes, I think so. See the comments there.
OK, I see. When dired-x is loaded, `dired-read-shell-command' calls `dired-guess-shell-command' instead of calling `read-shell-command' directly. And then`dired-guess-shell-command’ ends up calling `read-shell-command', but specifies a different history variable. And `dired-do-shell-command' calls `dired-read-shell-command’, but `dired-smart-shell-command’ does not, but instead calls `read-shell-command' directly, using the default history variable.
I ended up just making `dired-shell-command-history' an alias for `shell-command-history’.
Thank you for the help. We can close this issue.
next prev parent reply other threads:[~2017-10-31 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 15:39 bug#29080: 25.3; dired-x does not update `shell-command-history' Matz, Daniel A. (JSC-EG511)
2017-10-31 20:24 ` Eli Zaretskii
2017-10-31 20:36 ` Matz, Daniel A. (JSC-EG511)
2017-10-31 20:47 ` Eli Zaretskii
2017-10-31 21:40 ` Matz, Daniel A. (JSC-EG511) [this message]
2017-11-01 3:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DAB3042E-0436-48D9-87A0-EA55798C1E8F@nasa.gov \
--to=daniel.a.matz@nasa.gov \
--cc=29080@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).