From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#8876: 24.0.50; making `menu-bar-update-buffers' use another frame Date: Fri, 17 Jun 2011 07:48:00 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_000F_01CC2CC2.E262DFF0" X-Trace: dough.gmane.org 1308329560 4949 80.91.229.12 (17 Jun 2011 16:52:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 17 Jun 2011 16:52:40 +0000 (UTC) Cc: 8876@debbugs.gnu.org To: "'Stefan Monnier'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 17 18:52:36 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QXcHb-0001pb-OL for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2011 18:52:35 +0200 Original-Received: from localhost ([::1]:58320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXcHa-0008Em-N7 for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2011 12:52:34 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:37076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXaM6-0005Tz-7f for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2011 10:49:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXaM4-0003qW-3Z for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2011 10:49:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXaM3-0003pu-Kn for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2011 10:49:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QXaM2-0004up-MP; Fri, 17 Jun 2011 10:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jun 2011 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8876 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8876-submit@debbugs.gnu.org id=B8876.130832210518848 (code B ref 8876); Fri, 17 Jun 2011 14:49:02 +0000 Original-Received: (at 8876) by debbugs.gnu.org; 17 Jun 2011 14:48:25 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXaLR-0004tw-1C for submit@debbugs.gnu.org; Fri, 17 Jun 2011 10:48:25 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QXaLO-0004tj-Pu for 8876@debbugs.gnu.org; Fri, 17 Jun 2011 10:48:23 -0400 Original-Received: from rtcsinet22.oracle.com (rtcsinet22.oracle.com [66.248.204.30]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p5HEmA8C015845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Jun 2011 14:48:12 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by rtcsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p5HEm9Oc015330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 17 Jun 2011 14:48:10 GMT Original-Received: from abhmt104.oracle.com (abhmt104.oracle.com [141.146.116.56]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p5HEm3sY020586; Fri, 17 Jun 2011 09:48:03 -0500 Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 17 Jun 2011 07:48:03 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcwsK+7jlsFFfB6FSJuKByn9Cmg+rQAzpKtw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: rtcsinet22.oracle.com [66.248.204.30] X-CT-RefId: str=0001.0A090209.4DFB6930.0147:SCFSTAT5015188,ss=1,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 17 Jun 2011 10:49:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47262 Archived-At: This is a multi-part message in MIME format. ------=_NextPart_000_000F_01CC2CC2.E262DFF0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > >> Feel free to change it so that instead of calling > >> `switch-to-buffer' it calls some alias or it (funcall > >> menu-bar-select-buffer-function ). > > That would be great. What do you need from me - a patch? > > For example, yes, including ChangeLog entry and a tiny note > in etc/NEWS. Attached. Changelog entry: 2011-06-17 Drew Adams * menu-bar.el: Use function variable instead of switch-to-buffer. (menu-bar-select-buffer-function): New variable. (menu-bar-update-buffers): Use menu-bar-select-buffer-function. ------=_NextPart_000_000F_01CC2CC2.E262DFF0 Content-Type: application/octet-stream; name="menu-bar-2011-06-17.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="menu-bar-2011-06-17.patch" diff -c -w "menu-bar.el" "menu-bar-patched-2011-06-17.el"=0A= *** menu-bar.el Fri Jun 17 06:52:34 2011=0A= --- menu-bar-patched-2011-06-17.el Fri Jun 17 07:14:10 2011=0A= ***************=0A= *** 1977,1982 ****=0A= --- 1977,1986 ----=0A= ;; Used to cache the menu entries for commands in the Buffers menu=0A= (defvar menu-bar-buffers-menu-command-entries nil)=0A= =0A= + (defvar menu-bar-select-buffer-function 'switch-to-buffer=0A= + "Function applied to a buffer chosen from the `Buffers' menu-bar = menu.=0A= + It must accept a buffer as its only required argument.")=0A= + =0A= (defun menu-bar-update-buffers (&optional force)=0A= ;; If user discards the Buffers item, play along.=0A= (and (lookup-key (current-global-map) [menu-bar buffer])=0A= ***************=0A= *** 2022,2028 ****=0A= (cons nil nil))=0A= `(lambda ()=0A= (interactive)=0A= ! (switch-to-buffer ,(cdr pair))))))=0A= (list buffers-vec))))=0A= =0A= ;; Make a Frames menu if we have more than one frame.=0A= --- 2026,2032 ----=0A= (cons nil nil))=0A= `(lambda ()=0A= (interactive)=0A= ! (funcall = menu-bar-select-buffer-function ,(cdr pair))))))=0A= (list buffers-vec))))=0A= =0A= ;; Make a Frames menu if we have more than one frame.=0A= =0A= Diff finished at Fri Jun 17 07:14:31=0A= ------=_NextPart_000_000F_01CC2CC2.E262DFF0 Content-Type: application/octet-stream; name="NEWS-2011-06-17.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="NEWS-2011-06-17.patch" diff -c -w "NEWS" "NEWS-patched-2011-06-17"=0A= *** NEWS Fri Jun 17 07:23:06 2011=0A= --- NEWS-patched-2011-06-17 Fri Jun 17 07:22:50 2011=0A= ***************=0A= *** 309,314 ****=0A= --- 309,320 ----=0A= The elisp implementation sha1.el is removed. Feature sha1 is provided=0A= by default.=0A= =0A= + ** Menu-bar changes=0A= + =0A= + *** Buffers menu uses variable `menu-bar-select-buffer-function'.=0A= + The value of this new variable is the function invoked when you choose=0A= + a buffer from the menu. Default value: `switch-to-buffer'.=0A= + =0A= =0C=0A= * Editing Changes in Emacs 24.1=0A= =0A= =0A= Diff finished at Fri Jun 17 07:23:19=0A= ------=_NextPart_000_000F_01CC2CC2.E262DFF0--