bug#8876: 24.0.50; making `menu-bar-update-buffers' use another frame

["Drew Adams" <drew.adams@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

> >> Feel free to change it so that instead of calling 
> >> `switch-to-buffer' it calls some alias or it (funcall 
> >> menu-bar-select-buffer-function <buf>).
> > That would be great.  What do you need from me - a patch?
> 
> For example, yes, including ChangeLog entry and a tiny note 
> in etc/NEWS.

Attached.  Changelog entry:

2011-06-17  Drew Adams <drew.adams@oracle.com>

	* menu-bar.el: Use function variable instead of switch-to-buffer.
	(menu-bar-select-buffer-function): New variable.
	(menu-bar-update-buffers): Use menu-bar-select-buffer-function.

[-- Attachment #2: menu-bar-2011-06-17.patch --]
[-- Type: application/octet-stream, Size: 1399 bytes --]

diff -c -w "menu-bar.el" "menu-bar-patched-2011-06-17.el"
*** menu-bar.el	Fri Jun 17 06:52:34 2011
--- menu-bar-patched-2011-06-17.el	Fri Jun 17 07:14:10 2011
***************
*** 1977,1982 ****
--- 1977,1986 ----
  ;; Used to cache the menu entries for commands in the Buffers menu
  (defvar menu-bar-buffers-menu-command-entries nil)
  
+ (defvar menu-bar-select-buffer-function 'switch-to-buffer
+   "Function applied to a buffer chosen from the `Buffers' menu-bar menu.
+ It must accept a buffer as its only required argument.")
+ 
  (defun menu-bar-update-buffers (&optional force)
    ;; If user discards the Buffers item, play along.
    (and (lookup-key (current-global-map) [menu-bar buffer])
***************
*** 2022,2028 ****
  					(cons nil nil))
  				  `(lambda ()
                                       (interactive)
!                                      (switch-to-buffer ,(cdr pair))))))
                     (list buffers-vec))))
  
  	 ;; Make a Frames menu if we have more than one frame.
--- 2026,2032 ----
  					(cons nil nil))
  				  `(lambda ()
                                       (interactive)
!                                      (funcall menu-bar-select-buffer-function ,(cdr pair))))))
                     (list buffers-vec))))
  
  	 ;; Make a Frames menu if we have more than one frame.

Diff finished at Fri Jun 17 07:14:31

[-- Attachment #3: NEWS-2011-06-17.patch --]
[-- Type: application/octet-stream, Size: 600 bytes --]

diff -c -w "NEWS" "NEWS-patched-2011-06-17"
*** NEWS	Fri Jun 17 07:23:06 2011
--- NEWS-patched-2011-06-17	Fri Jun 17 07:22:50 2011
***************
*** 309,314 ****
--- 309,320 ----
  The elisp implementation sha1.el is removed. Feature sha1 is provided
  by default.
  
+ ** Menu-bar changes
+ 
+ *** Buffers menu uses variable `menu-bar-select-buffer-function'.
+ The value of this new variable is the function invoked when you choose
+ a buffer from the menu.  Default value: `switch-to-buffer'.
+ 
  \f
  * Editing Changes in Emacs 24.1
  

Diff finished at Fri Jun 17 07:23:19