From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#8638: 24.0.50; Imenu should not include vacuous defvars Date: Sun, 5 Aug 2012 20:52:18 -0700 Message-ID: References: <6A3327809B8B440D99CDCDCED77E9575@us.oracle.com><0D4329D43B42401498128F9B58880C74@us.oracle.com><87mx295srs.fsf@gnu.org><0AB1806162D94500957B6BEDDBE585AB@us.oracle.com> <87hasgr8h7.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1344225200 16416 80.91.229.3 (6 Aug 2012 03:53:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Aug 2012 03:53:20 +0000 (UTC) Cc: 8638@debbugs.gnu.org To: "'Chong Yidong'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 06 05:53:20 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SyENY-0004Pm-Gz for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Aug 2012 05:53:16 +0200 Original-Received: from localhost ([::1]:34032 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyENX-0000mK-PT for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Aug 2012 23:53:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyENV-0000mF-4F for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2012 23:53:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyENU-0008IU-3h for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2012 23:53:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyENU-0008IQ-0H for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2012 23:53:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SyEV4-00072N-0j for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 00:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Aug 2012 04:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8638-submit@debbugs.gnu.org id=B8638.134422563127014 (code B ref 8638); Mon, 06 Aug 2012 04:01:01 +0000 Original-Received: (at 8638) by debbugs.gnu.org; 6 Aug 2012 04:00:31 +0000 Original-Received: from localhost ([127.0.0.1]:36369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SyEUY-00071f-JL for submit@debbugs.gnu.org; Mon, 06 Aug 2012 00:00:31 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:28159) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SyEUV-00071X-Rj for 8638@debbugs.gnu.org; Mon, 06 Aug 2012 00:00:28 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q763qYHQ003818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Aug 2012 03:52:35 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q763qYA3009124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 6 Aug 2012 03:52:34 GMT Original-Received: from abhmt113.oracle.com (abhmt113.oracle.com [141.146.116.65]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q763qWiI002866; Sun, 5 Aug 2012 22:52:33 -0500 Original-Received: from dradamslap1 (/10.159.70.99) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 05 Aug 2012 20:52:32 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87hasgr8h7.fsf@gnu.org> Thread-Index: Ac1zhaDY5BtmeYYxRNK3yurxS4o2kwAALUDw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:62859 Archived-At: > > OK, thanks. But I wonder why you treated defvar differently from > > defconst, defconstant, defcustom, defparameter, and > > define-symbol-macro here. Shouldn't the same thing apply to them? > > There is no such thing as (defconst foo), or (defcustom foo); > the second argument is non-optional. Yes, I know. > So the reasoning which was used for defvar, i.e. that a defvar > with an omitted second arg is commonly used just to silence the > compiler, does not apply. But the reasoning that such things, if they ever occurred, would not represent proper definitions, so Imenu should not index them, holds. They would represent incorrect syntax (i.e., errors), and should not be indexed. Anyway, I'm OK with them being falsely indexed, and I would agree if you made the argument that we do not try to prevent indexing of incorrect syntax in general.