From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.bugs Subject: bug#22048: 25.1; frame title vanishes when speedbar present Date: Sun, 29 Nov 2015 19:14:20 -0500 Message-ID: References: <83vb8kom0i.fsf@gnu.org> <76517F76-4494-4350-A2DF-F472910A3AC6@gmail.com> <83610koa90.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1448842521 3270 80.91.229.3 (30 Nov 2015 00:15:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Nov 2015 00:15:21 +0000 (UTC) Cc: konrad.podczeck@univie.ac.at, 22048@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 30 01:15:09 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a3C7Y-0000Gm-Tv for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2015 01:15:09 +0100 Original-Received: from localhost ([::1]:38303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3C7c-0000Ps-Sc for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Nov 2015 19:15:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3C7Y-0000Ny-VR for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2015 19:15:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3C7T-00011h-V3 for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2015 19:15:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3C7T-00011c-Rz for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2015 19:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a3C7T-0003Ld-9l for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2015 19:15:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: David Reitter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Nov 2015 00:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22048-submit@debbugs.gnu.org id=B22048.144884248612835 (code B ref 22048); Mon, 30 Nov 2015 00:15:03 +0000 Original-Received: (at 22048) by debbugs.gnu.org; 30 Nov 2015 00:14:46 +0000 Original-Received: from localhost ([127.0.0.1]:59899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a3C7B-0003Kw-Lk for submit@debbugs.gnu.org; Sun, 29 Nov 2015 19:14:46 -0500 Original-Received: from mail-qg0-f48.google.com ([209.85.192.48]:33191) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a3C6r-0003KW-5S for 22048@debbugs.gnu.org; Sun, 29 Nov 2015 19:14:43 -0500 Original-Received: by qgea14 with SMTP id a14so106671550qge.0 for <22048@debbugs.gnu.org>; Sun, 29 Nov 2015 16:14:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hLNHRbn6d/gIo4g8QT2fSfMfJodj9aE7vQ8He9nG9nY=; b=MQDkFagladiN3BsoaPQmo6vQaa/7/u3Vb3lguCUJygs6qPDJtpPDuMjXUox4vxf0E+ SaxOWM0I5rX2DZ392gbdYMNtomix+PIiD6OGIE+jkZTgEciwMfsFTGW2ZceFgBgB7bga 47VhvTlhxksZwxZMKIABKnMViMMV6RSlJ/yAv2nzTr49zu8VJWflhSNhRoUNKkxv8SX9 Gnl4a6DgyNORKV4nhSoYzG7j8H5cUSSGWFWBOsVQxQQ0XsMFViOiXeqJA9+efjT8oyvI uQQARzlSQuWeMqFSrDuDJqEEEuJX3qv2Yu1FyrZ7v06ABa1yFElxGUAuFKdguBbD+gLU yUpA== X-Received: by 10.140.43.9 with SMTP id d9mr47782660qga.51.1448842464714; Sun, 29 Nov 2015 16:14:24 -0800 (PST) Original-Received: from ?IPv6:2601:541:4000:8880:10e:c44f:bc97:3407? ([2601:541:4000:8880:10e:c44f:bc97:3407]) by smtp.gmail.com with ESMTPSA id e28sm13936387qkj.19.2015.11.29.16.14.20 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 29 Nov 2015 16:14:23 -0800 (PST) In-Reply-To: <83610koa90.fsf@gnu.org> X-Mailer: Apple Mail (2.3096.5) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109428 Archived-At: On Nov 29, 2015, at 2:50 PM, Eli Zaretskii wrote: >> x_implicitly_set_name() might not be called in the right context for = frames that are not selected. >=20 > That shouldn't happen, normally. Displaying a frame temporarily makes > it the selected frame. The buffer was not current in x_consider_frame_title when = x_implicitly_set_name is called. The consequences then are obvious, as it picks up the wrong = Vframe_title_format for the frame. I believe the change below is the correct one. It affects all = platforms, though. Are you okay with this change? If so, I would commit it. - David diff --git a/src/xdisp.c b/src/xdisp.c index 50c5518..07c771a 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -11602,7 +11602,6 @@ x_consider_frame_title (Lisp_Object frame) display_mode_element (&it, 0, -1, -1, fmt, Qnil, false); len =3D MODE_LINE_NOPROP_LEN (title_start); title =3D mode_line_noprop_buf + title_start; - unbind_to (count, Qnil); =20 /* Set the title only if it's changed. This avoids consing in the common case where it hasn't. (If it turns out that we've @@ -11613,6 +11612,9 @@ x_consider_frame_title (Lisp_Object frame) || SBYTES (f->name) !=3D len || memcmp (title, SDATA (f->name), len) !=3D 0) x_implicitly_set_name (f, make_string (title, len), Qnil); + + unbind_to (count, Qnil); + } } =20