From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#41544: 26.3; Possible incorrect results from color-distance Date: Wed, 19 Aug 2020 13:28:52 +0200 Message-ID: References: <5C4A633D-8222-4439-BE37-9B8674F1DA6D@acm.org> <55D73CA5-1EFB-4B0A-8F8B-FDA1D39F51BF@acm.org> <835zc5bsut.fsf@gnu.org> <3BBCFDD4-C14D-4628-91CB-2A0456A96FC7@acm.org> <838sh0abzz.fsf@gnu.org> <83r1us8kw6.fsf@gnu.org> <020DE875-14A8-457A-9AE4-AA0925DB8997@acm.org> <83img48ffx.fsf@gnu.org> <83bllw82xt.fsf@gnu.org> <1B0F31C8-1E11-4527-A053-DD2DE8235F58@acm.org> <83wo4g5hz6.fsf@gnu.org> <49B7D7B5-D9E3-4E97-A749-CF5E8D8EE2C6@acm.org> <83mu5b5573.fsf@gnu.org> <83lfku69q2.fsf@gnu.org> <87eeo4m5kd.fsf@gnus.org> <83d03of3pf.fsf@gnu.org> <87blj8kpsr.fsf@gnus.org> <8DE1C96A-9DE1-490D-BA13-21BFD6761788@acm.org> <874koz9c7k.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17603"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41544@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 19 13:30:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8MIF-0004Ta-3t for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Aug 2020 13:30:11 +0200 Original-Received: from localhost ([::1]:42842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8MIE-00016C-1k for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Aug 2020 07:30:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8MI7-000163-CE for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2020 07:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8MI7-0000v1-2n for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2020 07:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8MI6-0003xD-Sq for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2020 07:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Aug 2020 11:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41544-submit@debbugs.gnu.org id=B41544.159783657615140 (code B ref 41544); Wed, 19 Aug 2020 11:30:02 +0000 Original-Received: (at 41544) by debbugs.gnu.org; 19 Aug 2020 11:29:36 +0000 Original-Received: from localhost ([127.0.0.1]:38218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8MHg-0003w7-Iz for submit@debbugs.gnu.org; Wed, 19 Aug 2020 07:29:36 -0400 Original-Received: from mail154c50.megamailservers.eu ([91.136.10.164]:52740 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8MHc-0003vs-Lm for 41544@debbugs.gnu.org; Wed, 19 Aug 2020 07:29:35 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1597836570; bh=XYeYXKn4SeclTjj/3amood8P8Lsq+Mch3ga39ykzfgI=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=GHfuyo+5BH+MvQ2UWGhicA9jJSsNOuDc5CrmetrOEhqLqCngEkSSP0L5ee/Ekxuc1 TZyRVmtBRm9/DKDMzHwv2OATbkMbLkPAEAAupfmDeGY2JSHW/UeUYPGgEpYLP8f/Bs dxd2GFLFTmBcGGY7VDaDNeEAUq9ZlWN1a7vJVeOk= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 07JBTPe5016616; Wed, 19 Aug 2020 11:29:29 +0000 In-Reply-To: <874koz9c7k.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.15) X-CTCH-RefID: str=0001.0A782F22.5F3D0D1A.0043, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NoevjPVJ c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=LUUatbi7KA7-G3vn9BgA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185575 Archived-At: [CC list trimmed] 19 aug. 2020 kl. 12.11 skrev Lars Ingebrigtsen : > I'm not quite sure I follow you here, but could these other = computations > also be fixed, with a defcustom to switched between the two = computation > methods? Technically yes, but is there is a reason for users to adjust this = particular behaviour? Users dissatisfied with the outcome of the = existing algorithms typically curse and set colours explicitly (or = suffer in silence); they are unlikely to set a 'use different algorithm' = variable. To be precise, the computations I suppose we are talking about are = located in: frame-set-background-mode (frame.el:1184) xterm-maybe-set-dark-background-mode (xterm.el:1122) rxvt-set-background-mode (rxvt.el:198) terminal-init-w32console (w32console.el:89) which all use the predicate (r+g+b)/3 < 0.6 to determine if a colour is = dark. It is also mentioned in a comment in pc-win.el:57. I believe it to be suboptimal but have no plans to do anything about it.