From: "Thomas Voss" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 73472@debbugs.gnu.org
Subject: bug#73472: [PATCH] Substitute quotation marks in Eglot messages
Date: Wed, 25 Sep 2024 16:03:32 +0200 [thread overview]
Message-ID: <D4FF6JKKR5J9.3FQPLNQ9B4BS7@thomasvoss.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 251 bytes --]
Hi all,
Another quick patch from myself. This patch makes it so that the
diagnostics and interactive prompts from Eglot (such as the prompt you
iteract with when renaming a symbol) properly respect
‘text-quoting-style’.
--
— Thomas
[-- Attachment #2: 0001-Substitute-quotation-marks-in-Eglot-messages.patch --]
[-- Type: text/x-patch, Size: 1788 bytes --]
From 2038b983a751a2e26c2e8a0b8d55ade29fb394fd Mon Sep 17 00:00:00 2001
From: Thomas Voss <mail@thomasvoss.com>
Date: Wed, 25 Sep 2024 15:51:36 +0200
Subject: [PATCH] Substitute quotation marks in Eglot messages
* lisp/progmodes/eglot.el (eglot--error) (eglot--message): Wrap the
message in `substitute-quotes'.
* lisp/progmodes/eglot.el (eglot-rename): Format the prompt using
`format-prompt' as opposed to `format'.
Copyright-paperwork-exempt: yes
---
lisp/progmodes/eglot.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index a358b82..ee52767 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -1698,11 +1698,11 @@ eglot--connect
;;;
(defun eglot--error (format &rest args)
"Error out with FORMAT with ARGS."
- (error "[eglot] %s" (apply #'format format args)))
+ (error "[eglot] %s" (substitute-quotes (apply #'format format args))))
(defun eglot--message (format &rest args)
"Message out with FORMAT with ARGS."
- (message "[eglot] %s" (apply #'format format args)))
+ (message "[eglot] %s" (substitute-quotes (apply #'format format args))))
(defun eglot--warn (format &rest args)
"Warning message with FORMAT and ARGS."
@@ -3704,8 +3704,8 @@ eglot-rename
"Rename the current symbol to NEWNAME."
(interactive
(list (read-from-minibuffer
- (format "Rename `%s' to: " (or (thing-at-point 'symbol t)
- "unknown symbol"))
+ (format-prompt "Rename `%s' to" nil (or (thing-at-point 'symbol t)
+ "unknown symbol"))
nil nil nil nil
(symbol-name (symbol-at-point)))))
(eglot-server-capable-or-lose :renameProvider)
--
2.46.2
next reply other threads:[~2024-09-25 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 14:03 Thomas Voss via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-09-25 16:01 ` bug#73472: [PATCH] Substitute quotation marks in Eglot messages Eli Zaretskii
2024-09-25 18:03 ` Thomas Voss via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-26 5:52 ` Eli Zaretskii
2024-09-26 6:11 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4FF6JKKR5J9.3FQPLNQ9B4BS7@thomasvoss.com \
--to=bug-gnu-emacs@gnu.org \
--cc=73472@debbugs.gnu.org \
--cc=mail@thomasvoss.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).