From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#61896: 30.0.50; Emacs crashes because of an invalid free Date: Thu, 2 Mar 2023 16:21:12 +0100 Message-ID: References: <87fsaoqkwo.fsf@posteo.net> <83zg8vel1t.fsf@gnu.org> <875ybjcz4t.fsf@posteo.net> <981CDB22-6430-44B5-8316-BD8268B22C83@acm.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_8448328E-B3B4-4A75-AF6F-277859A7355F" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25020"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 61896@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 02 16:22:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkl9-0006JH-Ii for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Mar 2023 16:22:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXkku-0007Fk-Eo; Thu, 02 Mar 2023 10:22:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXkks-0007FT-U4 for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 10:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXkks-0007Gu-Jl for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 10:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXkks-0004G9-5S for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 10:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Mar 2023 15:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61896 X-GNU-PR-Package: emacs Original-Received: via spool by 61896-submit@debbugs.gnu.org id=B61896.167777048216307 (code B ref 61896); Thu, 02 Mar 2023 15:22:02 +0000 Original-Received: (at 61896) by debbugs.gnu.org; 2 Mar 2023 15:21:22 +0000 Original-Received: from localhost ([127.0.0.1]:58109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXkkD-0004Ex-Up for submit@debbugs.gnu.org; Thu, 02 Mar 2023 10:21:22 -0500 Original-Received: from mail18c50.megamailservers.eu ([91.136.10.28]:45540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXkkB-0004Eo-S9 for 61896@debbugs.gnu.org; Thu, 02 Mar 2023 10:21:21 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1677770477; bh=EDSeKI4ZruDr37tKngpWhICCPY7WSf1b0SQC7HiJIog=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=eowyyRHvtlKhsZSU8XRn7y/gflANHOrb5/QNwk8yr7FP5jwyrXmwNYFWpG2pmYX+1 jzhrwSo5uVNXKDlTvRmjQ/if5xiatPLxWwhDm0qC01n3DgIQkXc32Y2WLibrur/5gl 9fIjKyDETijTxhoONIixVsWS1ecNQymri8jhfgfc= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se [188.150.171.209]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 322FLDm7028042; Thu, 2 Mar 2023 15:21:15 +0000 In-Reply-To: <981CDB22-6430-44B5-8316-BD8268B22C83@acm.org> X-Mailer: Apple Mail (2.3654.120.0.1.14) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrudeljedgjeefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffquffvqffrkfetpdfqfgfvpdfgpfggqdevhedtnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhkfgtggfuffgjvefvfhfosehmtdhmrehhtddvnecuhfhrohhmpeforghtthhirghsucfgnhhguggvghonrhguuceomhgrthhtihgrshgvsegrtghmrdhorhhgqeenucggtffrrghtthgvrhhnpeeiuddvteeuteduleegueektdeguddvgeefteejkedvhedtlefhvdfgheeigeeuheenucfkphepudekkedrudehtddrudejuddrvddtleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedukeekrdduhedtrddujedurddvtdelpdhhvghlohepshhmthhptghlihgvnhhtrdgrphhplhgvpdhmrghilhhfrhhomhepmhgrthhtihgrshgvsegrtghmrdhorhhgpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepphhhihhlihhpkhesphhoshhtvghordhnvghtpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepie dukeelieesuggvsggsuhhgshdrghhnuhdrohhrgh X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257161 Archived-At: --Apple-Mail=_8448328E-B3B4-4A75-AF6F-277859A7355F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > These checks do not audit the specpdl balance directly but that would = be something to add if you don't make further progress. You could try this patch if you build with --enable-checking=3Dall: --Apple-Mail=_8448328E-B3B4-4A75-AF6F-277859A7355F Content-Disposition: attachment; filename=bytecode-specpdl-depth-check.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="bytecode-specpdl-depth-check.diff" Content-Transfer-Encoding: 7bit diff --git a/src/bytecode.c b/src/bytecode.c index 74a94859aba..8f30fa55829 100644 --- a/src/bytecode.c +++ b/src/bytecode.c @@ -382,6 +382,9 @@ #define BC_STACK_SIZE (512 * 1024 * sizeof (Lisp_Object)) const unsigned char *saved_pc; /* previous program counter */ Lisp_Object fun; /* current function object */ +#ifdef ENABLE_CHECKING + specpdl_ref entry_specpdl_depth; /* specpdl depth at function entry */ +#endif Lisp_Object next_stack[]; /* data stack of next frame */ }; @@ -484,10 +487,6 @@ exec_byte_code (Lisp_Object fun, ptrdiff_t args_template, setup_frame: ; eassert (!STRING_MULTIBYTE (bytestr)); eassert (string_immovable_p (bytestr)); - /* FIXME: in debug mode (!NDEBUG, BYTE_CODE_SAFE or enabled checking), - save the specpdl index on function entry and check that it is the same - when returning, to detect unwind imbalances. This would require adding - a field to the frame header. */ Lisp_Object vector = AREF (fun, COMPILED_CONSTANTS); Lisp_Object maxdepth = AREF (fun, COMPILED_STACK_DEPTH); @@ -511,6 +510,9 @@ exec_byte_code (Lisp_Object fun, ptrdiff_t args_template, fp->saved_pc = pc; fp->saved_fp = bc->fp; bc->fp = fp; +#ifdef ENABLE_CHECKING + fp->entry_specpdl_depth = SPECPDL_INDEX (); +#endif top = frame_base - 1; unsigned char const *bytestr_data = SDATA (bytestr); @@ -878,6 +880,8 @@ #define DEFINE(name, value) [name] = &&insn_ ## name, CASE (Breturn): { + eassert (specpdl_ref_eq (bc->fp->entry_specpdl_depth, + SPECPDL_INDEX ())); Lisp_Object *saved_top = bc->fp->saved_top; if (saved_top) { --Apple-Mail=_8448328E-B3B4-4A75-AF6F-277859A7355F--