From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#65030: 30.0.50; Check keyword args of make-process Date: Sun, 6 Aug 2023 10:49:59 +0200 Message-ID: References: <83a5v5u9nf.fsf@gnu.org> <83o7jkrcme.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25660"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, 65030@debbugs.gnu.org, eller.helmut@gmail.com, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 06 10:51:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSZTh-0006UH-8k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Aug 2023 10:51:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSZTc-00045p-MH; Sun, 06 Aug 2023 04:51:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSZTb-00042l-03 for bug-gnu-emacs@gnu.org; Sun, 06 Aug 2023 04:51:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSZTa-0003Q4-N1 for bug-gnu-emacs@gnu.org; Sun, 06 Aug 2023 04:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSZTa-0002x8-6v for bug-gnu-emacs@gnu.org; Sun, 06 Aug 2023 04:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Aug 2023 08:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65030 X-GNU-PR-Package: emacs Original-Received: via spool by 65030-submit@debbugs.gnu.org id=B65030.169131181111287 (code B ref 65030); Sun, 06 Aug 2023 08:51:02 +0000 Original-Received: (at 65030) by debbugs.gnu.org; 6 Aug 2023 08:50:11 +0000 Original-Received: from localhost ([127.0.0.1]:58642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSZSk-0002vy-S3 for submit@debbugs.gnu.org; Sun, 06 Aug 2023 04:50:11 -0400 Original-Received: from mail205c50.megamailservers.eu ([91.136.10.215]:45330 helo=mail193c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSZSf-0002vj-FV for 65030@debbugs.gnu.org; Sun, 06 Aug 2023 04:50:09 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1691311803; bh=2hf050fS8pblFbUAhzjAT6FtdBTQRABuug+7r6I1b2c=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=UgyOeEZw1bYxBtvAhwiZEYeUOg+c6Y3NQXXhz+8g93Tf61XV7ePJ3MA9K9qoe8dLN LDYMk/ziUqn3PEHAHdYF6DmCA8rsAl+R2HmSVJL1yjOjnSqGLPESD9O07qzblhsyak GCeNF9Kr2LLa9wXc70Z70uV3H3r4xr6nl1dvOcGo= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail193c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 3768o04M120126; Sun, 6 Aug 2023 08:50:02 +0000 In-Reply-To: <83o7jkrcme.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedviedrkeekgddtkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfjqffuvffqrffktedpqfgfvfdpgffpggdqveehtdenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurheptggguffhjgffvefgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeforghtthhirghsucfgnhhguggvghonrhguuceomhgrthhtihgrshgvsegrtghmrdhorhhgqeenucggtffrrghtthgvrhhnpeevkeffudejhfekhedvgfffieekgffhfedvkeeuffelgeefkeeulefhjeeifeekgfenucfkphepudekkedrudehtddrudeihedrvdefheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedukeekrdduhedtrdduieehrddvfeehpdhhvghlohepshhmthhptghlihgvnhhtrdgrphhplhgvpdhmrghilhhfrhhomhepmhgrthhtihgrshgvsegrtghmrdhorhhgpdhnsggprhgtphhtthhopeehpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggrpdhrtg hpthhtohepvghllhgvrhdrhhgvlhhmuhhtsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprhhplhhuihhmsehgmhgrihhlrdgt X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266840 Archived-At: 6 aug. 2023 kl. 06.58 skrev Eli Zaretskii : > Any specific comments to the proposed patch? Or do you think it is > good to go? Good to go as far as I'm concerned. It will be genuinely useful, and I = see no serious problems with the implementation. It can be extended but that would not prevent it from being committed = as-is. For example, something that detects omitted values in the middle, = not just the end, of the argument list. (The feasibility of this depends = on the likelihood of argument values being keywords themselves.) The main objection is that `make-process`, due to its design, is often = called indirectly using `apply` which would not trigger the application = of this compiler macro, so perhaps we should improve the error handling = of Fmake_process instead.