From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Andrus Newsgroups: gmane.emacs.bugs Subject: bug#18854: 25.0.50; Inferior Python mode should use derived-mode-p [with patch] Date: Fri, 14 Nov 2014 21:03:51 +0000 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1415999069 20598 80.91.229.3 (14 Nov 2014 21:04:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 14 Nov 2014 21:04:29 +0000 (UTC) Cc: "18854@debbugs.gnu.org" <18854@debbugs.gnu.org> To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 14 22:04:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XpO2W-0000Fk-S2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Nov 2014 22:04:20 +0100 Original-Received: from localhost ([::1]:37877 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpO2W-0002Q4-3y for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Nov 2014 16:04:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpO2M-0002Pi-Bz for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2014 16:04:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpO2E-0008Sv-QQ for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2014 16:04:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpO2E-0008Sp-MX for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2014 16:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XpO2E-0003HS-9P for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2014 16:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Andrus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Nov 2014 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18854-submit@debbugs.gnu.org id=B18854.141599903712599 (code B ref 18854); Fri, 14 Nov 2014 21:04:02 +0000 Original-Received: (at 18854) by debbugs.gnu.org; 14 Nov 2014 21:03:57 +0000 Original-Received: from localhost ([127.0.0.1]:32901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpO29-0003H9-2T for submit@debbugs.gnu.org; Fri, 14 Nov 2014 16:03:57 -0500 Original-Received: from mail-bn1bon0071.outbound.protection.outlook.com ([157.56.111.71]:56926 helo=na01-bn1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpO25-0003Gz-HQ for 18854@debbugs.gnu.org; Fri, 14 Nov 2014 16:03:54 -0500 Original-Received: from BY2PR0201MB0711.namprd02.prod.outlook.com (25.160.124.17) by BY2PR0201MB0711.namprd02.prod.outlook.com (25.160.124.17) with Microsoft SMTP Server (TLS) id 15.1.16.15; Fri, 14 Nov 2014 21:03:52 +0000 Original-Received: from BY2PR0201MB0711.namprd02.prod.outlook.com ([25.160.124.17]) by BY2PR0201MB0711.namprd02.prod.outlook.com ([25.160.124.17]) with mapi id 15.01.0016.006; Fri, 14 Nov 2014 21:03:51 +0000 Thread-Topic: bug#18854: 25.0.50; Inferior Python mode should use derived-mode-p [with patch] Thread-Index: AQHP8f9gynUtvvKMskuV4sJwl4M1LZxEN77KgBwL44A= In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.4.5.141003 x-originating-ip: [75.162.204.71] x-microsoft-antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2PR0201MB0711; x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:; SRVR:BY2PR0201MB0711; x-forefront-prvs: 03950F25EC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(51704005)(199003)(189002)(24454002)(377454003)(479174003)(5423002)(46102003)(92566001)(21056001)(99396003)(110136001)(86362001)(120916001)(230783001)(19580395003)(83506001)(101416001)(92726001)(19580405001)(64706001)(20776003)(105586002)(31966008)(107046002)(4396001)(66066001)(2656002)(87936001)(77096003)(77156002)(62966003)(106356001)(76176999)(54356999)(36756003)(40100003)(97736003)(50986999)(122556002)(99286002)(106116001)(95666004)(94096001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0201MB0711; H:BY2PR0201MB0711.namprd02.prod.outlook.com; FPR:; MLV:sfv; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Content-ID: X-OriginatorOrg: adobe.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96039 On 10/27/14, 11:45 AM, "Stefan Monnier" wrote: >> I maintain sage-mode which is implemented as a derived mode of >> python-mode. Likewise with inferior-sage-mode and inferior-python-mode. >> There are some places in python-mode where major-mode is checked with >> eq. This causes some weird breakage when using sage-mode, particularly >> it causes inferior-sage-mode to hang in some situations [1]. I could >> probably work around it on the sage-mode side, but I think it makes >> sense to use derived-mode-p instead, so I'm including this patch > >Looks good, please install, > > > Stefan I installed this on master . I can backport to emacs-24 if that's desirable. I now realize I forgot to add "Fixes: debbugs:18854" to my commit message (which presumably would close this bug). Hopefully I didn't mess anything else up too badly. -Ivan