From: Ivan Andrus <iandrus@adobe.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "18854@debbugs.gnu.org" <18854@debbugs.gnu.org>
Subject: bug#18854: 25.0.50; Inferior Python mode should use derived-mode-p [with patch]
Date: Fri, 14 Nov 2014 21:03:51 +0000 [thread overview]
Message-ID: <D08BBB11.E897%iandrus@adobe.com> (raw)
In-Reply-To: <jwvoasxe792.fsf-monnier+emacsbugs@gnu.org>
On 10/27/14, 11:45 AM, "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:
>> I maintain sage-mode which is implemented as a derived mode of
>> python-mode. Likewise with inferior-sage-mode and inferior-python-mode.
>> There are some places in python-mode where major-mode is checked with
>> eq. This causes some weird breakage when using sage-mode, particularly
>> it causes inferior-sage-mode to hang in some situations [1]. I could
>> probably work around it on the sage-mode side, but I think it makes
>> sense to use derived-mode-p instead, so I'm including this patch
>
>Looks good, please install,
>
>
> Stefan
I installed this on master . I can backport to emacs-24 if that's
desirable.
I now realize I forgot to add "Fixes: debbugs:18854" to my commit message
(which presumably would close this bug). Hopefully I didn't mess anything
else up too badly.
-Ivan
next prev parent reply other threads:[~2014-11-14 21:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 16:02 bug#18854: 25.0.50; Inferior Python mode should use derived-mode-p [with patch] Ivan Andrus
2014-10-27 17:45 ` Stefan Monnier
2014-10-27 22:14 ` Ivan Andrus
2014-11-14 21:03 ` Ivan Andrus [this message]
2014-11-15 3:14 ` Stefan Monnier
2014-11-15 21:38 ` Glenn Morris
2014-11-15 5:28 ` Ivan Andrus
2014-11-15 19:05 ` bug#18854: Fabián Ezequiel Gallina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D08BBB11.E897%iandrus@adobe.com \
--to=iandrus@adobe.com \
--cc=18854@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).