From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60805: [PATCH] Extend go-ts-mode with command to add docstring to function Date: Sat, 21 Jan 2023 08:34:43 +0100 Message-ID: References: <87sfgdtga2.fsf@thornhill.no> <875yd4njdc.fsf@thornhill.no> <87r0vpv7fp.fsf@thornhill.no> <87a62dkkj5.fsf@thornhill.no> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28265"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Evgeni Kolev , Eli Zaretskii , 60805@debbugs.gnu.org To: Eshel Yaron , Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 21 08:35:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJ8PP-0007BB-Ke for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Jan 2023 08:35:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJ8PI-0007Oj-8X; Sat, 21 Jan 2023 02:35:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ8P0-0007OC-S7 for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 02:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJ8P0-0005BL-IW for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 02:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJ8P0-0001KE-E2 for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 02:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jan 2023 07:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60805 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60805-submit@debbugs.gnu.org id=B60805.16742864915071 (code B ref 60805); Sat, 21 Jan 2023 07:35:02 +0000 Original-Received: (at 60805) by debbugs.gnu.org; 21 Jan 2023 07:34:51 +0000 Original-Received: from localhost ([127.0.0.1]:47855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ8Op-0001Ji-1E for submit@debbugs.gnu.org; Sat, 21 Jan 2023 02:34:51 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:13911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ8Om-0001JW-2u for 60805@debbugs.gnu.org; Sat, 21 Jan 2023 02:34:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1674286485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kwOTRletYbkQibgQocnRjHPMqCLZb2Wj2Q2L35F2+Xc=; b=VDlwf/ISq2jQ8GagJKFAmiYB9FO7SBwZx6wTvui+1fgplPPZeafP5ZqrAasrsw/LzyuD4H ktZUs/cADaB4m+SN6tEK1142MBwwFz96dV2WT6gLgYsjqWT/PVSNqaYRzdGaexrAS7vsna 6dJGfoESUu0pwgEmHWK8Fja7LUtupmGpkQNnt0e2cBuSpSjK3SUKnUsaRgweNvmMStAfCG GktyA8AoYexfwV+zwKXuTdyhNR8ivfi2mYE1z00xMIfnGECyhtxKrNP/NvqQuSVH3tHt22 DpbDWRLZKP7r2acUaVA3Ru6Pllb9Orq0179t6RQ5ksYU/JqLNJ32bVoeuGMfiA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253829 Archived-At: On 21 January 2023 07:48:48 CET, Eshel Yaron wrote: > >A quick thought from someone interested in using this new command: > >IMO the current implementation is a bit too opinionated to be really >useful=2E Inserting the function's name at the beginning of the comment >is not always desired because different teams have different conventions >for doc comments, and sometimes you just want to add a nolint >directive[0] which again doesn't start with the function's name=2E > >My suggestion is to add some way for users to customize/extend the >contents of the inserted doc comment=2E One option is to have a variable >that'll hold a function responsible for determining the text of the >comment=2E This variable can then default to a function that returns the >current Go function's name=2E > >Thanks, >Eshel > > >[0] https://golangci-lint=2Erun/usage/false-positives/#nolint-directive Why not just (insert "// ") Theo