From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Thu, 5 Jan 2023 22:55:39 -0700 Message-ID: References: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32321"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60376@debbugs.gnu.org, Eli Zaretskii , 60376-done@debbugs.gnu.org, Theodor Thornhill To: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 06 06:56:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDfiR-0008Dv-Vy for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Jan 2023 06:56:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDfi0-0007zn-Nq; Fri, 06 Jan 2023 00:56:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDfhz-0007z8-43 for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 00:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDfhy-0003kj-Rh for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 00:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDfhy-0000rQ-DI for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 00:56:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2023 05:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.16729845493283 (code B ref 60376); Fri, 06 Jan 2023 05:56:02 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 6 Jan 2023 05:55:49 +0000 Original-Received: from localhost ([127.0.0.1]:53522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDfhk-0000qr-Kh for submit@debbugs.gnu.org; Fri, 06 Jan 2023 00:55:48 -0500 Original-Received: from mail-pj1-f49.google.com ([209.85.216.49]:33655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDfhj-0000qb-8j; Fri, 06 Jan 2023 00:55:47 -0500 Original-Received: by mail-pj1-f49.google.com with SMTP id fz16-20020a17090b025000b002269d6c2d83so5170162pjb.0; Thu, 05 Jan 2023 21:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=8FVqL3hTjzuM2HccqDdqVGuKTMQaMsFV5L46DnhvrVQ=; b=jbJOIb0KDDWpIBzePM49NJQoPqfelWl/CbvcDmu1Vxe6FRCBwYa3Mqi7IbT/qy0+Zr 3+R1ZXwtp8E6q1cz3pSciKujzv16WgY+dk3Ce6JiEpLrKkutIovr9fEAurt4/lYURo9O 6R8Rt6Keo0D2gcPWQAoN2zUo1+TqIBFJxPBSmLGB2mVN4vjN3/Ba0tU6Hri9HbTqlUUz co0PpwlGwLVSRrwMWvi4UeGgob9fdY4NezRyEhWkK0UrFyqGjUAub8/MRDJ4sjSjgat5 OUBVLnK7aGSL1RhAwSHOC05n6WuOouoD95lAv+Sw3mG+pKVACMPlgUj7owMGYtUHeX5Y ymRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8FVqL3hTjzuM2HccqDdqVGuKTMQaMsFV5L46DnhvrVQ=; b=uxhJcRqaW9y28AyL+cXfRGXuZPl5RnNqMcMa38AtBYYcOf8BUFnU4l+XoRfoFqi0f5 6PMVb3hC8lf/dWhWkNvoFLLmO76meSx5px+kr+ZUsb77Q1/lW9i8zdzInX3TNw8wmHhm obfM1t3n4Y+6lgCoqjFQgybk4MIWaxnlHlSUUxETMPHRXQNKuQV3SAh6rXMBNVuyFDvt rLnzI4t7OJhO3joer0C9Sb7/cuBuCZpibM5bqAtjVkUSYj4OOrbeh29ezihpksQ3Sb/N z8AB3mfHgOXX6xuHOu3ceLIC2lgJGqcsjPwHSlPeJMo7XI0415J5u95+qfB8MDQ6YWk0 HWxg== X-Gm-Message-State: AFqh2krf27tDFY5u9GCNn7pz3RERKo9UKxy8iEs1FJC38cBByILYSEBi Q21dZ7IcNNNbtIEuWjgWt97uGClyHuE= X-Google-Smtp-Source: AMrXdXv24iEorjsJP0hB5qxS6nANu4L8d+lmdGJ0SWVV2r4rp1s7C0CJaW/2WpG3s9Hsy+Z6dGoW2w== X-Received: by 2002:a17:903:40c8:b0:189:ab82:53f5 with SMTP id t8-20020a17090340c800b00189ab8253f5mr43479847pld.40.1672984541355; Thu, 05 Jan 2023 21:55:41 -0800 (PST) Original-Received: from smtpclient.apple (ip68-3-33-122.ph.ph.cox.net. [68.3.33.122]) by smtp.gmail.com with ESMTPSA id u7-20020a170903124700b00189a50d2a3esm26874314plh.241.2023.01.05.21.55.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2023 21:55:41 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252655 Archived-At: Jostein Kj=C3=B8nigsen writes: > On 03.01.2023 06:43, Jostein Kj=C3=B8nigsen wrote: >> Yuan: did you forget applying this last patch? :) >> >> =E2=80=94 >> Jostein Kj=C3=B8nigsen >> https://jostein.kj=C3=B8nigsen.net >> >>> On 2 Jan 2023, at 10:59, Jostein Kj=C3=B8nigsen = wrote: >>> Great! Thanks! >>> >>> Please note: The previous patch removed a very wide (generic_name >>> (identifier)) selector, which incorrectly caused generic functions >>> to be highlighted as a types. >>> >>> This has lead to having to add in more specific (xxx (generic_name >>> (identifier)) selectors around the codebase to compensate, and the >>> previous patch evidently didn't have "all" the ones we need. >>> >>> Attached is a very small patch which should make support for >>> highlighting generic types more complete. I won't promise it has >>> 100% coverage, but with this in place, I can't see any obvious >>> places in code where I'm missing out. >>> >>> With this in place, the only thing I'd like to improve now (if any) >>> is indentation for object-creation/initialization expressions. I've >>> made a few attempts and can't get those to behave properly. >>> >>> Is this anything you could take a look at, Theo? :) >>> >>> -- >>> Jostein >>> > > Given the feature-freeze on emacs-29 now, could someone please get the > above patch installed? > > That would at least make me feel more comfortable :) Theo hasn=E2=80=99t get back yet but I=E2=80=99m sure the patch is good, = so I just applied it :-) Yuan