From: "Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: "70134@debbugs.gnu.org" <70134@debbugs.gnu.org>,
Eli Zaretskii <eliz@gnu.org>, "larsi@gnus.org" <larsi@gnus.org>,
Alex Bochannek <alex@bochannek.com>,
Richard Stallman <rms@gnu.org>
Subject: bug#70134: [PATCH] Show all date options when adding Gnus scores interactively
Date: Fri, 10 May 2024 20:38:07 +0000 [thread overview]
Message-ID: <CvUn_TXpmNQdoLmYlGYI649YZjuvJ1-F6OOrrEPaEMfg6kuUMsWZe2E2rjPaEAKXteytkzD1CCQQjN2amI6uyraszv8lnOpfMxJFXs3axyw=@kubajecminek.cz> (raw)
In-Reply-To: <87y18hph60.fsf@ericabrahamsen.net>
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
Apologies for the formatting, I’m writing this reply from my phone.
> And sure enough, the modification of the string is the point -- it's a
> cache! From gnus-sum.el:
>
> ; Since this is called not only to sort the top-level threads, but
> ; also in recursive sorts to order the articles within a thread, each
> ; article will be processed many times. Thus it speeds things up
> ; quite a bit to use gnus-date-get-time, which caches the time value.
> (defun gnus-thread-latest-date (thread)
> "Return the highest article date in THREAD."
> (apply #'max
> (mapcar (lambda (header) (float-time
> (gnus-date-get-time
> (mail-header-date header))))
> (flatten-tree thread))))
>
> Can we strip properties around the call, maybe?
I don’t think there’s need to do that. The change that I proposed in the patch should remove the unintended side effect (and thus fix the bug pointed by Alex) while keeping the caching behaviour intact (‘gnus-thread-latest-date’ code above will work as expected).
[-- Attachment #2: Type: text/html, Size: 1177 bytes --]
next prev parent reply other threads:[~2024-05-10 20:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 21:44 bug#70134: [PATCH] Show all date options when adding Gnus scores interactively Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-13 7:58 ` Eli Zaretskii
2024-04-22 3:33 ` Eric Abrahamsen
2024-04-24 22:52 ` Richard Stallman
2024-04-24 23:08 ` Alex Bochannek
2024-05-01 19:27 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-07 2:53 ` Alex Bochannek
2024-05-09 19:15 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-09 23:59 ` Eric Abrahamsen
2024-05-10 20:04 ` Eric Abrahamsen
2024-05-10 20:38 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-10 21:27 ` Eric Abrahamsen
2024-05-14 2:00 ` Alex Bochannek
2024-05-14 14:52 ` Eric Abrahamsen
2024-05-14 18:43 ` Alex Bochannek
2024-05-14 19:57 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-16 14:15 ` Eric Abrahamsen
2024-05-16 19:40 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 21:34 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-22 23:30 ` Alex Bochannek
2024-05-23 2:50 ` Eric Abrahamsen
2024-05-26 14:22 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-26 22:09 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 21:23 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 0:16 ` Alex Bochannek
2024-05-30 9:01 ` Andrea Corallo
2024-05-30 16:30 ` Alex Bochannek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CvUn_TXpmNQdoLmYlGYI649YZjuvJ1-F6OOrrEPaEMfg6kuUMsWZe2E2rjPaEAKXteytkzD1CCQQjN2amI6uyraszv8lnOpfMxJFXs3axyw=@kubajecminek.cz' \
--to=bug-gnu-emacs@gnu.org \
--cc=70134@debbugs.gnu.org \
--cc=alex@bochannek.com \
--cc=eliz@gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=kuba@kubajecminek.cz \
--cc=larsi@gnus.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).