unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: defun.foo--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
	56643@debbugs.gnu.org, akrl@sdf.org
Subject: bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation
Date: Thu, 21 Jul 2022 10:01:57 +0000	[thread overview]
Message-ID: <CkyCedgeBtgEBdT1_8DMIERv8xTdZtq5jZKF-uot6Q-GzpPGpCrnO9P-AchWwZUxdDrij5zAyvkRa2oupjgfzScO2qlaJlTyKhoFbI4rsJc=@proton.me> (raw)
In-Reply-To: <838ronkpzh.fsf@gnu.org>

> > Alternatively we could introduce a named helper function. Note there
> > are more calls of `help-setup-xref' using lambdas in arguments.
>
>
> And that would solve the problem? Did you try that?

I tried it with describe-function and it does solve the problem, although as noted above there are many other functions that generate help buffers and pass in a lambda.

Named helper:

(defun describe-function-xref-func (function buffer)
  (let ((describe-function-orig-buffer
                    (if (buffer-live-p buffer) buffer)))
               (describe-function function)))

Revised describe-function snippet:

    (help-setup-xref
     (list 'describe-function-xref-func function describe-function-orig-buffer)
     (called-interactively-p 'interactive))

This produces the following bookmark, which I confirmed still works after restarting Emacs:

("named-function-help-bookmark"
 (position . 1)
 (last-modified 25305 7198 806743 243000)
 (help-fn . describe-function-xref-func)
 (help-args completing-read "*scratch*")
 (position . 1)
 (handler . help-bookmark-jump))

> > I see a more general problem: anywhere where printing an anonymous
> > function readably is necessary there is a potential breakage when using
> > natively compiled Emacs - right?  That would be quite a limitation.

I had the same thought. I'd bet there are other packages that rely on being able to read code back reliably. I"m curious if there is any metadata at all attached to a natively-compiled function?





  reply	other threads:[~2022-07-21 10:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 13:45 bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation defun.foo--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-19 16:49 ` Eli Zaretskii
2022-07-19 22:22   ` defun.foo--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-20  9:51     ` Andrea Corallo
2022-07-20 11:21     ` Andrea Corallo
2022-07-20 11:45       ` Eli Zaretskii
2022-07-20 18:31         ` Andrea Corallo
2022-07-20 19:16           ` Eli Zaretskii
2022-07-20 22:47             ` Michael Heerdegen
2022-07-21  5:13               ` Eli Zaretskii
2022-07-21 10:01                 ` defun.foo--- via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-07-21 12:33                   ` Eli Zaretskii
2022-07-22 13:40                     ` Eli Zaretskii
2022-07-22 13:41                     ` Andrea Corallo
2022-07-22 14:40                       ` Eli Zaretskii
2022-07-23  9:57                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CkyCedgeBtgEBdT1_8DMIERv8xTdZtq5jZKF-uot6Q-GzpPGpCrnO9P-AchWwZUxdDrij5zAyvkRa2oupjgfzScO2qlaJlTyKhoFbI4rsJc=@proton.me' \
    --to=bug-gnu-emacs@gnu.org \
    --cc=56643@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    --cc=defun.foo@proton.me \
    --cc=eliz@gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).