From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#11445: [External] : Re: bug#11445: 24.0.96; Customize buffer edit fields should have undo Date: Wed, 2 Jun 2021 16:43:57 +0000 Message-ID: References: <428727A8D734409481B739A7443120C5@us.oracle.com> <87h7ig94zg.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1505"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "11445@debbugs.gnu.org" <11445@debbugs.gnu.org> To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 02 18:45:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loTzj-00008b-L1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Jun 2021 18:45:27 +0200 Original-Received: from localhost ([::1]:52354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loTzi-0004R0-Lq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Jun 2021 12:45:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loTzK-0004PT-TD for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 12:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loTzK-0003T3-HD for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 12:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loTzK-0000NR-Eo for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 12:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Jun 2021 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11445 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 11445-submit@debbugs.gnu.org id=B11445.16226522501363 (code B ref 11445); Wed, 02 Jun 2021 16:45:02 +0000 Original-Received: (at 11445) by debbugs.gnu.org; 2 Jun 2021 16:44:10 +0000 Original-Received: from localhost ([127.0.0.1]:41253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loTyT-0000Lu-JP for submit@debbugs.gnu.org; Wed, 02 Jun 2021 12:44:09 -0400 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:41430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loTyS-0000Lg-Fm for 11445@debbugs.gnu.org; Wed, 02 Jun 2021 12:44:09 -0400 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 152Gd2wa096934; Wed, 2 Jun 2021 16:44:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=04uRKYANQPd7BMwnSM9ZM1LWSUWm4LnuyRERpD+20BI=; b=Acb/c982FyqqTnWroMR3txic8L1rA1p96e4Jqt4dSkz3FLS8AIn0umUZELV+vLyQ5u0l 9waT30xwJEPDp04k7M0ts9d2vkxr2LYLnKZGC3iiAp+ZUef1Rn7sSHMCV1C5LcPP28of 1/yZdufdIjxSWa21u2tyM5WDn7SCxknSvOh8R/OItNNTEIV4zrTSnMPfJncMMTAJMW0+ wEnr7OfUNaw5ZT41ocd9npFxG12/vNG3k1pV+sfW2/VWBh061lYhnD+7W6m/jIEEt+kn 44xK/EoKmHlcG9mbnThgdZI91WwzGpDc30XiywiaXRYePa5GuXD/LBnVVZGYv2EQOhQj 8w== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 38ub4cs7d9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Jun 2021 16:44:01 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 152GeeaU010137; Wed, 2 Jun 2021 16:44:00 GMT Original-Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2105.outbound.protection.outlook.com [104.47.70.105]) by userp3020.oracle.com with ESMTP id 38x1bd28hw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Jun 2021 16:44:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VOgw91yi6vOgJ6trni5EFSEiMPQThrPb4G/5u5VIsNY/rH7O8Vc9hPjZWHas41+JMLxw+NiBC7z5blCOoRWxzgC62JKvcVOOPw2pQErHSPRd5+6+3dnFHjSdPg3g02kAF5FrVTRtijmxOIAW4VpoAAldPBFqmQa4j+HjbpoNgtaBSZP9JgHdIriWHIeCAL2fOx3Db1CrTYGDw3HpPQiWRX24BuKkx3CnLwN1U9NIiq1GRAfEqWTMsC8X5UojT1PwRagFnrv164z//O4UpquOSFgx+CTts4V4Tm8DLPvqHkVO7g1SiYAsc6Tpch+wik+D2bNKWx7MfusmL0io8CV/Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=04uRKYANQPd7BMwnSM9ZM1LWSUWm4LnuyRERpD+20BI=; b=dGyAoIoWfMDvK2rOHOda8Bt23eAPnH7hBnfNfqdDUv5t6AGO57HP8uOA9Z/p2zFfPUetKtvMg9XKPsqAQoeTdlhxx/duKtWJzS72g89pkHqCJYs9xy6Kr+nNPBQv+ncCTFl/4HODCIZ8QSqspz62v6Y90Gv/Q/COyvbp0UDjDsRusssyXtK0dcSf+VXG+ys0wHcr/SbquLrrBbVsH4EDCC1C4qpd3PejjEEh7TTsgWdU2YG1o+V2kS/FUGleBoh+w11tuXyPufLUK9VHvx78bSXNbWOevXnxzK1jFhxCuoZCTi11hJRtoCCf1l40evJWnPDpTFb210rlRHUHwOwEXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=04uRKYANQPd7BMwnSM9ZM1LWSUWm4LnuyRERpD+20BI=; b=I/Xvynx1KI2qPOC8xvZLcD23w+2l0/cqXUfxJUtdCYU29BvJWi/30AUQYpj2usg6Pe0l6kHUNAxJASsdEEAOD1y77VkkHPaMEa0TCpbhQuEKr6/DyHVnn50wKBvyflpSkiKR9y4pFab35Zt5+W5uYX2Dwc6OmaUtKhcaA5ClV6I= Original-Received: from CO1PR10MB4466.namprd10.prod.outlook.com (2603:10b6:303:9b::10) by MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.27; Wed, 2 Jun 2021 16:43:58 +0000 Original-Received: from CO1PR10MB4466.namprd10.prod.outlook.com ([fe80::f8ce:e306:cfd7:6f9f]) by CO1PR10MB4466.namprd10.prod.outlook.com ([fe80::f8ce:e306:cfd7:6f9f%7]) with mapi id 15.20.4173.030; Wed, 2 Jun 2021 16:43:57 +0000 Thread-Topic: [External] : Re: bug#11445: 24.0.96; Customize buffer edit fields should have undo Thread-Index: AQHXV3U6TE24DFUakE6QhgtbdqU9gqsA6JRg In-Reply-To: <87h7ig94zg.fsf@gnus.org> Accept-Language: en-US Content-Language: en-US authentication-results: gnus.org; dkim=none (message not signed) header.d=none;gnus.org; dmarc=none action=none header.from=oracle.com; x-originating-ip: [73.170.83.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 95cbc29f-4529-4335-81f6-08d925e59e17 x-ms-traffictypediagnostic: MWHPR1001MB2365: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IAfdEiowUh4MQvxmph4ACQTcggazodQTcx4PPQaEOJS7J3VwmafAx6CcrCT3GjhwtGPFyIT8EY+vXm8KcSjIjx0pdaHXnZU2b9d9nJXU4bHrc1KpOZ7s8sg7ymF0JRCpjN8spdVbDyXf+FXkFIkfSlHxyGgNw72vFZBigM4h3Ny+ShbsoOTTwlaVKnjDMpttnCIAFmSjJdh/4JXbRLA00DzyQfFrkWbpZVt6GCHYtVVccXCE75UdTNAh296N6PLtYYhSul5zW8EwTni2GDPcjDzfQcT5bmJ2m5U4AbigFFpSpZ7G72eISSTsXpAcIIYTFTraQTsrusGWVHClLJP9FjOLcyYXCuVc1yZaUQqsAPaojgE3bLiW9Lp55cvo1GgDBIcxShHO8pW9uaOUEEzDFGWWaB1EDkR8jgTGauW9cpO+2m55Ho0d8MHwQKQJkz5iGlu6j6ve6IhTCp9q6ZyDdY7OG9L/e2lzWcx9ZS8gw2hIbl0jViNOGK8iOA4P0oRnCZxXm6Yp2m6mrYtK4jWbA69VF21eQ2ORRXqjPEPc/RQA3K3czn34vvoNDW6ZXnhviFjRrACpPl4f7DOxwkDwfifqeldkKBnz4NZwUw/TiKY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR10MB4466.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(136003)(366004)(346002)(376002)(396003)(66446008)(6506007)(66476007)(83380400001)(2906002)(66556008)(64756008)(66946007)(55016002)(76116006)(71200400001)(186003)(8936002)(8676002)(26005)(38100700002)(122000001)(6916009)(478600001)(5660300002)(9686003)(86362001)(316002)(4326008)(52536014)(7696005)(44832011)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 3S/sPLCgWHaJWa8W+F2Js5JJ/xQx0PKxqmPz2K+LIPtAHvK6Sq7j1ZYsoRn1Uqd2hRsrO9F+LkbU7/3OwWGUbRYFpAJAgLNt4afBX1nCCSYu1G02fflbl5w7nU7AcncFYyOHh6jQGdfLn3EUu9zetm0QoVJuaKP31B3rxYtZ3rLFsNNywfCdr7VmTob1uC+xoMUVF3N3APv2+JHi/vbTi9B3GTnuG5Ec6WGlY4FWybjHCysAZQKv0MI3kOaoyjYEnzmJCXEqTU3SF41xiKC1hloDDSuaVIozr7bsvI9ltKQq88l4NFQi6xeYMbnoXCBAhq26p01pOO+zqIemktqLbABTg3f8J/BIf+EOwZc0XE4p0pT3skslAxUOoDpIoTLCNNgOHIEb6agVu37i8F5m8rfXepe1QML11fCJiBQ/6/+/PXrGhHSflJGXUVka7TPxL3L29iPpqZ6Pguo+SzxIi8jeKq1XDFMZztOIHM0XZvC/H/GXPOp0l+oGfHy0nEvToWf39fhjIbPLEUaOjaPPFG296wH9YM3LbNOR3C8NbHjaco+vQ1GrI1kSJGD+L6ImK4nNpuVhaoAr4fOHGKCZsOal4Iv8iEy8nrN9fis4fOpDseX2DckIuKLFG4aiL2/YE8+eWwezIRGm+Yd47GB5VYjApVL6njSHA9dZoJHh+EpNpHiuiQ/RDi4tLCDMCIPeBRf9E5bRsFR0b40yA8x08JC9W1wP55xbcwJDg5+VgKzUyJAvZa0fKSlVHKwX JC1d5Yh2wCBkjp+p760XzF49/m2MLF8/5XjtqqKyxxw0o4S+uYWTh/Lq9tgSOdTFxfqPD1GhNQZV1sDaCoW7IY2/L/5DV0FXF7 x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4466.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95cbc29f-4529-4335-81f6-08d925e59e17 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2021 16:43:57.8321 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KXVPVvHLWNdXD8dUptozIeva1ja2XPaqceqDtqvdiP2+qy94Yt1xM8wYSS3p7axV8JsuG4++kJU2qxPWH/1Pzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2365 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10003 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106020105 X-Proofpoint-GUID: 6UmnnlneJYUCkfM0bQTJQ1R62alIiLGQ X-Proofpoint-ORIG-GUID: 6UmnnlneJYUCkfM0bQTJQ1R62alIiLGQ X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10003 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 clxscore=1011 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106020105 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207876 Archived-At: > > A text editing field in Customize is like text > > editing in general. Why shouldn't undo be available > > to users here? >=20 > As far as I can tell, `undo' works fine in text fields in Customize > buffers. Are you still seeing this problem in recent Emacs versions? Good question. Pulling up Emacs 23 now to check what this was about... Some editable fields, at least, do have undo. But not once you've chosen `Set for current session'. Just as you can continue to edit a field after you've chosen to set the value, so I think you should be able to undo previous edits you made. Why would we turn off undo, just because you chose set, or even save? As long as editing is available so should undo be available. (We don't change fields to read-only just because you chose set or save.) In fact, the problem is worse. Consider customizing an option such as `Info-default-directory-list'. Each editable field has its own undo, and as soon as you move to another editable field and edit it you lose the ability to undo changes you made previously to the first field. You can then try to make other changes to the already changed first field, but undo then takes you back only as far as what was frozen when you went on to edit the second field. This isn't helpful. You should be able to undo globally, throughout the Customize buffer. Secondly, considering "editing" more broadly, why not let undo apply even to other changes you make in the buffer, from `Toggle' to a `Value Menu' choice. The point is to be able to undo changes you've made to the option, regardless of whether you've chosen set or save yet. These non-edit-field kinds of changes are not in the same ball-park, admittedly, so fixing this for them might involve more work. But this is something to aim for, and it should be part of this bug fix (enhancement request, if you prefer). In particular, consider `customize-face' changes. For the most part changes to attributes involve using `Value Menu'. It's important, I think, to be able to undo a bunch of such changes, and not just changes in an individual editable field. ___ There, that constitutes a needed supplement to my admittedly terse bug report. At least I'm thinking that this is what I was thinking of. ___ That was all taking a look with Emacs 23.4. Now let me look at Emacs 27.2, to see if any of that has already been fixed... And I see no improvement in any of that. I'd ask that this bug remain open. HTH.