bug#28893: emacs-26.0.90 minor build issue on OpenIndiana

bug#28893: emacs-26.0.90 minor build issue on OpenIndiana

[Nelson H. F. Beebe]

I found that the build of emacs-26.0.90 on OpenIndiana (a descendant
of the short-lived OpenSolaris from Sun/Oracle) that is identified as

	% cat /etc/release
		     OpenIndiana Development oi_151.1.9 X86 (powered by illumos)
		Copyright 2011 Oracle and/or its affiliates. All rights reserved.
				Use is subject to license terms.
				   Assembled 17 January 2014

failed at link time because of a missing symbol, tparm.

The configure output shows

	checking for library containing tputs... -ltermcap

and the generated src/Makefile has

	LIBS_TERMCAP=-ltermcap

The problem is that -lcurses, -ltermcap, and -ltermlib on this system
are NOT complete substitutes of each other.

However, that is wrong, because of these contents:

	% nm -D -p /usr/lib/libcurses.so.1 | egrep 'tputs|tparm'
	0000117616 T tparm
	0000116848 T tparm_p0
	0000116976 T tparm_p1
	0000117104 T tparm_p2
	0000117232 T tparm_p3
	0000117360 T tparm_p4
	0000117488 T tparm_p7
	0000121348 T tputs

	% nm -D -p  /usr/lib/libtermcap.so.1 | egrep 'tputs|tparm'
	0000000000 T tputs

	% nm -D -p /usr/lib/libtermlib.so.1 | egrep 'tputs|tparm'
	0000117616 T tparm
	0000116848 T tparm_p0
	0000116976 T tparm_p1
	0000117104 T tparm_p2
	0000117232 T tparm_p3
	0000117360 T tparm_p4
	0000117488 T tparm_p7

I restarted the build with

	gmake LIBZ='-ltermlib -lz'

and it completed normally, and has been successfully installed.

-------------------------------------------------------------------------------
- Nelson H. F. Beebe                    Tel: +1 801 581 5254                  -
- University of Utah                    FAX: +1 801 581 4148                  -
- Department of Mathematics, 110 LCB    Internet e-mail: beebe@math.utah.edu  -
- 155 S 1400 E RM 233                       beebe@acm.org  beebe@computer.org -
- Salt Lake City, UT 84112-0090, USA    URL: http://www.math.utah.edu/~beebe/ -
-------------------------------------------------------------------------------

bug#28893: emacs-26.0.90 minor build issue on OpenIndiana

[Noam Postavsky]

merge 28893 23748
quit

"Nelson H. F. Beebe" <beebe@math.utah.edu> writes:

> I found that the build of emacs-26.0.90 on OpenIndiana (a descendant
> of the short-lived OpenSolaris from Sun/Oracle) that is identified as
>
> 	% cat /etc/release
> 		     OpenIndiana Development oi_151.1.9 X86 (powered by illumos)
> 		Copyright 2011 Oracle and/or its affiliates. All rights reserved.
> 				Use is subject to license terms.
> 				   Assembled 17 January 2014
>
> failed at link time because of a missing symbol, tparm.

Hmm, it seems you already reported this for emacs 25, but there was no
response[1].

[1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23748

> 	% nm -D -p /usr/lib/libtermlib.so.1 | egrep 'tputs|tparm'
> 	0000117616 T tparm
> 	0000116848 T tparm_p0
> 	0000116976 T tparm_p1
> 	0000117104 T tparm_p2
> 	0000117232 T tparm_p3
> 	0000117360 T tparm_p4
> 	0000117488 T tparm_p7
>
> I restarted the build with
>
> 	gmake LIBZ='-ltermlib -lz'
>
> and it completed normally, and has been successfully installed.

In the other bug, you suggested looking for a library providing both
tputs and tparm, here, if I understand correctly, you just used one
library for each.  It's not clear what's the best fix for this, the
configure code looks pretty messy...

bug#28893: emacs-26.0.90 minor build issue on OpenIndiana

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

Thanks for the bug report. I installed the attached patch into the emacs-26 
branch, and I hope it works for you. Can you please give it a try on OpenIndiana 
by replacing the single instance of "termcap curses" with "curses termcap" in 
the 'configure' shell script, and then re-running 'configure'?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Port-to-OpenIndiana.patch --]
[-- Type: text/x-patch; name="0001-Port-to-OpenIndiana.patch", Size: 967 bytes --]

From a3f12ce63d2915a12d4d7b2f67697815bf2714c8 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 22 Oct 2017 22:44:42 -0700
Subject: [PATCH] Port to OpenIndiana

Problem reported by Nelson H. F. Beebe (Bug#28893).
Also see Bug#23748, Bug#9736, and Bug#5735.
* configure.ac (tputs_library): Prefer libcurses to libtermcap,
since OpenIndiana libtermcap lacks tparm.
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 63324c2..8d14115 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4035,7 +4035,7 @@ AC_DEFUN
 else
   # Maybe curses should be tried earlier?
   # See https://debbugs.gnu.org/9736#35
-  for tputs_library in '' tinfo ncurses terminfo termcap curses; do
+  for tputs_library in '' tinfo ncurses terminfo curses termcap; do
     OLIBS=$LIBS
     if test -z "$tputs_library"; then
       emacs_cv_tputs_lib='none required'
-- 
2.7.4

bug#28893: emacs-26.0.90 minor build issue on OpenIndiana

[Nelson H. F. Beebe]

Paul Eggert proposes a small patch to the emacs-26.0.90 configure
script to deal with the build problem that I reported for OpenIndiana.

I've just done a fresh build on that system, and Paul's patch solves
the problem:

	diff configure.~1~ configure
	17027c17027
	<   for tputs_library in '' tinfo ncurses terminfo termcap curses; do
	---
	>   for tputs_library in '' tinfo ncurses terminfo curses termcap; do

The build procedure went like this:

	set path= ( /bin /usr/bin /sbin /usr/sbin )

	env CONFIG_SITE= ./configure --prefix=$L --with-pop \
		--with-gnutls=no --with-gif=no && \
		gmake all check

	... long output omitted...

	% ./src/emacs --version | head -1
	GNU Emacs 26.0.90

I suggest, however, that configure.ac acquire some explanatory
comments to document why -lcurses should be searched before -ltermcap
on OpenIndiana.

-------------------------------------------------------------------------------
- Nelson H. F. Beebe                    Tel: +1 801 581 5254                  -
- University of Utah                    FAX: +1 801 581 4148                  -
- Department of Mathematics, 110 LCB    Internet e-mail: beebe@math.utah.edu  -
- 155 S 1400 E RM 233                       beebe@acm.org  beebe@computer.org -
- Salt Lake City, UT 84112-0090, USA    URL: http://www.math.utah.edu/~beebe/ -
-------------------------------------------------------------------------------

bug#28893: emacs-26.0.90 minor build issue on OpenIndiana

[Noam Postavsky]

tags 9736 fixed
close 9736 26.1
quit

"Nelson H. F. Beebe" <beebe@math.utah.edu> writes:

> Paul Eggert proposes a small patch to the emacs-26.0.90 configure
> script to deal with the build problem that I reported for OpenIndiana.
>
> I've just done a fresh build on that system, and Paul's patch solves
> the problem:

Okay, closing.

> I suggest, however, that configure.ac acquire some explanatory
> comments to document why -lcurses should be searched before -ltermcap
> on OpenIndiana.

A later commit [1: 19667f44ef], adds a mention of OpenIndiana, and the
existing reference to Bug#9736 explains the reasoning for AIX (AFAICT,
the library situation is the same on both these OSes).

[1: 19667f44ef]: 2017-10-24 11:46:53 -0700
  * configure.ac: Tweak libcurses diagnostic.
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=19667f44efabda7d4e53e706c6cd8140145b2a1a