From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#62043: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu Date: Fri, 10 Mar 2023 18:16:48 +0000 Message-ID: References: <394FE8AD-FAB3-4244-BD16-2D2014DAF2B0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29863"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "62043-done@debbugs.gnu.org" <62043-done@debbugs.gnu.org> To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 10 19:18:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pahJr-0007UI-4Q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Mar 2023 19:18:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pahJc-000817-AX; Fri, 10 Mar 2023 13:18:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pahJa-00080m-N6 for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 13:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pahJa-0007cH-Ej for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 13:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pahJa-00050b-Ab for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 13:18:02 -0500 Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Mar 2023 18:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62043 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 62043@debbugs.gnu.org, dev@rjt.dev, dev@rjt.dev Original-Received: via spool by 62043-done@debbugs.gnu.org id=D62043.167847223419187 (code D ref 62043); Fri, 10 Mar 2023 18:18:02 +0000 Original-Received: (at 62043-done) by debbugs.gnu.org; 10 Mar 2023 18:17:14 +0000 Original-Received: from localhost ([127.0.0.1]:55853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pahIn-0004zP-Ka for submit@debbugs.gnu.org; Fri, 10 Mar 2023 13:17:13 -0500 Original-Received: from mail-40136.proton.ch ([185.70.40.136]:46113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pahIk-0004zA-K6 for 62043-done@debbugs.gnu.org; Fri, 10 Mar 2023 13:17:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1678472223; x=1678731423; bh=jn3Cq99Nc9SNW7PL9NGUeAzAmfzdsiuNzSX+GVH6LBU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=t22L9EmzvJZn3z8hhAJNFRrAW7B/HXDLuRpOygcW0e3gL1VQxdTmfKeKYGmfDS7yF hKTb9HzKWtCOFmmnVSXcIV8yS0Jtw8DG7oYY92ZOzpeRur3nqFA9Sve91o3saKTxqP WLuHamqudXvFnEeRY2h9LGx2WmuirPWQBlEklbZujF2CA8My/CzR4GP1ftDdSrCDRv Wp+EhhfUfftwJy7DZclYpsrzecXEecdRWG8maEQkPICSFK8gYdbG4pmI/+IKOWUGYH YaGIL8BRvCQn5e1ACP00f5ColP/lwcmYZ+Al/ZRYlD11BOSChZdkeDNpKPDYm2XkfZ 0D184LJI4dA0w== In-Reply-To: <394FE8AD-FAB3-4244-BD16-2D2014DAF2B0@gmail.com> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257711 Archived-At: On Friday, March 10th, 2023 at 00:59, Yuan Fu wrote: >=20 > > On Mar 8, 2023, at 6:04 PM, Randy Taylor dev@rjt.dev wrote: > >=20 > > On Wednesday, March 8th, 2023 at 18:27, Yuan Fu casouri@gmail.com wrote= : > >=20 > > > > On Mar 7, 2023, at 5:49 PM, Randy Taylor dev@rjt.dev wrote: > > > >=20 > > > > X-Debbugs-CC: casouri@gmail.com > > > >=20 > > > > With {c, c++}-ts-mode, enums appear as structs in imenu. The attach= ed patch fixes this. > > > >=20 > > > > Example: > > > > enum Thing { A, B, C }; > > > >=20 > > > > Should appear as Enum Thing > > > > <0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch> > > >=20 > > > Thanks! I wonder what determines which categories to merge together a= nd which to not? If we separate Enums, should we also separate Unions? > > >=20 > > > Yuan > >=20 > > I think they should all be separate actually. Attached a patch that doe= s so.<0001-Fix-enums-and-unions-appearing-as-structs-in-c-ts-ba.patch> >=20 >=20 > That=E2=80=99s probably the right thing to do. I applied the patch, thank= s! >=20 > Yuan Thanks, closing.