From: Gabriel <gabriel376@hotmail.com>
To: 50176@debbugs.gnu.org
Subject: bug#50176: [PATCH] 28.0.50; repeat-mode does not clear echo-area after timeout
Date: Mon, 23 Aug 2021 19:25:30 -0300 [thread overview]
Message-ID: <CH2PR01MB5879B2257E1D6228627E271E8BC49@CH2PR01MB5879.prod.exchangelabs.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
Description:
When repeat-mode is enabled and a repeat-exit-timeout is set, the
echo-area is not cleared in case the echo-area has some content and a
single repeat-command is executed.
Steps:
1) emacs -Q (from master branch)
2) eval
(setq repeat-exit-timeout 1)
(repeat-mode 1)
3) create some windows with 'C-x 2' and 'C-x 3'
4) 'C-x'
5) wait prefix "C-x" to appear on echo-area
6) 'o' (echo-area will now contain "C-x o [Repeat with o, O]")
7) wait a few seconds so 'repeat-exit-timeout' takes effect
Expected: the echo-area is cleared
Actual: the echo-area is not cleared
If 'o' is pressed again, it will run 'self-insert-command' even though
the echo-area is still showing "C-x o [Repeat with o, O]".
Now repeat steps 1-5 but press 'o' quickly to invoke the repeat command
multiple times (which will trigger other-window multiple times). The
echo-area changes to "Repeat o, O" and is properly cleaned after
'repeat-exit-timeout' seconds.
Patch:
I created a simple patch that seems to fix this probem. The
'string-prefix-p' was replaced with 'string-match-p' to handle cases
where echo-area contains some other message. This check seems very poor,
though, so any better approach is welcome.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-to-clear-echo-area-after-repeat-exit-timeout.patch --]
[-- Type: text/x-patch, Size: 908 bytes --]
From e6de15337bf4516740c0e790f6a2bfb3deaf9b5b Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
Date: Mon, 23 Aug 2021 19:05:58 -0300
Subject: [PATCH] Fix to clear echo-area after repeat-exit-timeout.
* lisp/repeat.el (repeat-echo-message): Use 'string-match-p'
to handle cases where echo-area contains other messages.
---
lisp/repeat.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/repeat.el b/lisp/repeat.el
index cec3cb643a..054eacf8ec 100644
--- a/lisp/repeat.el
+++ b/lisp/repeat.el
@@ -474,7 +474,7 @@ repeat-echo-message
(if (current-message)
(message "%s [%s]" (current-message) mess)
(message mess)))
- (when (string-prefix-p "Repeat with " (current-message))
+ (when (string-match-p "Repeat with " (current-message))
(message nil))))
(defvar repeat-echo-mode-line-string
--
2.32.0
next reply other threads:[~2021-08-23 22:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 22:25 Gabriel [this message]
2021-08-24 6:44 ` bug#50176: [PATCH] 28.0.50; repeat-mode does not clear echo-area after timeout Juri Linkov
2021-08-24 14:31 ` Gabriel
2021-08-24 18:20 ` Juri Linkov
2021-08-25 17:11 ` Juri Linkov
[not found] <FB0B8735-EB16-44C4-8D9A-E0141DF4A552@acm.org>
2021-08-25 17:06 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR01MB5879B2257E1D6228627E271E8BC49@CH2PR01MB5879.prod.exchangelabs.com \
--to=gabriel376@hotmail.com \
--cc=50176@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).