From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel do Nascimento Ribeiro Newsgroups: gmane.emacs.bugs Subject: bug#45811: 28.0.50; [PATCH] Respect remember-save-after-remembering on remember-diary-extract-entries Date: Tue, 12 Jan 2021 01:21:50 -0300 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6441"; mail-complaints-to="usenet@ciao.gmane.io" To: 45811@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 12 05:23:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzBDR-0001YS-JQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 05:23:33 +0100 Original-Received: from localhost ([::1]:49194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzBDQ-0007Sh-L7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jan 2021 23:23:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzBCw-0007RU-5v for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 23:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzBCv-0008QC-VJ for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 23:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzBCv-0002KB-Ps for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 23:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel do Nascimento Ribeiro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jan 2021 04:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45811 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16104253248868 (code B ref -1); Tue, 12 Jan 2021 04:23:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Jan 2021 04:22:04 +0000 Original-Received: from localhost ([127.0.0.1]:58909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzBC0-0002Ix-4L for submit@debbugs.gnu.org; Mon, 11 Jan 2021 23:22:04 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:41984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzBBw-0002IX-Te for submit@debbugs.gnu.org; Mon, 11 Jan 2021 23:22:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzBBw-0006rB-He for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 23:22:00 -0500 Original-Received: from mail-co1nam11olkn2103.outbound.protection.outlook.com ([40.92.18.103]:13536 helo=NAM11-CO1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzBBu-00085h-C3 for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 23:21:59 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EbsQNOMKg4RDDdy7zWWkOOVYKdcR0/YKtfpeclw+hciyjq6ntgzHy6NbscVB7Tk1nK9kTeXlT/4sYlzZg2YVYbu9YLpSVdNwkuPoV8Rnvdw4hJrrIyevFVSixyV/0a9LO3w8jMbRcdRZF76Hhr3oJEooeaa7JFCAr/4rZkQBuwJFbQ+nM4GBk3EAT9jOPyx5Z+5AoupGWT+zXc2CvWPgsqAdjd2RrbiDTbQzjrPdh0GRH43bd/0ro46gXRXpFDSVQm1GwuWYXBNGEIEK0FO/FdeaDzKbhUAr5Lm12t/xdUFrOPgUjH+cy/QtQkt8OTw/KNHu9GPcctLsg8aIlt730w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J6LyQYfdby9QYI7S2OmYDb9/JFnUychqiBJCs1qX24o=; b=GlRB6CNIeVrmsXTRYH3GVmM2f0gzpvMlZ1lxu6CJVXdD7VJetrW74Ph5e1bJfqCB/L2e81o7rtGH5athOHraKMJjVk+tb9UqGkwavn7oFEv9aig5vdfom0cOZU9CvSOA2Bl3g3Hkq+CEMyuKT+rBxLM4b1Q59JGlptqjYy1YefOS3z6B5V69dmIzQDUTfq/WIupr592S4PcA5bkTBzwjpHOr7/6V3YDxTy48xkVWb6PmaU3Xc89mZ1aE99TsJqC9pwmRMLCNf54jVYxb6cGDQ9M+aQclOGLe6KEm/NX9/3wxtrMfA8J9ma3N424hZOomHG3qz4oKVmVFRQXgPTcOsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J6LyQYfdby9QYI7S2OmYDb9/JFnUychqiBJCs1qX24o=; b=lnrKYxXlFf4BUmAmVnXdoHjnSJduJaBhAXdhlyygYzt0Qo0LS1DZwMvqLvikj8mtCqkSYC0/RFZKpaR8Dt1Mve2B0fg5JGOUSrFvAVFuzu494BMMR1S2rOzTU2/9DRy4vPLBiPHr1K8tFvud7QqnmNaj6culzihpoCDMk0ebTaF0GMzdF4+yd+b7m6ecS/NrfYr5ATamNWoM7TL3xzzSldGIoyOeXhpefocw+j83no/3Uj70ZLRf8bLhMy17Sh7YsgUdKjTB5g83XlmJoQ6T8M5DvL35qXZNEkQZ7gOHqg2GdPykJrrxgBSooLnl2TOXtNlFUM5yFgn1/0wu6BncHQ== Original-Received: from BN8NAM11FT009.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::46) by BN8NAM11HT020.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::414) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Tue, 12 Jan 2021 04:21:55 +0000 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com (2a01:111:e400:fc4b::53) by BN8NAM11FT009.mail.protection.outlook.com (2a01:111:e400:fc4b::65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Tue, 12 Jan 2021 04:21:55 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:F1E75CEE191B8C40B41D03F22929ECB8756BC4C7C6794CF39CAED93191C5087F; UpperCasedChecksum:98ACA96FD839CA55B1525F3674ABB7982B5C8C9048AF3AFCFD31C7A6F571ACA8; SizeAsReceived:7303; Count:42 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::d51d:8cbe:370a:39ac]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::d51d:8cbe:370a:39ac%7]) with mapi id 15.20.3742.012; Tue, 12 Jan 2021 04:21:55 +0000 X-TMN: [KWUfVNTw68u4Zu6D3BD2zQCuUn06QRrMqNr27F29szvT1Tbsq5rKjk28CtJ++fB0] X-ClientProxiedBy: CP5P284CA0002.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:95::7) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <8735z6g4yp.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from precision5540 (2804:431:c7f3:af8f:58c4:f4c3:a2c3:b56e) by CP5P284CA0002.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:95::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Tue, 12 Jan 2021 04:21:54 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 42 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: a5352dbb-cfa7-439c-1d8b-08d8b6b1987e X-MS-TrafficTypeDiagnostic: BN8NAM11HT020: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 28btarjp7NdWTDTFz0EZKMKfses27YO+xu56tClFRwXvqReegOKgkvZiDFDibfPwZvLf/WzKrocu1CTZB27F2HtpWoJC7z18sVD49bqDLHQGW52kauTXVu558tHUsqWuhJWc/c7GY9dtoYoRwyWyy8K7jyHtOl7uInpbWcOEdFF6QnITy+MfDQH8Jz2Y55/8ifKNPHONVpgos3dJODxkavqFp2Z260aphKScrKdP3G9EZc2l2eEYsNVuYTYPE3T2 X-MS-Exchange-AntiSpam-MessageData: dgmlFmEoYqRpM3iqfG7PxicJlLv7zEB0cEpHye9UNkO6oRUlyMVg6afgSxIA45LBketPEQBaBUOfld9KfU7a/fDa27An0pA4f+SEH2gghBodrVuNSgHiiU86oMAjbffEgZ1gto24gnTS07vXBJyXdo66g2mA/94R3vj1FLb0G3ztFNb2GKN2mXf9iaC7uQ1N2P7M/kgv9ZyVFb9drfVIiw== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2021 04:21:55.5834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: a5352dbb-cfa7-439c-1d8b-08d8b6b1987e X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT009.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM11HT020 Received-SPF: pass client-ip=40.92.18.103; envelope-from=gabriel376@hotmail.com; helo=NAM11-CO1-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197770 Archived-At: --=-=-= Content-Type: text/plain On remember.el, when option 'remember-handler-functions' contains handler 'remember-diary-extract-entries', entries will be appended to Diary file. However, the Diary file will not be saved automatically. I could not find any documentation describing if this behavior is expected, and the docstring for 'remember-save-after-remembering' does not mention how the Diary file should be handled in this case. Given that, there is a patch attached to automatically save the Diary file when option 'remember-save-after-remembering' is 't'. If this is the wrong behavior, we could improve the improve the docstring or show the Diary buffer to user after data is appended. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Respect-remember-save-after-remembering-on-remember-.patch >From aa305cc45029387cba0de9ee00a4b58e1b022104 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Tue, 12 Jan 2021 01:11:26 -0300 Subject: [PATCH] Respect remember-save-after-remembering on remember-diary-extract-entries --- lisp/textmodes/remember.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/remember.el b/lisp/textmodes/remember.el index 98d3a3856e..911523fb47 100644 --- a/lisp/textmodes/remember.el +++ b/lisp/textmodes/remember.el @@ -542,7 +542,10 @@ remember-diary-extract-entries (push (remember-diary-convert-entry (match-string 1)) list)) (when list (diary-make-entry (mapconcat 'identity list "\n") - nil remember-diary-file)) + nil remember-diary-file) + (when remember-save-after-remembering + (with-current-buffer (find-buffer-visiting diary-file) + (save-buffer)))) nil))) ;; Continue processing ;;; Internal Functions: -- 2.27.0 --=-=-=--