From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel do Nascimento Ribeiro Newsgroups: gmane.emacs.bugs Subject: bug#45808: 28.0.50; [PATCH] Add option remember-diary-regexp Date: Tue, 12 Jan 2021 12:53:29 -0300 Message-ID: References: <83k0sidw5e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34182"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 45808@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 12 16:54:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzLzm-0008m1-E7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 16:54:10 +0100 Original-Received: from localhost ([::1]:56266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzLzl-0002C8-D0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 10:54:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzLze-0002Bn-Q0 for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 10:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzLze-0008DG-JG for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 10:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzLze-0005I7-I1 for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 10:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel do Nascimento Ribeiro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jan 2021 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161046682520316 (code B ref -1); Tue, 12 Jan 2021 15:54:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Jan 2021 15:53:45 +0000 Original-Received: from localhost ([127.0.0.1]:32893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzLzM-0005Hb-MI for submit@debbugs.gnu.org; Tue, 12 Jan 2021 10:53:45 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:50384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzLzJ-0005HS-Kc for submit@debbugs.gnu.org; Tue, 12 Jan 2021 10:53:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzLzJ-00029D-9o for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 10:53:41 -0500 Original-Received: from mail-bn7nam10olkn2094.outbound.protection.outlook.com ([40.92.40.94]:23776 helo=NAM10-BN7-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzLzE-0007yR-OB for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 10:53:41 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y9xvBFp0w7OsSbbXEQ6fnm4DNArtUTypMjyLM2rQfaDEHTNiHB14JeUJb+pfEEp1G+GcVwx5DbFJ+V42qfYJOe9fISg5DeRCcTIFDsqErJseaGkFeQfeeWXF6gpMOlALejO+iNsSKk5WYPTdL4zhFjL+KACeEL6MLsm4t6X/CxBv5OdXLu4C0wRo3XF4UJY32VBgGOCXr4Hpd2KQISthyOZoyu/uJYGsHYCZqY3JAUC5vZMFVhIqzyuHSRCnPhz9+Mh6CFaeVpU1/UhGywrizuPURpz/0to56wJeMUVG/JXwMEuOzHWZi0SR9VD3sV6/gc3w5MuW71a6jmvvfVUdbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2qRGhVRL4Jqw5AU9yoH16EOgFqhTZ2llvYGzb5DOdiQ=; b=SoHznkcDiSCVPIA3cnMx2Vpvg0BIERyyzxTMRAsaT0zOlRDi4gjScdNNCvrXVBDf58xp+OpyOMbbLgeATiqZNVbLEDm1GH7kTfR/wg6ggDs+D/fCNyKTHS39ofi4wnhieSOQxuqi5f92lEF5Uo2cyiZXvCod3KtXC+gMSXvMOYYM6Psr8t48HFqeUCeUN9pto39Bb4NRGwTL9frZThIun7xIKJRO/TGEqt8zO5MZn0TB8e0N2A0tyAFw/oCQTig2u+8W2piuQs2ZMnv7WsxObaRsthJg9TycC2+iRmVvS8EfhCMqeWts0wssImX7AEQAFN9p0vGW1iziR2+9mxkPbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2qRGhVRL4Jqw5AU9yoH16EOgFqhTZ2llvYGzb5DOdiQ=; b=UcHjLQPQ9eh/zIstZBtgPmYTWBXBM2gG/ru8al817N+yS5fOKgg3Olma9lTVFo16w+8SGHFmd/WgFH3So/KYezKW6TgvDVzPIEjXDZNPuVhm4ODLPpXIgnLmc7W0Y/+Xi1v7epfC6Nifm7IExNVengbqpA5dqXOCdoOVAPsccwE7JKnN0dRu82IuuzMef182RoLYG1E1AahOBBDtpRjCTntgOYkxdft3uaoL4R/0B6ejsPsBlhCDCDxWqQ7A/pjcEGLswWysRjxzkmxt/LezlhpOJEzvOyaM5BdyasotwFMdFhbFzzjuJAS+e341ZqjRSz177AlcbJZVPB+VccIVGg== Original-Received: from BN7NAM10FT056.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::40) by BN7NAM10HT220.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::364) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.9; Tue, 12 Jan 2021 15:53:35 +0000 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com (2a01:111:e400:7e8f::48) by BN7NAM10FT056.mail.protection.outlook.com (2a01:111:e400:7e8f::149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.9 via Frontend Transport; Tue, 12 Jan 2021 15:53:34 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:47ECFBC34A15C1F93682E696BDF6DFB69B8BC697A71726BFBBBFAF2654073D15; UpperCasedChecksum:16E4CBD87A1E925C6D8060C05CC679EFEE6A85B35E67A3224D1CF49467CB1EE5; SizeAsReceived:7559; Count:45 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::d51d:8cbe:370a:39ac]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::d51d:8cbe:370a:39ac%7]) with mapi id 15.20.3742.012; Tue, 12 Jan 2021 15:53:34 +0000 In-Reply-To: <83k0sidw5e.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Jan 2021 17:15:09 +0200") X-TMN: [X82ctgP/+XPT9AHIz/svdvhWK/UkYMtNtw9h99nNZDrrbHE32QrwtwzrbC1eOmco] X-ClientProxiedBy: CP5P284CA0019.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:94::6) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <877doip2x2.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from precision5540 (2804:431:c7f3:af8f:d72b:a010:a924:a70c) by CP5P284CA0019.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:94::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.12 via Frontend Transport; Tue, 12 Jan 2021 15:53:33 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: f324f352-0a3c-41a4-7970-08d8b71237e1 X-MS-TrafficTypeDiagnostic: BN7NAM10HT220: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c0RShON8ZxcjAdunDrJ//K16TWzRQWE5mq5KJlqU07tZqVGl3JxiYSppgOobbev3QUQVruSjnsCFCRxqJ4H4oiCqS/0SCXKCqXykmjUyrLzqehyJLOsh7yM+eFtSUeha0lBRMibMTk1weVQ117tDJ5LozpLE1NiFVENjKbJmLQePH2wGSAa/wUHzzVUYm7Vc0MIsKin7ExDHVB1BAqWc3sA3v5e9NJYngQ7sJFgRS35aO68UF8QP5jcD3Q6UoY1X X-MS-Exchange-AntiSpam-MessageData: RgEDS0/JtrFog6QtDEAkzjhav9dUQzABpWWG+G9AwixPmX1Us4RNP7DkL3opXvP29FkxA7B5K55f4P6tgzKQm2xzX6HN0YA87P8OKeUfJopmIOIw4b/ioIKT6wZdup8ThBpAVA6WeeykCKTmOK9TaLDiOXaLzVQEc08Lx/nHaFmy74hhtb77D8/k+E7Kn0iz2Ti401beoQI1/18nzbaL6w== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2021 15:53:34.7063 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: f324f352-0a3c-41a4-7970-08d8b71237e1 X-MS-Exchange-CrossTenant-AuthSource: BN7NAM10FT056.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7NAM10HT220 Received-SPF: pass client-ip=40.92.40.94; envelope-from=gabriel376@hotmail.com; helo=NAM10-BN7-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197802 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Gabriel do Nascimento Ribeiro >> Date: Tue, 12 Jan 2021 00:26:25 -0300 >> >> The regexp to extract diary entries on remember.el is hardcoded. >> Here is a patch to add a new option to configure a custom regexp. > > Thanks, but can you please describe the situation where this regexp > will need to be modified? There are multiple cases, for example, if the user wants to automatically extract diary entries of lines that starts with a date pattern (e.g.: dd/mm/yyyy). This new option does not target a specific user case but rather opens a range of possibilities by not relying on a hardcoded (and not documented) behavior. By the way, here is a patch with updated docstring. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-option-remember-diary-regexp.patch >From eaff2fb472a0f5911ee11287156d46ed7acbdbb0 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Tue, 12 Jan 2021 12:52:07 -0300 Subject: [PATCH] Add option remember-diary-regexp --- lisp/textmodes/remember.el | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lisp/textmodes/remember.el b/lisp/textmodes/remember.el index 98d3a3856e..5558bd7ec5 100644 --- a/lisp/textmodes/remember.el +++ b/lisp/textmodes/remember.el @@ -159,7 +159,8 @@ ;; ;; This should be before other entries that may return t ;; (add-to-list 'remember-handler-functions 'remember-diary-extract-entries) ;; -;; This module recognizes entries of the form +;; This module recognizes entries of the form (defined by +;; remember-diary-regexp) ;; ;; DIARY: .... ;; @@ -532,13 +533,18 @@ remember-diary-convert-entry (autoload 'diary-make-entry "diary-lib") +(defcustom remember-diary-regexp "^DIARY:\\s-*\\(.+\\)" + "Regexp to extract diary entries." + :type 'regexp + :version "28.1") + ;;;###autoload (defun remember-diary-extract-entries () - "Extract diary entries from the region." + "Extract diary entries from the region based on `remember-diary-regexp'." (save-excursion (goto-char (point-min)) (let (list) - (while (re-search-forward "^DIARY:\\s-*\\(.+\\)" nil t) + (while (re-search-forward remember-diary-regexp nil t) (push (remember-diary-convert-entry (match-string 1)) list)) (when list (diary-make-entry (mapconcat 'identity list "\n") -- 2.27.0 --=-=-=--