From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel do Nascimento Ribeiro Newsgroups: gmane.emacs.bugs Subject: bug#45946: [PATCH] Re: bug#45946: 28.0.50; hl-line-sticky-flag not working Date: Wed, 20 Jan 2021 22:07:33 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21908"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 45946@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 21 02:24:42 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2OiH-0005aN-M1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 02:24:41 +0100 Original-Received: from localhost ([::1]:43406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2OiG-0000UI-JS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Jan 2021 20:24:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2Ogg-0008F6-Mn for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 20:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44967) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2Ogg-0004Yd-F8 for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 20:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l2Ogg-00089T-5M for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 20:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel do Nascimento Ribeiro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jan 2021 01:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45946 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161119217031305 (code B ref -1); Thu, 21 Jan 2021 01:23:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Jan 2021 01:22:50 +0000 Original-Received: from localhost ([127.0.0.1]:56513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2OgU-00088r-7C for submit@debbugs.gnu.org; Wed, 20 Jan 2021 20:22:50 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:35488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2OgR-00088i-SK for submit@debbugs.gnu.org; Wed, 20 Jan 2021 20:22:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2OgR-0007zc-Mp for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 20:22:47 -0500 Original-Received: from mail-dm6nam12olkn2020.outbound.protection.outlook.com ([40.92.22.20]:3008 helo=NAM12-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2OgO-0004Ta-6H for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 20:22:47 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XUUXABbJh0S3oCX9MQGOvVrF1Mg87iun17CbAUHDuda4HoyKiXLrmxgsaX+2rQT9eWV+Uh6BtGwEhGUrkZzfoZ6sDLLz/zIEkW32WdpB+u0Bc7g64+6kWe9It2xnshWupM680cescXI3E5JomCt+Snl2zSpZ+wS08aAYA8I7W8G69PoCYXc/mzQlF6OeOdyl2w+MLr9dOmkPoTZHEIT8lAW5sV1J54/hfyzcWs+9AgS19rTqAztRvXHS7+pvJt9BQgImSPrkIOQNwGdkaq/d4Naf6W5tH+kSUvuquF/TvAAxE/oaXSrdrHeveVcdDClg7uo6Nvh3mtkmpX7y4SFevw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNr8pt9LZWfsGTr/Ve1WvRiP4k3tzKcIqXcPrjMdeZA=; b=Lq5Ld5lByLjR63e7YrrXwCv6akfjX+f+z4+bF+I+HWL5zxN+/jj+K1w5qITc4jUP9QYo1ot4hi7OD9e+pcOoFvpIL4B0+8sqidWDciatTtV2quobL+2Q32sBQScsVRMio8WpfVPJzatBzF+BI1xzeivtkTwjPjrYytuIO4EmbDpUI40TBKKPq6592v2HQxJ04MnKMf2D2Af9L5yk0FB0zzPd0WoRBuCwqAQTfNWUzveqjO7CVf3+CY29v0fEn/avpRbkTSicDMJY0wj8Uy9UH/MzQ4nz8TKCAJ1pzi3n+xCkapOPxUENBMWw4qmll4Tp5WHz57Sq2kC8MpoUZ8LG3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNr8pt9LZWfsGTr/Ve1WvRiP4k3tzKcIqXcPrjMdeZA=; b=S8FvihsJkOWyCnpBVUKB8ViAG4RvA6B8ynustAYDFKiryTiY/f8UEBlerSgaYH4GVLXB9KzKLU2oHfovu7jpbtfLJfynNGWKYd8uO6sHQrzRuaGAVsxTB+10I2/Ug0FTf5LCUGmpZIZu5mSv4Ex1uC9z1SbS7vsHzWDlXeyknT10Hu0tPhrQRirwrKJZRynBoQEmd1S8+LZ5JXw8/1YJ7QAsMOKPdvELVAydeOBYFXoBflMd42OIGS7Fx+IjR6mbm+JrW8KYxCumemiaDBN7YRTvYrtj7uRo1G4zHGDcM+k3XvvLLna4iCPcUBmVqTUGyKUsUTCWq6wL/iR+yvGg2g== Original-Received: from BN8NAM12FT019.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::4b) by BN8NAM12HT033.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.6; Thu, 21 Jan 2021 01:07:38 +0000 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com (2a01:111:e400:fc66::43) by BN8NAM12FT019.mail.protection.outlook.com (2a01:111:e400:fc66::416) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.6 via Frontend Transport; Thu, 21 Jan 2021 01:07:38 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:0B850855CE51066E26ACCB1F9D6AD96627E08AB77973D092F3DA5F18DA4C3EA1; UpperCasedChecksum:0FB919E12B26306BBD1E1344C1D2FF95A8BCA14EA6834300183CB507500C70A4; SizeAsReceived:7601; Count:45 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::d51d:8cbe:370a:39ac]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::d51d:8cbe:370a:39ac%7]) with mapi id 15.20.3763.014; Thu, 21 Jan 2021 01:07:38 +0000 In-Reply-To: (Gabriel do Nascimento Ribeiro's message of "Mon, 18 Jan 2021 01:13:38 -0300") X-TMN: [soK2N1tobqCBSu8xlleoibPL//VxHQQyhEiz0sCeHjbLb3AujP8DZ2pFtgtNQ+ka] X-ClientProxiedBy: CP2PR80CA0187.lamprd80.prod.outlook.com (2603:10d6:102:15::29) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <87y2gnksh6.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from precision5540 (2804:431:c7f3:76d5:a497:b83e:37c5:74e) by CP2PR80CA0187.lamprd80.prod.outlook.com (2603:10d6:102:15::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12 via Frontend Transport; Thu, 21 Jan 2021 01:07:36 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 65ae01eb-9666-410a-7911-08d8bda8f160 X-MS-TrafficTypeDiagnostic: BN8NAM12HT033: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 13jzOvxAm+n5MgnHAi4b6Q3fO+61OzjR9BBbS8zvyNM9/+RTFRL9MNeFmJ5q8cUk5Xxb5MtLQj3l/9hsRkHNosdiu0LK5YKBghVXOkfA2AS+YI6gjC7Ek3bTfyRQx43hz1/zE4KZDmK43TcO2ZUB6Va/3FNwfqP3FzXQ2uY+c0UORwEy7/Lv0aP/mnpTrY6To27DdN2GfYJj62chFSSDFdIYIyTRIUTkNFQKJs6PftMRTZTtG1lQ5RH+9maR1krt X-MS-Exchange-AntiSpam-MessageData: 8vwvaY0dPafuUw4uH7e0OJGGv81jg2LsXZ4SgZpJ2NjXwyXYb4oXEiTfxow7qyZcN/wRMmqXUqTMJ1rMOOOj/qBcEUwUSF7Hr+C3VZYpGPhEhPP0x3cx9Dj8bGEvVXRX2GKDq3xT9srAeqGNBWHpRsIdHhZgqDSrquu8VwjKghdeQ7g8f79CTwZBEQG3mJ8E5KqRUx+TM3y2kv68en58BQ== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65ae01eb-9666-410a-7911-08d8bda8f160 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2021 01:07:38.1837 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN8NAM12FT019.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM12HT033 Received-SPF: pass client-ip=40.92.22.20; envelope-from=gabriel376@hotmail.com; helo=NAM12-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198305 Archived-At: --=-=-= Content-Type: text/plain Here is a proposal of patch for this bug. It seems to work well in all cases I have tested, but maybe I am missing some edge case. Suggestions are welcome. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Always-set-overlay-current-buffer-on-hl-line-maybe-u.patch >From f4586cd7f535a9613216f61888a5ab8ee05352ca Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Wed, 20 Jan 2021 22:02:31 -0300 Subject: [PATCH] Always set overlay current-buffer on hl-line-maybe-unhighlight --- lisp/hl-line.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lisp/hl-line.el b/lisp/hl-line.el index 73870f9579..b19b9543f5 100644 --- a/lisp/hl-line.el +++ b/lisp/hl-line.el @@ -193,8 +193,7 @@ hl-line-maybe-unhighlight (with-current-buffer hlob (when (overlayp hl-line-overlay) (delete-overlay hl-line-overlay)))) - (when (and (overlayp hl-line-overlay) - (eq (overlay-buffer hl-line-overlay) curbuf)) + (when (overlayp hl-line-overlay) (setq hl-line-overlay-buffer curbuf)))) ;;;###autoload -- 2.27.0 --=-=-=--