From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Newsgroups: gmane.emacs.bugs Subject: bug#47252: 28.0.50; [PATCH] Make minibuffer-depth-indicator-function a defcustom Date: Fri, 19 Mar 2021 00:36:47 -0300 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16378"; mail-complaints-to="usenet@ciao.gmane.io" To: 47252@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 19 04:38:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lN5xi-0004AF-OT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Mar 2021 04:38:10 +0100 Original-Received: from localhost ([::1]:41582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lN5xh-00017D-PQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 23:38:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lN5xa-00015L-Eg for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 23:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lN5xa-0007Ba-6o for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 23:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lN5xa-0006pZ-2w for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 23:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Mar 2021 03:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47252 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161612502126162 (code B ref -1); Fri, 19 Mar 2021 03:38:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Mar 2021 03:37:01 +0000 Original-Received: from localhost ([127.0.0.1]:48410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lN5wb-0006nn-7V for submit@debbugs.gnu.org; Thu, 18 Mar 2021 23:37:01 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:41714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lN5wZ-0006nf-3t for submit@debbugs.gnu.org; Thu, 18 Mar 2021 23:36:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lN5wY-0000T7-T7 for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 23:36:58 -0400 Original-Received: from mail-dm6nam10olkn2058.outbound.protection.outlook.com ([40.92.41.58]:41673 helo=NAM10-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lN5wV-0006Z6-EY for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 23:36:58 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MWLV8pthRwEBSQ20ZcQhmx1eVZR6MnC6UofrHhhy3Eh73PekrJqppR8C/zx+P+zoFH1OhXedmjYKAWx7UcrIu9dx+uEtr+iF+lh9Z4OKO6vAwElW8caIrGHXU0mp4bsZTlOf6Ny19hObBW5tIYbuoFwu7h/9K/mwJy9O628QYdWA9oYGlpvaqWHJWkcdW5d6DfxmX4Ic1aHmN1zA6Ax7RNvVXArrFxxPf+eF+Y9c5UdO4diogVXZeMjWeGCG5jgIg6vTk1YDbXNMN1KYS5C+6DpUA+UwwZ4S6EVu+ZDC2rl+EDPO3Wg1LNWCa6ewTiz1SxH9ayjLtd5+gUbc9G/4iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t49mDF9HTJLcud0JltSZaTdmWu2MTQJMOnu8RvW/crY=; b=QNbztM1Ynfp5ox5AY9Dnsnz9JoPcoMUhfI1Kq/uVvNyLan+KRYyJ14/34t4wzmwTU7mjb63Yr+pZxIm/c1fW7wpjDenwS9q4xLXFjfSfLzLoEsXfLS6uSjG76WIdEorM3gSr44tFLea6UfEuD1zS1my21cs8mxtyhfpdUf5xr4B1wdoGc/OAw6UhQDF7BEb3xd8jasoi6FsvHg1fgAgWHrNjucp3+GYS/UfGV4NxcaFeWcW3R9xT8vcJ/WRybdPx1IS9XQwg54dEJ5jC3zpSidGn3oo4yhkoIp1gzfMn/GzeLX3fARchbVRFAHRVvvQAYNv7YtsbOxGYxMjnahIlMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t49mDF9HTJLcud0JltSZaTdmWu2MTQJMOnu8RvW/crY=; b=LveueukX1KEZrqQ7lo/xPlJSjb3wRi+sSVC/jlEab8A5TjncfklSQNM6NqGWuaonEhH4EYEC3+jg/Eso5mEd4K+enZqGgpNx1wgwIW8De2hr65YLUPVaVBBDXZ9y6bNuO4bA+IixNOMVL17ehKMBCRLIXnMPx12d4qgLmx/whXYYmxd8sqNgVT9ZytS9jg2EkhjbXbhfiAIBwq9AiK3jHhFj71pS4YRzdxgrpgAtpXqBfrSC2lty9NEu61Xem2GwVqWUdn7pnsuL/i/nGMhRzhK5WAE8zubWA9bDcKfg87izq0/gVz9eoPbW42PMSKYW8NgxzJlXvdPC1Lu0/2eIFA== Original-Received: from MW2NAM10FT023.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::52) by MW2NAM10HT077.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::289) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Fri, 19 Mar 2021 03:36:53 +0000 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com (2a01:111:e400:7e87::51) by MW2NAM10FT023.mail.protection.outlook.com (2a01:111:e400:7e87::154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Fri, 19 Mar 2021 03:36:53 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:9CB320FB87A87E8A0CBFFA1405CA351426BAB6C63B9E0B84F794B6B6842C129F; UpperCasedChecksum:8408DD79F11EA8D0B136715627087A9F88A0D44190333AB101CDB565A3EE68F5; SizeAsReceived:7262; Count:42 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::592f:9a58:d8cd:d9c9]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::592f:9a58:d8cd:d9c9%7]) with mapi id 15.20.3955.018; Fri, 19 Mar 2021 03:36:52 +0000 X-TMN: [mGDh8B4YGMg289gSGeR+ySy1TfESi3YmA4jF4kjz2MlMRYXTz3eBxt3SAgVpBWcp] X-ClientProxiedBy: CP2PR80CA0172.lamprd80.prod.outlook.com (2603:10d6:102:15::14) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <87czvvzueo.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from precision5540 (2804:431:c7f3:ee67:4255:c445:20aa:bb0f) by CP2PR80CA0172.lamprd80.prod.outlook.com (2603:10d6:102:15::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Fri, 19 Mar 2021 03:36:51 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 42 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: a048d688-dce3-467f-5468-08d8ea883bec X-MS-TrafficTypeDiagnostic: MW2NAM10HT077: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XHN/dmHRSmEh4M3BfYGMsJ0+NSrUbqTpuhGMovABLLe8mf9/P82xFd0KirHYjTOMNWWNY8jxm7rKeTvaMyT7szrUgStZpUQ375AJLACAp73xEdxGdZGkD6/dyoiGTJUy5wwjT+fYlFCUrgvFEcaDd1bAvwHQnnleRHmOWpFAXFB/f9x6nl3ZShfH35RSx1aaEHNUIGQNdhB5X+lxaQrkvsuOfjijYJ6vmyxxAlB1YuNB7SlSe9i/mpLtmvAWpU3g0DdJ7CONOwC/0QQxX1u68Mchr7YT74nJOlk0TH+wSvqjk70Nl3F5ILkpNOls7V4X2H0DSlYKNgyS6GF2TA8K8NV/ptKtUrvTgZxhJX0rF008X/Hm1TnKx2QkMvcxvRew4JlMOgYeMEKRh8yYpyFhZs/XU4En9pIT1SECb/3KIQjbguQRIiRb9pX4JE61mN8j X-MS-Exchange-AntiSpam-MessageData: Brq1MNzQqWXHGFKWoidG20weg6TEXtKNRnoriFtH+ZMMErMyLx0L3P9lr6nyP9TUMi1R9k/mOMNr0lCkRVj4NWP7GSsvEGcKZKXEzieSMUAkOCToTyEKcEcVlfZD39HDwqoK1hdcCumxPBwJeE8rGv90Lg79lLnofBD72fS+t0bCOHMcjEysAnbkXL/GldTPhKPh3DmXzgWj9/pHmh2ubA== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: a048d688-dce3-467f-5468-08d8ea883bec X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 03:36:52.5154 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM10FT023.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM10HT077 Received-SPF: pass client-ip=40.92.41.58; envelope-from=gabriel376@hotmail.com; helo=NAM10-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202656 Archived-At: --=-=-= Content-Type: text/plain This simple patch makes 'minibuffer-depth-indicator-function' a defcustom. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-mb-depth.el-Make-minibuffer-depth-indicator-fun.patch >From 6edb731766fa7fb34b62b3b1f9906d8c2119cb1c Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Fri, 19 Mar 2021 00:09:43 -0300 Subject: [PATCH] * lisp/mb-depth.el: Make minibuffer-depth-indicator-function a defcustom (minibuffer-depth-indicator-function): Make a defcustom. --- lisp/mb-depth.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/mb-depth.el b/lisp/mb-depth.el index f9a24e34bf..71b4abb5cb 100644 --- a/lisp/mb-depth.el +++ b/lisp/mb-depth.el @@ -30,10 +30,12 @@ ;;; Code: -(defvar minibuffer-depth-indicator-function nil +(defcustom minibuffer-depth-indicator-function nil "If non-nil, function to set up the minibuffer depth indicator. It is called with one argument, the minibuffer depth, -and must return a string.") +and must return a string." + :type 'function + :group 'minibuffer) (defface minibuffer-depth-indicator '((t :inherit highlight)) "Face to use for minibuffer depth indicator." -- 2.27.0 --=-=-= Content-Type: text/plain There was a long discussion 14 years ago when mb-depth.el was implemented about making it a defcustom or not: [1] https://lists.gnu.org/archive/html/emacs-devel/2008-08/msg00025.html [2] https://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00304.html These are the only references I could find about this topic. Perhaps today the rationale for this decision is different and this patch can be applied. If the decision is to keep it as a defvar, please close this bug report. Regards, Gabriel --=-=-=--