From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Newsgroups: gmane.emacs.bugs Subject: bug#46878: 27.1; lisp-outline-level returns imprecise level number Date: Sat, 20 Mar 2021 23:23:21 -0300 Message-ID: References: <871rcxuz4h.fsf@mail.linkov.net> <54FD8677-43E1-4806-9F8D-86850CBC3B29@gmail.com> <87mtvkcfr1.fsf@mail.linkov.net> <44DA0D54-D744-41A3-A7A1-D6A45B9536A4@gmail.com> <874khmkgcl.fsf@mail.linkov.net> <6A310565-0A96-416B-B476-EE5D26D72615@gmail.com> <87zgzdd7td.fsf@mail.linkov.net> <87tuplv8he.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31256"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 46878@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 21 03:39:37 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNo06-0007vn-NH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 03:39:34 +0100 Original-Received: from localhost ([::1]:39312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNo05-0005ck-8u for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Mar 2021 22:39:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNnzZ-0005cb-VM for bug-gnu-emacs@gnu.org; Sat, 20 Mar 2021 22:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNnzZ-0006iy-O4 for bug-gnu-emacs@gnu.org; Sat, 20 Mar 2021 22:39:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNnzZ-0005y4-L2 for bug-gnu-emacs@gnu.org; Sat, 20 Mar 2021 22:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Mar 2021 02:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46878 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161629431922912 (code B ref -1); Sun, 21 Mar 2021 02:39:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Mar 2021 02:38:39 +0000 Original-Received: from localhost ([127.0.0.1]:53393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNnzC-0005xU-So for submit@debbugs.gnu.org; Sat, 20 Mar 2021 22:38:39 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:40922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNnzA-0005xL-33 for submit@debbugs.gnu.org; Sat, 20 Mar 2021 22:38:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNnz9-0005ao-FO for bug-gnu-emacs@gnu.org; Sat, 20 Mar 2021 22:38:35 -0400 Original-Received: from mail-mw2nam10olkn2012.outbound.protection.outlook.com ([40.92.42.12]:18784 helo=NAM10-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNnz7-0006Tw-FY for bug-gnu-emacs@gnu.org; Sat, 20 Mar 2021 22:38:35 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D39KgGR0PlFqXzobrDID+O9lj0GiDsymqhvyOBaIB7VGYHucnK2AsI14nlFsQTtF2U53l88tpwZJyt2F8sVMRw0wndqiCWXYOhTRDw8Y96x0laPHTps33ERQkFmOdl2h15hPaBbTjv5M3LA0oGw2eCMv5sSPXKGrtvnZ402JjFsmMF+aH/0EafgyzShB1lDeWZXNyRGccHCBHci4aLVG/w9r+LVtXBlvib9U86Mw23Gss3TNKqrV8EG4wgEWqk3G5mbog5uLSJMTw5rpn3CgP9Yh972/v89DN6/GARv5TteiVZv6MnbpW0aQRnoupVK+eb034gw9p+RRhNM+kwenKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bw69iUoBmyGZL8afqMwxJj6gicfwNr6tyUg3b5T2jcY=; b=CmJmaKMz8zamLPwwTrR6JRSCFWUR1VX193zJMRlOmuE6hbsaFamM8Gqq5dtHYKMlWwoxW0cTot6TknWMp/dlshLC8XmeUO5lAUcps9sAaG5AgJFVXJlgkAaKn0ORODzVV5+A8iIxvoUXPLz5qIoDTitcCN7l0eGVVsVdWrqbtAwcUdhNv2Jvo9/a2YoJMjcXwszYelxCfO390Xcy8kGHCIifHlG/3STZsT+UwvHwmTEBu79GUSdSXHnj3ieaJ88aHtZakOijXyG2kwSnfcU082n+XkLvEYoa00vnf3kI0WyZzwgBivIZTtDh9BX7d0X/2MXL58GFAHygxuqtcSot1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bw69iUoBmyGZL8afqMwxJj6gicfwNr6tyUg3b5T2jcY=; b=grxy48BebztLZgfEVx7wtCFVGGX+tVukuDMWZo0kqFsKfMDYmjYnoBYQT9f2sHiqqhwz3XgWkh5QjoJSVpB8Mjs5BlpwYJuBPwBuisyiw134fFizysGsm/Z3ZNt+55r9Yi/PXuKHOp+H1zxTB0hqm4nHkGrWDqUJki7yq+CAZi4CPeycq6jB83KxkCo+fVKzKFHkaE7mzAADpLiTmp7ThoKXb8gHilEg44mMb1DEtX6Bno7ldRlCk30e+JoIshqbV8XURQnWWn0FA0gb2U/ankk5VEs35GAPwe9lBMBt8M83osc5OnJ8Q51Cmiku+gW3VqbYjKeo4+63Zl9qFg66jw== Original-Received: from BN7NAM10FT009.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::46) by BN7NAM10HT028.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::346) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Sun, 21 Mar 2021 02:23:29 +0000 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com (2a01:111:e400:7e8f::45) by BN7NAM10FT009.mail.protection.outlook.com (2a01:111:e400:7e8f::248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Sun, 21 Mar 2021 02:23:29 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:F04FF0CE5B7A5BC60A7FD3EF59D0A152524DEA2FC80A59FEBB5891291405909C; UpperCasedChecksum:42D7C0A9CF7B80DA52A4F92D71EF9B8E16168BFF528200DF0FFA83C68E3A0ADB; SizeAsReceived:7812; Count:45 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::592f:9a58:d8cd:d9c9]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::592f:9a58:d8cd:d9c9%7]) with mapi id 15.20.3955.025; Sun, 21 Mar 2021 02:23:29 +0000 In-Reply-To: <87tuplv8he.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 08 Mar 2021 19:52:13 +0200") X-TMN: [lf1N9z5PaubPEQEGMKNK0UEeZryiiwPT3WxJ/dTeWaq7RU5UO//+HwVaYgumRdn5] X-ClientProxiedBy: CP2PR80CA0032.lamprd80.prod.outlook.com (2603:10d6:102::18) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <87pmzt4546.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from precision5540 (2804:431:c7f3:ee67:f1fd:1434:d853:5bc8) by CP2PR80CA0032.lamprd80.prod.outlook.com (2603:10d6:102::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Sun, 21 Mar 2021 02:23:26 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 4757d326-3bb9-4d0a-57e4-08d8ec104fc2 X-MS-TrafficTypeDiagnostic: BN7NAM10HT028: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CSyCULzF7fSCJoCIKN46hhjBgpVwB8SZ6AuGH+MTVmh6k/qGIIkv9Oel4HbDj+SHE1cq+MIA6CYi9yJLiQnDZqDiu4kVyePJ22haehss6jUNpVBueXeGQGnDip+kJiVG9Ua4hcCq5IJqyuRpdl2jZ80HjJqRig9SCnbafvEOo+VAQu5TL++R9E8uEEm8MqEzKgF5kCz5XjO416oVkpipJVVku58+MGOfgrGn+8tAPPfDO9aziQpSJhVrK7SUppUwYoJyUcjrE1SaxWPoc4C/Mps8G5PuOW3hIBK9DnjUxwfXuM2WqZ2i+7cAqcCgiRH1hgV8kyHBHdVOTSwkG8+zsPgSWtTCIVnrgyuT9HZocMbiI78g9a/vyIA6Q0s1vBK7NO/P+j9EKv0vNYaMHE6JGA== X-MS-Exchange-AntiSpam-MessageData: Fyiz1Lv+YmQ5ZwjAq3NWAu/KrzsGGqRJT+sYdoWfv8UJyHgYHFybuaNY8rGD/6508Xd5ehBBWUyMHaN4HDQpfM5X4l0bWQmzjIq1qFkqMFp2YpMPL66RKrcFJZhf5VnKTj284jCE0Hr+1bgyge4Bm71Q9/Lroush9QcwiN8hchH1XT2qgSoXTqxgEjvE4GD18/FcLcvZY7z0mpekKmA8Qg== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4757d326-3bb9-4d0a-57e4-08d8ec104fc2 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2021 02:23:29.2633 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN7NAM10FT009.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7NAM10HT028 Received-SPF: pass client-ip=40.92.42.12; envelope-from=gabriel376@hotmail.com; helo=NAM10-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202754 Archived-At: Juri Linkov writes: >>> M-x outline-cycle-buffer RET >>> >>> It consistently alternates between only two states: >>> >>> Show all >>> All headings >>> >>> But after evaluating your version of lisp-outline-level, >>> it alternates between three states: >>> >>> Show all >>> Top level headings >>> All headings >> >> That is strange. Is outline-regexp changing? (I'm not on Emacs 28 so I can't check.) > > I don't think that outline-regexp is changing. But I can't check > in Emacs 27 because outline-cycle-buffer is only in Emacs 28. So I checked this "apparent strange behavior" on master branch and it seems to be working as expected. The commit 5a823a2a0c3eca60dd3939fba67df1bbe5a1b715 (Lars on 24 Nov 2020) added a new condition ('has-top-level') to 'outline-cycle-buffer' to check, well, if there is a top level heading, which is used to decide to hide or not sublevels, in case they exist. For emacs-lisp-mode, it fails to identify a top-level because 'outline-level' for a line starting with ";;; " returns a number greater than 1, which the code thinks its a child level: (when (= (funcall outline-level) 1) (setq has-top-level t)) Even though the outline level is used to compare relatively the headings to decide which ones are parents and which ones are children (level 5 is parent of level 6 and subsequent levels), there are cases (like the one above) where it's expected to have an ordered levelling starting from 1. It's more intuitive, and otherwise it's impossible to know what is a top-level or to set faces according to is level (level 1 with face outline-1 and so on). A simpler approach to avoid rewriting the existing functions and regexps would be to create a new variable called 'outline-level-offset', which could be used inside 'outline-level' to subtract from the original value. For example, if today the outline level for ";;; " in emacs-lisp returns 3, the elisp-mode.el (or lisp.mode.el) could set 'outline-level-offset' to 2, so 3 - 2 = 1, the expected value. Regards, Gabriel