unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Adrian Robert <adrian.b.robert@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Paul Griepentrog <pgriepen@gmail.com>, 6616@debbugs.gnu.org
Subject: bug#6616: S-TAB is mismapped in the *Help* buffer
Date: Mon, 12 Jul 2010 22:03:11 +0300	[thread overview]
Message-ID: <CFD3F3F6-4768-4CA0-99C4-57DB9B77843A@gmail.com> (raw)
In-Reply-To: <83pqyssj5a.fsf@gnu.org>


On Jul 12, 2010, at 8:29 PM, Eli Zaretskii wrote:

> This is Mac-specific, and it is due to this line from term/ns-win.el:
> 
>    (define-key map [S-tab] [25])
> 
> I have no idea why this line is there, perhaps Mac users expect this
> binding.  I also don't see how this line plays with the following line
> from the same ns-win.el, a few lines up:
> 
>    (put 'S-tab 'ascii-character (logior 16 ?\t))
> 
> These two lines have been there for almost 2 years.
> 
>> My guess is that the right place to change this is in the
>> `button-buffer-map'.
> 
> No, the right way seems to be to find out why ns-win.el defines this
> strange mapping.  Adrian?


These lines were in the file when I started working with the port (more than 2 years ago ;), and although the definitions got moved around slightly, I never removed anything unless a problem was reported.  Now that we have this report, I propose removing BOTH of the S-tab lines.  I tried this locally and it did no harm, and let S-tab be interpreted (though some default mapping seems to translate it to plain tab).

The other stuff in ns-alternatives-map appears to be needed though, else the characters listed there don't get interpreted correctly.






  reply	other threads:[~2010-07-12 19:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-12  6:20 bug#6616: S-TAB is mismapped in the *Help* buffer Paul Griepentrog
2010-07-12 17:29 ` Eli Zaretskii
2010-07-12 19:03   ` Adrian Robert [this message]
2010-07-12 19:10     ` Eli Zaretskii
2010-07-13  5:42       ` Paul Griepentrog
2010-07-13  7:28         ` Adrian Robert
2010-07-13  9:50           ` Eli Zaretskii
2010-07-13  9:49         ` Eli Zaretskii
2010-08-01  0:04         ` Stefan Monnier
2010-08-01 14:24           ` Drew Adams
2010-08-01 18:59             ` Drew Adams
2010-08-01 23:32             ` Stefan Monnier
2010-08-02  1:51               ` Drew Adams
2010-08-01 17:38           ` Paul Griepentrog
2010-08-02  0:03             ` Stefan Monnier
2010-08-02  1:57               ` Drew Adams
2010-08-02  8:22                 ` Stefan Monnier
2010-08-02  4:30               ` Paul Griepentrog
2010-07-13 10:47 ` bug#6616: Closing, checked fix in to trunk r100808 Adrian Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CFD3F3F6-4768-4CA0-99C4-57DB9B77843A@gmail.com \
    --to=adrian.b.robert@gmail.com \
    --cc=6616@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=pgriepen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).