From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60961: 29.0.60; Compiling emacs-29 without treesitter outputs warnings Date: Fri, 20 Jan 2023 14:11:44 -0800 Message-ID: References: <878rhx1os6.fsf@gmail.com> <831qnpnx9g.fsf@gnu.org> <87o7qtuxgh.fsf@thornhill.no> <83tu0lmgv6.fsf@gnu.org> <87h6wll10q.fsf@thornhill.no> <83r0vpme0t.fsf@gnu.org> <8A47E6B6-BE4F-44F4-9BC5-55B6051CDCD4@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10586"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , rpluim@gmail.com, 60961@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 20 23:13:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIzdJ-0002Xn-Lw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Jan 2023 23:13:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIzdA-00057g-3n; Fri, 20 Jan 2023 17:13:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIzd8-00057C-HZ for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 17:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIzd8-0005o5-6W for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 17:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIzd7-00031Z-Ni for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 17:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jan 2023 22:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60961 X-GNU-PR-Package: emacs Original-Received: via spool by 60961-submit@debbugs.gnu.org id=B60961.167425272511535 (code B ref 60961); Fri, 20 Jan 2023 22:13:01 +0000 Original-Received: (at 60961) by debbugs.gnu.org; 20 Jan 2023 22:12:05 +0000 Original-Received: from localhost ([127.0.0.1]:47381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIzcC-0002zy-Jh for submit@debbugs.gnu.org; Fri, 20 Jan 2023 17:12:04 -0500 Original-Received: from mail-pg1-f176.google.com ([209.85.215.176]:37719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIzcB-0002zS-Lv for 60961@debbugs.gnu.org; Fri, 20 Jan 2023 17:12:04 -0500 Original-Received: by mail-pg1-f176.google.com with SMTP id v3so5191844pgh.4 for <60961@debbugs.gnu.org>; Fri, 20 Jan 2023 14:12:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jWuvlfoA80mVyHdLonLWXZCMmE7MXv9RyP6zffqD6JU=; b=BfUt1AO1TjaCwBHPnIxJeLXMcjkQyCUW5i20Uft/I7v11eHRoe0Lm6hl9L5K7y+1Kw 071rJ5kY1aRT56J3Iy5KqEYuNYg24eirTV1eDJ7j8aoOjtaXwNyrXyi14qmql+qyH9jl jMMK25WIGE6bGA5jXn+GAW824AcayUpsiP2XdGiHwmbngEFBvMq9hv5NWV44Rdkb41+A D2eFIjXodwVR1lG/Qb5l7srrMNrKyRuQPAqK4cGxBYhSsaBnCdW/B+kaOsLVehHh1+jH nYYamm3v90gsaT53FiLjRNTaSJl7iLMsUQjaDBMqTQkXitoq5Yq/E7zicW4iJBR/HnLW PUpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jWuvlfoA80mVyHdLonLWXZCMmE7MXv9RyP6zffqD6JU=; b=Fzq2j/TfJQxH//SIDGS3BEmOXfSsvzSHSOZ+dMBbNO+x1iT6AZjK+pK66Sz7F/k2Pg 3SQFxQgnOAeMIrCcvz3k4Hxu93vIdyjR2IFWn9XY6vRoR9OoGpU0J7Vaw8ronb09o1Nj yogd+mlE8UHUe3TDXUbjYcyu4cxKnCAAbRQn3uc/f8s30TF5XZqemp6QlTeGD7xA9o0Z jERfBpXpF/Dn1Pqv+ES5qfSSU9fOO/OXX5b6IjhjuzLPNuxxzbAMasoHEYUv1EZM+pQM 67Vmikb4XHEWsfC+p2E9Y5ssbIUFIaM3GiMtGaYT1UM0VdTAMHjymE69tVfcwoWr70Tg pvMw== X-Gm-Message-State: AFqh2kr6ffltunCFylUxP5SoEJmJ5WbqjQXu9MJDHoDTUJCwMSoqi2Qh rZrjltuplcmgOryL3Ub5FxY= X-Google-Smtp-Source: AMrXdXsagSHYCcF8EcCD1yp4ah5kQFXn7t+mYWUZu+CyVBy5qXBJusA2flCJqK9zPXVyFQRbw3n1Ag== X-Received: by 2002:a05:6a00:3691:b0:580:d409:396c with SMTP id dw17-20020a056a00369100b00580d409396cmr19355089pfb.6.1674252716681; Fri, 20 Jan 2023 14:11:56 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id w124-20020a626282000000b005769b23260fsm27192511pfb.18.2023.01.20.14.11.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jan 2023 14:11:56 -0800 (PST) In-Reply-To: <8A47E6B6-BE4F-44F4-9BC5-55B6051CDCD4@thornhill.no> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253809 Archived-At: > On Jan 20, 2023, at 8:07 AM, Theodor Thornhill = wrote: >=20 >=20 >=20 > On 20 January 2023 16:17:22 CET, Eli Zaretskii wrote: >>> From: Theodor Thornhill >>> Cc: rpluim@gmail.com, casouri@gmail.com, 60961@debbugs.gnu.org >>> Date: Fri, 20 Jan 2023 15:43:33 +0100 >>>=20 >>> Eli Zaretskii writes: >>>=20 >>>>> So I can either just make sure that no modes require across modes, = or >>>>> make that "lib" right now. What do you think? >>>>=20 >>>> I tend to the "lib" method. Mostly because several modes, = including >>>> some that are unrelated to C, want the code which was written for >>>> C/C++, and so it is possible that there's some general feature here >>>> waiting for us to refactor the code -- in which case perhaps the = code >>>> should be in treesit.el? >>>>=20 >>>> IOW, how come JS, Rust, and Typescript all want comment-related = setup >>>> that was written for C? Because they all have C-like syntax, so they have the same setup for = indenting and filling block comments, for example. >>>> If this is just a coincidence, then perhaps >>>> duplicating the code is a better idea, but if there's some = underlying >>>> commonality, we should have common code in treesit.el, or maybe in >>>> some c-ts-common.el? c-ts-common.el sounds good to me. >>>=20 >>> I can start by moving it into treesit.el, then we can maybe extract >>> something out later. Sounds good? I can do it tonight, unless any = of >>> you object :) >>=20 >> SGTM, but let's hear from Yuan before you start working on this. >>=20 >> Thanks. >=20 > Thumbs up I=E2=80=99d prefer c-ts-common.el over treesit.el, since they only apply = to C-like languages. There is no harm putting them in a separate file, = right? I wrote some commentary in c-ts-mode, which notes all the shared = functions and variables.=20 Yuan