From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#71774: 31.0.50; Hash table weakness broken? Date: Wed, 26 Jun 2024 11:39:17 +0200 Message-ID: References: <86ikxx9ib6.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32848"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71774@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier , martin rudalics To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 26 11:41:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMP9X-0008T1-KW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Jun 2024 11:41:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMP9B-0003mY-FX; Wed, 26 Jun 2024 05:41:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMP9A-0003lv-0b for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2024 05:41:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMP99-0003aF-OV for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2024 05:40:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMP9B-00088F-Km for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2024 05:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2024 09:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71774 X-GNU-PR-Package: emacs Original-Received: via spool by 71774-submit@debbugs.gnu.org id=B71774.171939483131213 (code B ref 71774); Wed, 26 Jun 2024 09:41:01 +0000 Original-Received: (at 71774) by debbugs.gnu.org; 26 Jun 2024 09:40:31 +0000 Original-Received: from localhost ([127.0.0.1]:38536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMP8g-00087M-MI for submit@debbugs.gnu.org; Wed, 26 Jun 2024 05:40:30 -0400 Original-Received: from mail-lj1-f174.google.com ([209.85.208.174]:59558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMP8e-00087A-TI for 71774@debbugs.gnu.org; Wed, 26 Jun 2024 05:40:29 -0400 Original-Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2ebe0a81dc8so85618541fa.2 for <71774@debbugs.gnu.org>; Wed, 26 Jun 2024 02:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719394760; x=1719999560; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=K4Iq7tuZ4KYdoMo+BSd7VF+z7to1GQX093RHCAhftsQ=; b=hNRexdctdlGaDUIZfDWsgsL4O+KtQElBTE8BN7TyS/97qM/VAsF2+fO+tuPhp2oVPY WnofItdcE43WP3k3U8tv6dArdFH/J+m0JxdoHn+vqHnc8xaGMGpInH5sNhWm/CICQJxb EBbFQ3jU54G7J9SD4a9ScfYeYu0XkHYHXX59Ak3dNUJauSWH/XAOZ/dH2N6v8C5xPzF9 aVuyMpOm/sYqAxSSsc9wxD3sDPRLY/vTdpq1T+hiVKRMsnBaFFg9vqhgWEpXQZZL3kP4 MEVN2RcHKnJadsMXZHvuTiEIiGIYs7X2UWUmJizmU0NGK2+pTvHZ/55mSdz1J7Xn5F8H jBTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719394760; x=1719999560; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=K4Iq7tuZ4KYdoMo+BSd7VF+z7to1GQX093RHCAhftsQ=; b=LOulQDoV1TonT5PLfxQzd7kfBLFNvkXW2bcUBia9d7dHCutk9yhwzCzPEzzi13nCHV GYdMnPRaxcxkaGI2w2lApTq+NSYSeHyJmVpb+AM2Ys6dzZBT3iIkyhg5h/j6Ze+A6NXe ArMwhv4Eqh+gGHY2WSfNf+582E+HxwW16NR2dFWDWgMP+VYUdXRvQMiSJq1fAYjZcHym Zrm2JosN90pigr25gDb8WS6K7Rf+pxCILdOXELJl3vHtFTYzLBmrdbdIxZPe86Y641lo d2GkM720wzAspksT/ThPfUnZOaffA5RcJ9wu3rPTN5tY0sKM9ZwgLzFe2PH40VuSJfp1 pfEg== X-Forwarded-Encrypted: i=1; AJvYcCXScw7ROSroohtPMWV0Jdh9U/7KnRC/vNhOmAEVgPsPqSgbeD8UUT60+LOsJF6zdCFbQj6IvXpjwd7Av75vLKMDskCnQJ0= X-Gm-Message-State: AOJu0YzLA8pKI2mnAEzklBGoDWhwUg/p7dco6kRQ3wrCaECaSmHIn9Di 0BExXCCz5mTbCTu3FmMu3IRLjCw3jtiBVJLkm4yB3iemsvqdJcS7 X-Google-Smtp-Source: AGHT+IFgUGxFOLCrOT3SrEEA9H6DqJgodYy2JXgYYAjtIzcWSJxLPD/mmEliBPukMVR7PINr1G/oGA== X-Received: by 2002:a05:6512:3e0a:b0:52c:e3c7:941e with SMTP id 2adb3069b0e04-52ce3c799f0mr9443928e87.47.1719394758940; Wed, 26 Jun 2024 02:39:18 -0700 (PDT) Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52cd63bc576sm1518116e87.63.2024.06.26.02.39.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jun 2024 02:39:18 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287926 Archived-At: > Is it possible the problem is fixed by running (setq values nil) = before (garbage-collect), or after it, or in between calls to = (garbage-collect)? I've not had time to test on current emacs -Q, but on = my running emacs session that appears to fix the problem. Thank you, Pip! It's probably `values` indeed. The effect can also be = circumvented by not returning the undead object to the REPL: (setq h (make-hash-table :weakness 'value)) -> #s(hash-table weakness value) (progn (puthash t (list 3) h) nil) -> nil h -> #s(hash-table weakness value data (t (3))) (garbage-collect) h #s(hash-table weakness value) > Of course I have no idea why it worked differently in older emacs = versions. It appears to be an effect of Stefan's change 84f72f19, possibly = unintended. Maybe we should take this opportunity to get rid of `values` altogether, = or at least in `eval-last-sexp`.