From: Yuan Fu <casouri@gmail.com>
To: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
Cc: jostein@kjonigsen.net, Theodor Thornhill <theo@thornhill.no>,
59909@debbugs.gnu.org
Subject: bug#59909: 29.0.60; csharp-ts-mode does not fontify escape sequences nor highlight syntax errors
Date: Fri, 9 Dec 2022 12:39:54 -0800 [thread overview]
Message-ID: <CC73AFF9-D242-4BE3-A93D-DD3302D3EA81@gmail.com> (raw)
In-Reply-To: <45eb0099-712f-5eb3-0f98-235038863bf7@secure.kjonigsen.net>
Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:
> Consider the following C# code:
>
> public class Test
> {
> public const string Foo = "test \t escape";
> fdsfd
> }
>
> When activating csharp-ts-mode, the escape sequence on line 3 is not fontified, and the syntax error on line 4 is not
> highlighted.
>
> json-ts-mode does this, which is cool and I think csharp-ts-mode should have it too.
>
> Attached is a patch which makes csharp-ts-mode support these fontification rules.
Applied, thanks! Also, it would be nice if you can write the commit
messages in the style described in the CONTRIBUTE file under project
root. You can have a look at the commit messages of your commits that I
applied for some example.
Yuan
prev parent reply other threads:[~2022-12-09 20:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 19:40 bug#59909: 29.0.60; csharp-ts-mode does not fontify escape sequences nor highlight syntax errors Jostein Kjønigsen
2022-12-09 20:39 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC73AFF9-D242-4BE3-A93D-DD3302D3EA81@gmail.com \
--to=casouri@gmail.com \
--cc=59909@debbugs.gnu.org \
--cc=jostein@kjonigsen.net \
--cc=jostein@secure.kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).