unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: 8682@debbugs.gnu.org
Subject: bug#8682: 24.0.50; doc strings of `isearch-mode', `isearch-forward', etc.
Date: Tue, 17 May 2011 07:25:05 -0700	[thread overview]
Message-ID: <CC502D3749BA4CA9B1D137888A2C40E8@us.oracle.com> (raw)


1. At a minimum, the doc string of `isearch-mode' should say something
like this:
 
FORWARD non-nil means forward search; nil means backward search.
REGEXP t means regexp search; nil means literal search.
OP-FUN means ???????
RECURSIVE-EDIT non-nil means recursive edit for a modal search.
WORD-P non-nil means word search; nil means ignore word boundaries.
 
And you can remove this sentence from the doc string - a function's doc
should, in general, not mention callers:
 
"It is called by the function `isearch-forward' and other related
functions."
 
(Also, some `isearch-mode' arguments should be renamed with `-P', to
indicate that they are boolean flags: FORWARD-P, REGEXP-P,
RECURSIVE-EDIT-P.)
 
OP-FUN: It corresponds to `isearch-op-fun', but there is no doc string
for `isearch-op-fun', and the accompanying source comment does not help
- it says only when `isearch-op-fun' is called, not what it is for or
how it is used.
 

2. Doc strings of `isearch-forward' etc. also need to describe their
args.  E.g. 
 
Non-interactively:
REGEXP-P means...
NO-RECURSIVE-EDIT means...
 
Again, NO-RECURSIVE-EDIT should be NO-RECURSIVE-EDIT-P, to indicate that
it is its truth value that is used (nil/non-nil).
 

3. More generally, isearch.el needs more and better doc strings.
 

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-05-16 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/build/include'
 






             reply	other threads:[~2011-05-17 14:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-17 14:25 Drew Adams [this message]
2011-05-17 14:39 ` bug#8682: 24.0.50; doc strings of `isearch-mode', `isearch-forward', etc Stefan Monnier
2011-05-17 14:46   ` Drew Adams
2011-05-17 17:32     ` Stefan Monnier
2011-05-17 19:12       ` Drew Adams
2011-07-15 13:40 ` Lars Magne Ingebrigtsen
2011-07-15 15:06   ` Drew Adams
2011-07-15 16:56     ` Juanma Barranquero
2011-07-15 18:30       ` Drew Adams
2011-07-15 14:43 ` Drew Adams
2011-07-15 15:02   ` Lars Magne Ingebrigtsen
2011-07-15 15:02   ` Lars Magne Ingebrigtsen
2011-07-18 14:06   ` Stefan Monnier
2011-07-18 14:13     ` Drew Adams
2013-05-20 22:50       ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CC502D3749BA4CA9B1D137888A2C40E8@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=8682@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).