unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: YASUOKA Masahiko <yasuoka@yasuoka.net>
Cc: 42059@debbugs.gnu.org
Subject: bug#42059: 26.3; OpenBSD now has posix_openpt(3)
Date: Tue, 30 Jun 2020 16:24:55 +0200	[thread overview]
Message-ID: <CC39B46A-2774-45A3-AFF6-195B3865DB36@acm.org> (raw)
In-Reply-To: <20200630.224929.476624940263769257.yasuoka@yasuoka.net>

30 juni 2020 kl. 15.49 skrev YASUOKA Masahiko <yasuoka@yasuoka.net>:

> Although old versions might become not able to build Emacs with the
> patch, I suggest Emacs should have the patch.
> 
> Firstly the versions are too old.  posix_openpt(3) had been introduced
> to OpenBSD at OpenBSD 5.3, it was 7 years ago and 14 versions before
> the latest.  It was 6 years ago when the last version which doesn't
> have posix_openpt(3) became out of support.
> 
> Secondly the old way the old versions is using has another problem. It
> caused an error when emacs opens some ptys.  To solve this problem, in
> any case, people need to use newer OpenBSD and newer Emacs.

Thank you for the detailed explanation, and I think applying your patch will be all right -- 7 years is a long time in the security-conscious OpenBSD world. It would probably need an update to the NEWS file, though.

Eli, do you have any objection to the patch by Yasuoka-san, assuming that it limits the OpenBSD support to version 5.3 or newer?
Presumably the patch would be for Emacs 28, unless there are strong security/reliability reasons for Emacs 27.






  reply	other threads:[~2020-06-30 14:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26  9:52 bug#42059: 26.3; OpenBSD now has posix_openpt(3) YASUOKA Masahiko
2020-06-27  3:56 ` YASUOKA Masahiko
2020-06-30 11:52 ` Mattias Engdegård
2020-06-30 13:49   ` YASUOKA Masahiko
2020-06-30 14:24     ` Mattias Engdegård [this message]
2020-06-30 15:36       ` Eli Zaretskii
2020-06-30 14:32     ` Eli Zaretskii
2020-07-01 11:23 ` Jeremie Courreges-Anglas
2020-07-01 14:24   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CC39B46A-2774-45A3-AFF6-195B3865DB36@acm.org \
    --to=mattiase@acm.org \
    --cc=42059@debbugs.gnu.org \
    --cc=yasuoka@yasuoka.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).