unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: 59118@debbugs.gnu.org, matt@rfc20.org
Subject: bug#59118: [PATCH] Prefix all itree functions with itree_
Date: Tue, 08 Nov 2022 08:53:21 +0200	[thread overview]
Message-ID: <CBE9197B-620A-4D9F-A9D6-004911AEBD69@gnu.org> (raw)
In-Reply-To: <87o7tim2tw.fsf@rfc20.org>

On November 8, 2022 7:29:15 AM GMT+02:00, Matt Armstrong <matt@rfc20.org> wrote:
> Tags: patch
> 
> X-Debbugs-CC: Eli Zaretskii <eliz@gnu.org>, Basil L. Contovounesios <contovob@tcd.ie>
> 
> Steph and I put some effort into prefixing all functions in itree.h with
> itree_.  It would be nice to be consistent with that.


Functions that initialize Emacs subsystems during startup are traditionally called init_FOO and syms_of_FOO.  So I'd rather we left init_itree alone.

As for forget_itree, I don't mind renaming it, although it's largely a wasted effort: that function is only present in the unexec build, and will die of natural causes at some not too distant point.





  reply	other threads:[~2022-11-08  6:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08  5:29 bug#59118: [PATCH] Prefix all itree functions with itree_ Matt Armstrong
2022-11-08  6:53 ` Eli Zaretskii [this message]
2022-11-08 16:03   ` Matt Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CBE9197B-620A-4D9F-A9D6-004911AEBD69@gnu.org \
    --to=eliz@gnu.org \
    --cc=59118@debbugs.gnu.org \
    --cc=matt@rfc20.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).