From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#59941: use-package-defaults type not updated for added keywords :pin, :ensure etc Date: Sat, 10 Dec 2022 11:41:42 +0100 Message-ID: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19280"; mail-complaints-to="usenet@ciao.gmane.io" Cc: John Wiegley , Stefan Kangas To: 59941@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 10 11:42:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3xJG-0004tL-17 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Dec 2022 11:42:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3xIy-0003V1-4B; Sat, 10 Dec 2022 05:42:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3xIw-0003UX-RM for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 05:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3xIw-0006Gt-Io for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 05:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3xIw-0005wP-33 for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 05:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 10:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59941 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Emacs Bug Report Original-Received: via spool by submit@debbugs.gnu.org id=B.167066891022826 (code B ref -1); Sat, 10 Dec 2022 10:42:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Dec 2022 10:41:50 +0000 Original-Received: from localhost ([127.0.0.1]:42018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3xIk-0005w6-7K for submit@debbugs.gnu.org; Sat, 10 Dec 2022 05:41:50 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:52414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3xIi-0005vy-9z for submit@debbugs.gnu.org; Sat, 10 Dec 2022 05:41:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3xIi-0003TA-27 for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 05:41:48 -0500 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3xIg-0005Cc-A0 for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 05:41:47 -0500 Original-Received: by mail-lf1-x12d.google.com with SMTP id g7so10882957lfv.5 for ; Sat, 10 Dec 2022 02:41:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=QaizYOy8pElK0uv3TvyJg7Ftr+KRW1D7AhB9QEU6Puk=; b=jVkL5kanx+6w/LHue2up9q2vp29+IYm1aejfHl74qL7SKc9BuiaLxiQtv7PbBoGxID cnckJZj+ZGSWm1OwJqJxAy/2qns38BOFe3NJWFqfL7xCsb/e6sHF53MImEdpCZNH6+UB BlzpfhLp5ZXMltBalXNLmpqow0ljS98RDTEEtwQGV6gZV+WaRT3mMABBMNlm9itZsqd4 dJVv4bQiYXBhNO/fUoQ0OOpTpSHpCPhj5VS4cUMkaEbMyuVHBMOh7G/1kM1W8Elo/NTi SAhRqXo1G2ZLzGJKEtj+26tYjA63taXqMTbEwdON++GWxoqiasXQ/xKqiqgwluKxim+4 bOCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QaizYOy8pElK0uv3TvyJg7Ftr+KRW1D7AhB9QEU6Puk=; b=VN7ROiqOdlpyoAmy7YKSoBDVjklFRwL3PVP1Rl94qvsHAg85KZpNxD6KuTLPN2YjeK +K9LISnBTLfOvwPgwEUJVVK1+VgXEsW/hw8hyT/cdfSd+mq6TLFJAAJ2vX7yI7EopZWh Ak7/mT4K5SctwFIkxT9lmleMbAAPI79nlcbKwTQmvtSKuqyJtmvH0nYmOVqS2hZZ0Cab 9FqC9nooJD8d2F0e2RZarUqUv6uImqV+eCIR48e0Lu/QqW1oCKQ0o4Uq+cRqQmfpVKoF YGwxqpVtiMiE+VfSI0udRHjHOFMDlKltFWLSzgWEs1T52xIf0ldLtLrYdTfaFU4cV/qT HChw== X-Gm-Message-State: ANoB5ply6ExzaIH560ciEv5YOELNwR4MFAOlELTSy8z+3HGRgObMsy/n 5S9sfwS8LxDXi874V9Bu/4dv39hBkm0= X-Google-Smtp-Source: AA0mqf5IFU5ZCafssx9DyTTLIRMS9ay7jz3PFSzL7+qxhCuyGE9NU5SE+n3WEF+hwfCwMJXzwbAlOg== X-Received: by 2002:a05:6512:b21:b0:4a4:68b9:19f9 with SMTP id w33-20020a0565120b2100b004a468b919f9mr3260195lfu.33.1670668904014; Sat, 10 Dec 2022 02:41:44 -0800 (PST) Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id a16-20020ac25e70000000b004b591c33b99sm679291lfr.13.2022.12.10.02.41.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Dec 2022 02:41:43 -0800 (PST) X-Mailer: Apple Mail (2.3654.120.0.1.13) Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250502 Archived-At: The type of `use-package-defaults` does not include the keywords :pin = and :ensure, since these are added to `use-package-keywords` after the = declaration of the former. As a consequence these keywords cannot occur in `use-package-defaults` = when using the interactive customisation interface, and since they are = present in the default value, the `test-custom-opts` test fails with a = type mismatch: variable: use-package-defaults value: ((:config '(t) t) (:init nil t) (:catch t (lambda (name args) = (not use-package-expand-minimally))) (:defer use-package-always-defer = (lambda (name args) (and use-package-always-defer (not (plist-member = args :defer)) (not (plist-member args :demand))))) (:demand = use-package-always-demand (lambda (name args) (and = use-package-always-demand (not (plist-member args :defer)) (not = (plist-member args :demand))))) (:ensure (list = use-package-always-ensure) (lambda (name args) (and = use-package-always-ensure (not (plist-member args :load-path))))) (:pin = use-package-always-pin use-package-always-pin)) type: (repeat (list (choice :tag "Keyword" (const :disabled) (const = :load-path) (const :requires) (const :defines) (const :functions) (const = :preface) (const :if) (const :when) (const :unless) (const :no-require) = (const :catch) (const :after) (const :custom) (const :custom-face) = (const :bind) (const :bind*) (const :bind-keymap) (const :bind-keymap*) = (const :interpreter) (const :mode) (const :magic) (const = :magic-fallback) (const :hook) (const :commands) (const :autoload) = (const :init) (const :defer) (const :demand) (const :load) (const = :config)) (choice :tag "Default value" sexp function) (choice :tag = "Enable if non-nil" sexp function))) There are various ways to fix this. Easiest is probably to cease = pretending that :pin and :ensure are somehow special and just include = them in `use-package-keywords` from the start instead of adding them = afterwards. Alternatives include making the defcustom type less specific and allow = any keyword, or modifying that type after adding keywords (a bit messy).