From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Carsten Dominik Newsgroups: gmane.emacs.orgmode,gmane.emacs.bugs Subject: Re: TODO progress regression in org-mode in Emacs pretest Date: Mon, 2 Feb 2009 22:04:37 +0100 Message-ID: References: <87fxiwlmgp.fsf@elehack.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1233608765 13605 80.91.229.12 (2 Feb 2009 21:06:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Feb 2009 21:06:05 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org To: Michael Ekstrand Original-X-From: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Mon Feb 02 22:07:18 2009 Return-path: Envelope-to: geo-emacs-orgmode@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LU606-0001mW-2G for geo-emacs-orgmode@m.gmane.org; Mon, 02 Feb 2009 22:06:38 +0100 Original-Received: from localhost ([127.0.0.1]:49674 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU5ym-0003c8-B9 for geo-emacs-orgmode@m.gmane.org; Mon, 02 Feb 2009 16:05:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LU5yO-0003aH-UN for emacs-orgmode@gnu.org; Mon, 02 Feb 2009 16:04:53 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LU5yH-0003ZQ-Cn for emacs-orgmode@gnu.org; Mon, 02 Feb 2009 16:04:52 -0500 Original-Received: from [199.232.76.173] (port=50634 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU5yH-0003ZM-6E; Mon, 02 Feb 2009 16:04:45 -0500 Original-Received: from mail-ew0-f20.google.com ([209.85.219.20]:61829) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LU5yF-0006rD-IW; Mon, 02 Feb 2009 16:04:44 -0500 Original-Received: by mail-ew0-f20.google.com with SMTP id 13so2251877ewy.18 for ; Mon, 02 Feb 2009 13:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=mo12+zpJ5N2UHquHfPyrLW7Dsm/d5rr6w5Tt1kF+L3U=; b=fjAAkBwwy5lBfuiqMrTryqeL03Z7AbCzZGv+xQXpP4F3wi8iHpUDfbKxiWhAFSvxjb P9j0WC8kdivzkQJbyuvjBcpWC2BbW0jS/6kMMfI49EcQkiNgFm/nCc4ExBMm7ecdoFf0 l0TNZXH16xVugQMi+YcUOUDcTC2w7soJ1mxls= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=cq9h9h5+m2W5xlAnn293A6013GOX4/g0SVyAGTvXE9QYn1d6PeBS0R9azedZlK0F69 3x36j9TeEnY/AsnYQS+xQI8NNaQX9EcyRkvZibAN3ezs5An0TuhpJ21GhWPnh8+f0JxR HHy+B6PK/9lCJU3oyc7TvhE/+WbSwwo3nJ6uY= Original-Received: by 10.210.92.8 with SMTP id p8mr66538ebb.6.1233608680423; Mon, 02 Feb 2009 13:04:40 -0800 (PST) Original-Received: from ?192.168.1.10? (dc5146846e.adsl.wanadoo.nl [81.70.132.110]) by mx.google.com with ESMTPS id 28sm3871726eyg.45.2009.02.02.13.04.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 02 Feb 2009 13:04:39 -0800 (PST) In-Reply-To: <87fxiwlmgp.fsf@elehack.net> X-Mailer: Apple Mail (2.930.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.orgmode:10971 gmane.emacs.bugs:24855 Archived-At: Hi Michael, I have fixed this bug and checked the changes into Emacs CVS, so they should be part of the next pretest. Thank you for the report! - Carsten On Feb 2, 2009, at 7:31 PM, Michael Ekstrand wrote: > I upgraded this morning from an Emacs CVS build from Jan 28 or 19 to > the > pretest release, and noticed a regression or undocumented change with > respect to org-after-todo-statistics-hook. I am using the org-mode > which is included in the pretest distribution. > > I have a function based on the code in section 5.5 of the Org manual > to > close projects when their subtasks are complete. Now, if I have a > headline which does not have a subtask counter in it and toggle one of > its children to DONE, my org-after-todo-statistics-hook function gets > called with n-done and n-not-done values of 0. The parent headline > thus > has its TODO status changed. > > I don't think it matters too much, as my code worked before, but my > hook > function is `org-summary-todo' from the following. The first case of > the cond is being activated. > > (defun mde-org-entry-is-project-p () > "Query whether the current headline is a project, returning > non-`nil' if it is and `nil' otherwise." > (member "PROJECT" (org-get-tags-at))) > > ;;; Taken from Org Mode manual chapter 5.5 > (defun org-summary-todo (n-done n-not-done) > "Switch entry to DONE when all subentries are done, to TODO > otherwise." > (let ((org-log-done nil) > (org-log-states nil)) > (cond > ((and (or (org-entry-is-todo-p) > (mde-org-entry-is-project-p)) > (= n-not-done 0)) > (org-todo > (if (mde-org-entry-is-project-p) > "FINISHED" > "DONE"))) > ;; Entry is a project that is marked done > ((and (mde-org-entry-is-project-p) > (not (org-entry-is-todo-p)) > (org-get-todo-state) > (> n-not-done 0)) > (org-todo 'none)) > ;; Entry is a task > ((and (not (mde-org-entry-is-project-p)) > (not (org-entry-is-todo-p)) > (org-get-todo-state) > (> n-not-done 0)) > (org-todo (org-get-todo-sequence-head)))))) > > There is a small chance that the problem was actually introduced a bit > earlier, perhaps since my Jan 20 build, but I think I would have > noticed > it after at least the Jan 28 build. > > I have CC'd bug-gnu-emacs to get this in as a bug report there as > well. > > - Michael > > -- > mouse, n: A device for pointing at the xterm in which you want to > type. > Confused by the strange files? I cryptographically sign my messages. > For more information see . > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode _______________________________________________ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode