unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#42422: fix: url-https-proxy-connect - CONNECT with Proxy-Authorization header
@ 2020-07-19  1:10 Satoshi Nakagawa
  2020-07-19 19:12 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Satoshi Nakagawa @ 2020-07-19  1:10 UTC (permalink / raw)
  To: 42422

commit 27b37d16418cd64321505e721b40b6b5d730ebdf (HEAD -> fix/url-https-proxy-connect, fork/fix/url-https-proxy-connect)
Author: Satoshi Nakagawa <ghnacker@gmail.com>
Date:   Sun Jul 19 10:05:27 2020 +0900

    fix: url-https-proxy-connect - CONNECT with Proxy-Authorization header

diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index 669c24571f..9c1219d5c0 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -1406,6 +1406,10 @@ The return value of this function is the retrieval buffer."
   (setq url-http-after-change-function 'url-https-proxy-after-change-function)
   (process-send-string connection (format (concat "CONNECT %s:%d HTTP/1.1\r\n"
                                                   "Host: %s\r\n"
+                                                  (let ((proxy-auth (let ((url-basic-auth-storage
+                                                                           'url-http-proxy-basic-auth-storage))
+                                                                      (url-get-authentication url-http-proxy nil 'any nil))))
+                                                    (if proxy-auth (concat "Proxy-Authorization: " proxy-auth "\r\n")))
                                                   "\r\n")
                                           (url-host url-current-object)
                                           (or (url-port url-current-object)






^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#42422: fix: url-https-proxy-connect - CONNECT with Proxy-Authorization header
  2020-07-19  1:10 bug#42422: fix: url-https-proxy-connect - CONNECT with Proxy-Authorization header Satoshi Nakagawa
@ 2020-07-19 19:12 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2020-07-19 19:12 UTC (permalink / raw)
  To: Satoshi Nakagawa; +Cc: 42422

Satoshi Nakagawa <ghnacker@gmail.com> writes:

>     fix: url-https-proxy-connect - CONNECT with Proxy-Authorization header

Looks good to me; applied to Emacs 28.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-19 19:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-19  1:10 bug#42422: fix: url-https-proxy-connect - CONNECT with Proxy-Authorization header Satoshi Nakagawa
2020-07-19 19:12 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).