From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Narayanan Nellayi Newsgroups: gmane.emacs.bugs Subject: bug#41348: emacs compilation with clang10 fails in the file lib-src/etags.c Date: Sun, 17 May 2020 21:31:29 +0530 Message-ID: References: <83tv0ebn50.fsf@gnu.org> <871rnih8ti.fsf@turtle-trading.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="97795"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41348@debbugs.gnu.org To: Benjamin Riefenstahl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 17 18:03:34 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jaLlG-000PLY-Fd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 May 2020 18:03:34 +0200 Original-Received: from localhost ([::1]:45478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaLlE-0007zH-TE for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 May 2020 12:03:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaLjm-0006c0-MR for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 12:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaLjm-0001m3-Av for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 12:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jaLjm-0005ph-76 for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 12:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Narayanan Nellayi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 May 2020 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41348 X-GNU-PR-Package: emacs Original-Received: via spool by 41348-submit@debbugs.gnu.org id=B41348.158973131122403 (code B ref 41348); Sun, 17 May 2020 16:02:02 +0000 Original-Received: (at 41348) by debbugs.gnu.org; 17 May 2020 16:01:51 +0000 Original-Received: from localhost ([127.0.0.1]:44406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaLjX-0005pC-Vi for submit@debbugs.gnu.org; Sun, 17 May 2020 12:01:51 -0400 Original-Received: from mail-il1-f175.google.com ([209.85.166.175]:41497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaLjW-0005p0-7T for 41348@debbugs.gnu.org; Sun, 17 May 2020 12:01:46 -0400 Original-Received: by mail-il1-f175.google.com with SMTP id b71so7423791ilg.8 for <41348@debbugs.gnu.org>; Sun, 17 May 2020 09:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oRmY5Ti7DCWp8LmLte3D/M45Zqf/oqPwlJ6zY1W/ODg=; b=ti/6EUXqF3IruaS3tkhYPgIRGD3YttoVK2C5aRJ7R8n9pbV7772qNmSp1bQOoK1+T4 cVhHDhD14nRMrkDyZAMEjY7bxE5OZULevj3vNbFRwQeYWCe8cjEF7GiezOVA7+9KEDrY 4GEDbC0qb1VBUlUr95HO3B0qkM1vHGNPbr8gqr/6WfeR7+QrJJFo8uWBTw6JwgMpZk2u bUVV1izeyMNK6lSyGtYh5YBK+yvJ38971vFrOSGOpNyd7adgaAr1hk2h1d76KLNln+eQ P6wmlmvAnyNqtwCIzjJ5DiB2KfvBVjkKjpZgBwQ0XOqtY9lwdOfxKGEIUyOev+qS2TE8 RPDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oRmY5Ti7DCWp8LmLte3D/M45Zqf/oqPwlJ6zY1W/ODg=; b=TsrraiaEuH5g8WHX9M4zCvCik4SSKlPr4YfsYyzMZlN9S8OGoROIeKBVnoqr1wEPrq VIQnqeso1USE2yNmMgqi4kYc45HzZhTFxg8Ezyr7ahD03FhvgdkByz2AIwJqeUVFhPLk hrz+ntsrlkiBH98wqmABDgAR5fjqhUBeNPAB2nm5HBsVNokwphjB80a68TVT94mZN3ET BzvgHlpo2TkWI7GlR2XKGnBK8Wb2ulygor6hAqlC2Oj5Qq/d+6iyrBZBrUScXOTVeGzO WJj8kUyHZ4hVBA9eYxDuS2je/iCPYMrou9tFAFlBgc2YDgrClOCXaNAv0EDlk5y5xFXf V/1g== X-Gm-Message-State: AOAM532G2zRc+U/Eh4ZMI1kYmRhEl6KSO1UgkHadZ/eUNn5swba7aeg+ fjDa4qBLwaRltPlmpMIE6eC0HH2kbL8WnPxeglma6Xj1hhc= X-Google-Smtp-Source: ABdhPJzayuTvT8e4ml9iwaYgmY5I70uGXkWPu34x0U/YBjy9V/LhBhOsbjf+zx6G+TgHpRoHmg/VyjuYKV/obtJxGQA= X-Received: by 2002:a92:d40f:: with SMTP id q15mr11391767ilm.97.1589731300356; Sun, 17 May 2020 09:01:40 -0700 (PDT) In-Reply-To: <871rnih8ti.fsf@turtle-trading.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180479 Archived-At: Hi Benny, Thanks, what you suggested works and is cleaner than what I had in mind (which is commenting out FALLTHROUGH or using a goto). diff --git a/lib-src/etags.c b/lib-src/etags.c index eee2c59626..4672e3491d 100644 --- a/lib-src/etags.c +++ b/lib-src/etags.c @@ -4197,9 +4197,9 @@ C_entries (int c_ext, FILE *inf) break; } FALLTHROUGH; - resetfvdef: case '#': case '~': case '&': case '%': case '/': case '|': case '^': case '!': case '.': case '?': + resetfvdef: if (definedef != dnone) break; /* These surely cannot follow a function tag in C. */ Thanks Narayanan On Sun, May 17, 2020 at 9:06 PM Benjamin Riefenstahl wrote: > > Eli Zaretskii writes: > > Does this mean Clang doesn't support __attribute__ ((__fallthrough__))? > > It looks to like it does support it. But it complains, that there is a > non-switch label "resetfvdef:" (for goto) between the annotation and the > next "case". The correct fix is probably to move "resetfvdef:" after > the "case" labels. > > > benny