From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Narayanan Nellayi Newsgroups: gmane.emacs.bugs Subject: bug#41348: emacs compilation with clang10 fails in the file lib-src/etags.c Date: Sun, 17 May 2020 12:32:39 +0530 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000695ca105a5d2a222" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="65876"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Narayanan N.A." To: 41348@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 17 10:30:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jaEgU-000H39-8g for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 May 2020 10:30:10 +0200 Original-Received: from localhost ([::1]:34442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaEgT-0008QH-AZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 May 2020 04:30:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaEgN-0008Px-41 for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 04:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaEgM-0006Js-RC for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 04:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jaEgM-0006Zb-LJ for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 04:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Narayanan Nellayi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 May 2020 08:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41348 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.158970415125181 (code B ref -1); Sun, 17 May 2020 08:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 May 2020 08:29:11 +0000 Original-Received: from localhost ([127.0.0.1]:42278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaEfW-0006Y4-8o for submit@debbugs.gnu.org; Sun, 17 May 2020 04:29:11 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:46976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaDK1-0004DW-6r for submit@debbugs.gnu.org; Sun, 17 May 2020 03:02:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaDK0-00049l-Vb for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 03:02:53 -0400 Original-Received: from mail-il1-x12d.google.com ([2607:f8b0:4864:20::12d]:40028) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaDJz-0002r4-Qm for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 03:02:52 -0400 Original-Received: by mail-il1-x12d.google.com with SMTP id e8so6727828ilm.7 for ; Sun, 17 May 2020 00:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=GQCGJN8BFFriVp/398e186VoJvBM/caxaOIGXjOCnI8=; b=hXdW0KQtWUC0zQ8u22WMW9bLOu47QUQuMou3asif62Cjgx1amCPEiVg0aYd6um99yL SUvDOP25PGAHjaRPMpA+3YbIOm7TblkdNOIRBhDDYXc/9MwakB3ByVdPT5zpFiTwy68y IsZHbNrsu3R9xiAiTvULc7OQYVZcC3nAGVU5P4SfOE37rPPU2A5KnQFyfS/14AnLRdJT YO7bmipQisKTGh0Ebz6HGzQAH7hQmh3tz+n3rPho4+HiSC/o8FfsCX2wk4f1LHOYpPr0 A4j6Ty+5jsDCgUEaCVOpOGwdkjp2etmcrUn1Jo5E4FYPOZskaz/JhuWzgtUbAnyTui1G RXMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=GQCGJN8BFFriVp/398e186VoJvBM/caxaOIGXjOCnI8=; b=XN7fLBxSil0FreQ0GJEhPKpJdxdf80q2XB/rjX41RiJFATzan2bKnhEBYksw4DrLMb YusO2oRM6YK25S4xbGgJoE4VlfA2+lMSaL4FLMaMTHzX11UoeyhLgqenGrTxRO9FTNHm BTb3KJSOj/QMs4FzDsv1vVALogrj2iQNDAyXzftgvynfUZP+oMuiUWiCsdDnIDMpEAHI KHzYRFtkuKKxRhHDMTt4rWOKsG8BR7c8PydQUis9f7LJvU2UodEKvbbDA+nrMtvUtHmX Rv/Ctjto+Mp4tJaxacQyQrttboYYokk4VOuMZYQgnKvP7jfQMwpXij542GDjtd+N9UFH 13lw== X-Gm-Message-State: AOAM53065NlVjjb7rLn/pOzkCJGPYmdAywk8iqjFdG9AqkqGXhSrXVSH aGP73ku/jHyc2GygFNEfxo1kxVn7r/b1kI+tIEVtVDY1 X-Google-Smtp-Source: ABdhPJwKyeDFPryL8Cl9wjJWkj4bhYo0KBJOYDyOXDuj+XaeIq0dcOMNN7xJQjiQTUbbYo5HqliKkI/k8EksVF3WUfA= X-Received: by 2002:a92:de02:: with SMTP id x2mr11387220ilm.267.1589698970080; Sun, 17 May 2020 00:02:50 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::12d; envelope-from=n.a.narayanan@gmail.com; helo=mail-il1-x12d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Mailman-Approved-At: Sun, 17 May 2020 04:29:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180440 Archived-At: --000000000000695ca105a5d2a222 Content-Type: text/plain; charset="UTF-8" Hi, emacs compilation with clang10 on Ubuntu 20.04 (focal release) fails with an error in the file lib-src/etags.c. I am able to fix the issue with a one-line change. This compilation failure is seen on the emacs src from top-of-the-master-branch. Pls see if this fix is appropriate and consider accordingly. I have given below the details on the issue and a patch description. Regards Narayanan clang --version > clang version 10.0.0-4ubuntu1 > Target: x86_64-pc-linux-gnu > Thread model: posix > InstalledDir: /usr/bin > > make -C lib-src all > make[1]: Entering directory > '/mnt/myvg_fs/home/anarayan/sources/emacs/lib-src' > CCLD etags > error: fallthrough annotation does not directly precede switch label > 1 error generated. > make[1]: *** [Makefile:366: etags] Error 1 > make[1]: Leaving directory > '/mnt/myvg_fs/home/anarayan/sources/emacs/lib-src' > make: *** [Makefile:411: lib-src] Error 2 > > diff --git a/lib-src/etags.c b/lib-src/etags.c > index eee2c59626..b5f077007b 100644 > --- a/lib-src/etags.c > +++ b/lib-src/etags.c > @@ -4196,7 +4196,7 @@ C_entries (int c_ext, FILE *inf) > objdef = omethodsign; > break; > } > - FALLTHROUGH; > + // FALLTHROUGH; > resetfvdef: > case '#': case '~': case '&': case '%': case '/': > case '|': case '^': case '!': case '.': case '?': > > --000000000000695ca105a5d2a222 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

emacs compilation with c= lang10 on Ubuntu 20.04 (focal release) fails with an error in the file lib-= src/etags.c. I am able to fix the issue with a one-line change. This compil= ation failure is seen on the emacs src from top-of-the-master-branch.
=

Pls see if this fix is appropriate and consider accordi= ngly.

I have given below the details on the issue = and a patch description.

Regards
Narayan= an

cl= ang --version
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-= gnu
Thread model: posix
InstalledDir: /usr/bin
= =C2=A0
make -C lib-s= rc all
make[1]: Entering directory '/mnt/myvg_fs/home/anarayan/sourc= es/emacs/lib-src'
=C2=A0 CCLD =C2=A0 =C2=A0 etags
error: fallthro= ugh annotation does not directly precede switch label
1 error generated.=
make[1]: *** [Makefile:366: etags] Error 1
make[1]: Leaving director= y '/mnt/myvg_fs/home/anarayan/sources/emacs/lib-src'
make: *** [= Makefile:411: lib-src] Error 2
=C2=A0
diff --git a/lib-src/etags.c b/lib-s= rc/etags.c
index eee2c59626..b5f077007b 100644
--- a/lib-src/etags.c<= br>+++ b/lib-src/etags.c
@@ -4196,7 +4196,7 @@ C_entries (int c_ext, FIL= E *inf)
=C2=A0 =C2=A0 =C2=A0 =C2=A0objdef =3D omethodsign;
=C2=A0 = =C2=A0 =C2=A0 =C2=A0break;
=C2=A0 =C2=A0 =C2=A0}
- =C2=A0FALLTHROUG= H;
+ =C2=A0// FALLTHROUGH;
=C2=A0 resetfvdef:
=C2=A0 case '#&= #39;: case '~': case '&': case '%': case '/= ':
=C2=A0 case '|': case '^': case '!': case= '.': case '?':

--000000000000695ca105a5d2a222--