From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Axel Forsman Newsgroups: gmane.emacs.bugs Subject: bug#58007: 28.1; compilation-error-properties skips non-matching FILE indices Date: Thu, 22 Sep 2022 17:09:55 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ef394d05e945745d" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25434"; mail-complaints-to="usenet@ciao.gmane.io" To: 58007@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 22 18:39:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obPER-0006Mh-DT for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Sep 2022 18:39:23 +0200 Original-Received: from localhost ([::1]:48834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obPEQ-0004hc-Dl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Sep 2022 12:39:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obObO-0007xj-GN for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 11:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39192) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1obObO-0004sp-1H for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 11:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1obObN-0002CM-Sp for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 11:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Axel Forsman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Sep 2022 15:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58007 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16638622848365 (code B ref -1); Thu, 22 Sep 2022 15:59:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Sep 2022 15:58:04 +0000 Original-Received: from localhost ([127.0.0.1]:38265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obOaQ-0002AZ-6W for submit@debbugs.gnu.org; Thu, 22 Sep 2022 11:58:03 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:40472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obNqC-0000zc-8l for submit@debbugs.gnu.org; Thu, 22 Sep 2022 11:10:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obNqB-0005PD-V9 for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 11:10:16 -0400 Original-Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:39604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1obNq5-0005Yc-S6 for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 11:10:11 -0400 Original-Received: by mail-lj1-x230.google.com with SMTP id b24so11364739ljk.6 for ; Thu, 22 Sep 2022 08:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date; bh=GGIq5gxQ5KQoxqByYxBBsLJMcQBmLK1mfxnZ91TwiM8=; b=WjJI6PIFmHP1uj437fXR2fB6rikUiATIAtRYhU6QT9Hu70xaY4JVp0KdNMxPnu3cB2 qklQ1ShCKeP0kJI/pkDMfzdqJDxuUw0pzmubW48VHxvqCJDFvRXHUq4QmE5r6c2Fl1BC gKWfq52CsfDk2X/H+XUKtlkk4I+OL486QzQ2GNMi/D9uPA/Et+YgE1OA4hFOYxDu4H53 +2ldiKarc0ZBfgTdR69TgJqp61hVZoCqyNjZQo2h3g95F0rEy2z5kKV+c6iMWJJQpclr TbWBvguR7RpOnQKUullAC/VyMz/riCUZExatUQB+6dkA2ySToDFclX/wHmaZbpGRcyoK 7lPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=GGIq5gxQ5KQoxqByYxBBsLJMcQBmLK1mfxnZ91TwiM8=; b=KD+GDIdBCXmjrcurJP0TwQhRd+rLm2BP+gSyS/9HdLQDGCp6DsW80+KIbaLZoR7jUt rv9BtTpDFnm09D1OIYuNvQKiAvnU1PmDcCXDr4fjdZLGnZ4/ZXMrwzpWHDujrweMyB8e JdTdHmSi1wQQj/OQ78tGGJ6+PmtjQqA5uq/LhxF1tWdAE3KCTeygAsESC++7r+/Gddnt 11t116TZP7EmW2ZauGphc8KKWfNtgz2F7+fJYnFnn3z6+m+OSRxJV4zRUheiR5jHyYaW CSppXKidYFOxgpYjSYWuQdBU3WPfLCrp5Z98pOiwUy5q976wyhI6pIXtOtnXgIu5rw4h Kiqw== X-Gm-Message-State: ACrzQf3TF9010pECUeRQnHyPnvYOHdQQVqkpbqBkgmfI7m2JZVr1g2Zl dpGsoy1UXkhhqJMB/hOBSbVFd/23SxBiboa629AOeVh8xko= X-Google-Smtp-Source: AMsMyM6KiBV2YZnBpOylzee+d5FpfFc3gkLAmdIP5cHNx0+4vbtBiGJGEjAGITl3s/T/4VNCYVGdDRklKfbjPDPCbc0= X-Received: by 2002:a05:651c:1111:b0:26c:7178:ac4f with SMTP id e17-20020a05651c111100b0026c7178ac4fmr1039860ljo.461.1663859407396; Thu, 22 Sep 2022 08:10:07 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::230; envelope-from=axelsfor@gmail.com; helo=mail-lj1-x230.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 22 Sep 2022 11:58:00 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243426 Archived-At: --000000000000ef394d05e945745d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Greetings: The documentation for compilation-error-regexp-alist states > If FILE, LINE or COLUMN are nil or that index didn=E2=80=99t match, that > information is not present on the matched line. In that case the > file name is assumed to be the same as the previous one in the > buffer, line number defaults to 1 and column defaults to > beginning of line=E2=80=99s indentation. which clearly, unambiguously implies that if the FILE index does not match then the previous file name should be used for the error. However that is not what the code does currently, instead it skips such matches. I believe the documented behavior would be strictly more useful than the current implemented behavior, since if unwanted then the file subexpression in the regex should be non-optional anyway. My use case would be to more easily match errors stretching multiple lines, where the file name is only mentioned in a header. I have attached a patch containing my suggested fix. On a side note, the code for handling the case when FILE is a function that returns a (RELATIVE-FILENAME . DIRNAME) cons-cell looks a bit funky. It could probably be cleaned up. Kind regard Axel Forsman --000000000000ef394d05e945745d Content-Type: text/x-patch; charset="US-ASCII"; name="0001-compile-Do-not-skip-all-non-matching-FILE-indices.patch" Content-Disposition: attachment; filename="0001-compile-Do-not-skip-all-non-matching-FILE-indices.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8d6qs6w0 RnJvbSBkOTM1OWVmZDI3YmI4OGI5NDAwY2UwMTQ3Y2VjMzgyOTAyOTNmYWQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBeGVsIEZvcnNtYW4gPGF4ZWxzZm9yQGdtYWlsLmNvbT4KRGF0 ZTogVGh1LCAyMiBTZXAgMjAyMiAxNjoxMjoxOSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGNvbXBp bGU6IERvIG5vdCBza2lwIGFsbCBub24tbWF0Y2hpbmcgRklMRSBpbmRpY2VzCgoqIGxpc3AvcHJv Z21vZGVzL2NvbXBpbGUuZWwgKGNvbXBpbGF0aW9uLWVycm9yLXByb3BlcnRpZXMpOiBVc2UKcHJl dmlvdXMgZmlsZSBuYW1lIGluIGNhc2Ugb2Ygbm9uLW1hdGNoaW5nIEZJTEUgaW5kZXguCi0tLQog bGlzcC9wcm9nbW9kZXMvY29tcGlsZS5lbCB8IDU4ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0t LS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDMyIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2NvbXBpbGUuZWwgYi9saXNwL3By b2dtb2Rlcy9jb21waWxlLmVsCmluZGV4IGRlZDVkMjEzMGUuLjkwZGFmMTBiOWIgMTAwNjQ0Ci0t LSBhL2xpc3AvcHJvZ21vZGVzL2NvbXBpbGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvY29tcGls ZS5lbApAQCAtMTI1NywzOCArMTI1NywzMiBAQCBQT1MgYW5kIFJFUy4iKQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcnVsZSkKICAgKHVubGVzcyAodGV4dC1wcm9w ZXJ0eS1ub3QtYWxsIChtYXRjaC1iZWdpbm5pbmcgMCkgKHBvaW50KQogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJ2NvbXBpbGF0aW9uLW1lc3NhZ2UgbmlsKQotICAgIChpZiBmaWxl Ci0gICAgICAgICh3aGVuIChzdHJpbmdwCi0gICAgICAgICAgICAgICAoc2V0cSBmaWxlIChpZiAo ZnVuY3Rpb25wIGZpbGUpIChmdW5jYWxsIGZpbGUpCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgKG1hdGNoLXN0cmluZy1uby1wcm9wZXJ0aWVzIGZpbGUpKSkpCi0JICAobGV0ICgoZGlyCi0J ICAgICAgICAgKHVubGVzcyAoZmlsZS1uYW1lLWFic29sdXRlLXAgZmlsZSkKLSAgICAgICAgICAg ICAgICAgICAobGV0ICgocG9zIChjb21waWxhdGlvbi0tcHJldmlvdXMtZGlyZWN0b3J5Ci0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKG1hdGNoLWJlZ2lubmluZyAwKSkpKQotICAgICAg ICAgICAgICAgICAgICAgKHdoZW4gcG9zCi0gICAgICAgICAgICAgICAgICAgICAgIChvciAoZ2V0 LXRleHQtcHJvcGVydHkgKDEtIHBvcykgJ2NvbXBpbGF0aW9uLWRpcmVjdG9yeSkKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgIChnZXQtdGV4dC1wcm9wZXJ0eSBwb3MgJ2NvbXBpbGF0aW9uLWRp cmVjdG9yeSkpKSkpKSkKLQkgICAgKHNldHEgZmlsZSAoY29ucyBmaWxlIChjYXIgZGlyKSkpKSkK LSAgICAgIDs7IFRoaXMgbWVzc2FnZSBkaWRuJ3QgbWVudGlvbiBvbmUsIGdldCBpdCBmcm9tIHBy ZXZpb3VzCi0gICAgICAobGV0ICgocHJldi1wb3MKLQkgICAgIDs7IEZpbmQgdGhlIHByZXZpb3Vz IG1lc3NhZ2UuCi0JICAgICAocHJldmlvdXMtc2luZ2xlLXByb3BlcnR5LWNoYW5nZSAocG9pbnQp ICdjb21waWxhdGlvbi1tZXNzYWdlKSkpCi0JKGlmIHByZXYtcG9zCi0JICAgIDs7IEdldCB0aGUg ZmlsZSBzdHJ1Y3R1cmUgdGhhdCBiZWxvbmdzIHRvIGl0LgotCSAgICAobGV0KiAoKHByZXYKLQkJ ICAgIChvciAoZ2V0LXRleHQtcHJvcGVydHkgKDEtIHByZXYtcG9zKSAnY29tcGlsYXRpb24tbWVz c2FnZSkKLQkJCShnZXQtdGV4dC1wcm9wZXJ0eSBwcmV2LXBvcyAnY29tcGlsYXRpb24tbWVzc2Fn ZSkpKQotCQkgICAocHJldi1maWxlLXN0cnVjdAotCQkgICAgKGFuZCBwcmV2Ci0JCQkgKGNvbXBp bGF0aW9uLS1sb2MtPmZpbGUtc3RydWN0Ci0JCQkgIChjb21waWxhdGlvbi0tbWVzc2FnZS0+bG9j IHByZXYpKSkpKQotCi0JICAgICAgOzsgQ29uc3RydWN0IEZJTEUgLiBESVIgZnJvbSB0aGF0Lgot CSAgICAgIChpZiBwcmV2LWZpbGUtc3RydWN0Ci0JCSAgKHNldHEgZmlsZSAoY29ucyAoY2FhciBw cmV2LWZpbGUtc3RydWN0KQotCQkJCSAgIChjYWRyIChjYXIgcHJldi1maWxlLXN0cnVjdCkpKSkp KSkKLQkodW5sZXNzIGZpbGUKLQkgIChzZXRxIGZpbGUgJygiKnVua25vd24qIikpKSkpCisgICAg KHNldHEKKyAgICAgZmlsZQorICAgICAoaWYtbGV0ICgoZmlsZW5hbWUgKGNvbmQgKChmdW5jdGlv bnAgZmlsZSkgKGZ1bmNhbGwgZmlsZSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo ZmlsZSAobWF0Y2gtc3RyaW5nLW5vLXByb3BlcnRpZXMgZmlsZSkpKSkpCisgICAgICAgICAobGV0 ICgoZGlyCisgICAgICAgICAgICAgICAgKHVubGVzcyAoZmlsZS1uYW1lLWFic29sdXRlLXAgZmls ZW5hbWUpCisgICAgICAgICAgICAgICAgICAobGV0ICgocG9zIChjb21waWxhdGlvbi0tcHJldmlv dXMtZGlyZWN0b3J5CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobWF0Y2gtYmVnaW5u aW5nIDApKSkpCisgICAgICAgICAgICAgICAgICAgICh3aGVuIHBvcworICAgICAgICAgICAgICAg ICAgICAgIChvciAoZ2V0LXRleHQtcHJvcGVydHkgKDEtIHBvcykgJ2NvbXBpbGF0aW9uLWRpcmVj dG9yeSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgKGdldC10ZXh0LXByb3BlcnR5IHBvcyAn Y29tcGlsYXRpb24tZGlyZWN0b3J5KSkpKSkpKQorICAgICAgICAgICAoY29ucyBmaWxlbmFtZSAo Y2FyIGRpcikpKQorICAgICAgICh1bmxlc3MgKGZ1bmN0aW9ucCBmaWxlKQorICAgICAgICAgOzsg VGhpcyBtZXNzYWdlIGRpZG4ndCBtZW50aW9uIGEgZmlsZSwgZ2V0IGl0IGZyb20gcHJldmlvdXMK KyAgICAgICAgIChpZi1sZXQqCisgICAgICAgICAgICAgKChwcmV2LXBvcworICAgICAgICAgICAg ICAgOzsgRmluZCB0aGUgcHJldmlvdXMgbWVzc2FnZS4KKyAgICAgICAgICAgICAgIChwcmV2aW91 cy1zaW5nbGUtcHJvcGVydHktY2hhbmdlIChwb2ludCkgJ2NvbXBpbGF0aW9uLW1lc3NhZ2UpKQor ICAgICAgICAgICAgICA7OyBHZXQgdGhlIGZpbGUgc3RydWN0dXJlIHRoYXQgYmVsb25ncyB0byBp dC4KKyAgICAgICAgICAgICAgKHByZXYgKG9yIChnZXQtdGV4dC1wcm9wZXJ0eSAoMS0gcHJldi1w b3MpICdjb21waWxhdGlvbi1tZXNzYWdlKQorICAgICAgICAgICAgICAgICAgICAgICAgKGdldC10 ZXh0LXByb3BlcnR5IHByZXYtcG9zICdjb21waWxhdGlvbi1tZXNzYWdlKSkpCisgICAgICAgICAg ICAgIChwcmV2LWZpbGUtc3RydWN0IChjb21waWxhdGlvbi0tbG9jLT5maWxlLXN0cnVjdAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNvbXBpbGF0aW9uLS1tZXNzYWdlLT5sb2Mg cHJldikpKSkKKyAgICAgICAgICAgICA7OyBDb25zdHJ1Y3QgRklMRSAuIERJUiBmcm9tIHRoYXQu CisgICAgICAgICAgICAgKGNvbnMgKGNhYXIgcHJldi1maWxlLXN0cnVjdCkgKGNhZHIgKGNhciBw cmV2LWZpbGUtc3RydWN0KSkpCisgICAgICAgICAgICcoIip1bmtub3duKiIpKSkpKQogICAgIDs7 IEFsbCBvZiB0aGVzZSBmaWVsZHMgYXJlIG9wdGlvbmFsLCBnZXQgdGhlbSBvbmx5IGlmIHdlIGhh dmUgYW4gaW5kZXgsIGFuZAogICAgIDs7IGl0IG1hdGNoZWQgc29tZSBwYXJ0IG9mIHRoZSBtZXNz YWdlLgogICAgIChzZXRxIGxpbmUKLS0gCjIuMzYuMgoK --000000000000ef394d05e945745d--