bug#22823: 25.0.50; Excorporate 0.7: incorrect number of parameters to EWS FindItem

bug#22823: 25.0.50; Excorporate 0.7: incorrect number of parameters to EWS FindItem

[Aaron Jacobs]

This seems to be a bug in the `excorporate' package, version 0.7 as

released yesterday on GNU ELPA I believe. The author has indicated that

bugs should be reported using `M-x report-emacs-bug' (see release blog

post at https://www.fitzsim.org/blog/?p=313), and so here one is:



I have been unable to retrieve calendar events from our Exchange server.

The relevant *fsm-debug* output for the event is as follows:



Fri Feb 26 16:45:45 2016: exco--fsm [redacted] server version is
Exchange2010_SP1

Fri Feb 26 16:47:36 2016: Sent "FindItem" to exco--fsm in state :retrieving-data

Fri Feb 26 16:47:36 2016: Error in exco--fsm/:retrieving-data: Wrong
number of parameters for FindItem: expected 5, got 6



This is my first time using the package. Autodiscovery was successful in

my case, as evidenced by the successful retrieval of the server version.



Any advice on this matter would be appreciated.







In GNU Emacs 25.0.50.1 (x86_64-w64-mingw32)

 of 2015-10-05

Repository revision: 1fa9f860564d1b7f223c73395b77efeab3b48555

Windowing system distributor 'Microsoft Corp.', version 6.1.7601

Configured using:

 'configure --prefix=/z/emacs --host=x86_64-w64-mingw32

 --target=x86_64-w64-mingw32 --build=x86_64-w64-mingw32 --with-wide-int

 --with-jpeg --with-xpm --with-png --with-tiff --with-rsvg --with-xml2

 --with-gnutls --with-sound=yes --with-file-notification=yes

 --without-dbus --without-imagemagick 'CFLAGS=-O3 -fomit-frame-pointer

 -g0 -pipe' 'LDFLAGS=-static-libgcc -static-libstdc++ -static -s

 -Wl,-s''



Configured features:

XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB

TOOLKIT_SCROLL_BARS



Important settings:

  value of $LANG: ENU

  locale-coding-system: cp1252

bug#22823: 25.0.50; Excorporate 0.7: incorrect number of parameters to EWS FindItem

[Thomas Fitzsimmons]

Hi Aaron,

Aaron Jacobs <atheriel@gmail.com> writes:

> This seems to be a bug in the `excorporate' package, version 0.7 as
> released yesterday on GNU ELPA I believe. The author has indicated that
> bugs should be reported using `M-x report-emacs-bug' (see release blog
> post at https://www.fitzsim.org/blog/?p=313), and so here one is:
>
> I have been unable to retrieve calendar events from our Exchange server.
> The relevant *fsm-debug* output for the event is as follows:
>
> Fri Feb 26 16:45:45 2016: exco--fsm [redacted] server version is
> Exchange2010_SP1
> Fri Feb 26 16:47:36 2016: Sent "FindItem" to exco--fsm in state :retrieving-data
> Fri Feb 26 16:47:36 2016: Error in exco--fsm/:retrieving-data: Wrong
> number of parameters for FindItem: expected 5, got 6
>
> This is my first time using the package. Autodiscovery was successful in
> my case, as evidenced by the successful retrieval of the server version.
>
> Any advice on this matter would be appreciated.

Thanks for the report.  Can you try this patch (untested)?

Thanks,
Thomas

--- ./excorporate.el~
+++ ./excorporate.el
@@ -706,11 +706,14 @@ (defun exco-get-meetings-for-day (identifier month day year callback)
 	(ParentFolderIds
 	 (DistinguishedFolderId (Id . "calendar"))))
        ;; Empty arguments.
-       ,@(let ((server-major-version
-		(string-to-number
-		 (substring (exco-server-version identifier) 8 12))))
+       ,@(let* ((server-version (exco-server-version identifier))
+		(server-major-version (string-to-number
+				       (substring server-version 8 12))))
 	   (cond
-	    ((<= server-major-version 2007)
+	    ((or (<= server-major-version 2007)
+		 ;; The FindItem argument count changed between
+		 ;; Exchange2010_SP1 and Exchange2010_SP2.
+		 (equal server-version "Exchange2010_SP1"))
 	     '(nil nil nil nil))
 	    ((< server-major-version 2013)
 	     '(nil nil nil nil nil))

bug#22823: 25.0.50; Excorporate 0.7: incorrect number of parameters to EWS FindItem

[Thomas Fitzsimmons]

Hi Aaron,

This is fixed in Excorporate 0.7.2, now available in GNU ELPA.

Thomas