unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#59465: Eglot does not advertise resolveSupport capabilities
@ 2022-11-21 21:04 Marcin Pajkowski
  2022-11-22 20:24 ` Marcin Pajkowski
  0 siblings, 1 reply; 5+ messages in thread
From: Marcin Pajkowski @ 2022-11-21 21:04 UTC (permalink / raw)
  To: 59465


[-- Attachment #1.1: Type: text/plain, Size: 361 bytes --]

Hi Emacs developers,

I recently found that Eglot does not receive
completions with additional text edits from servers
that expect such capability to be advertised by client.

This advertisement is required by rust-analyzer server
to provide completions for symbols that are not resolved
but can be automatically imported.

This patch fixes this issue.

Marcin

[-- Attachment #1.2: Type: text/html, Size: 423 bytes --]

[-- Attachment #2: Eglot-Advertise-completion.resolveSupport-capabilities.patch --]
[-- Type: text/x-patch, Size: 1450 bytes --]

From b290face2792b254ad9567d007205e715da48283 Mon Sep 17 00:00:00 2001
From: Marcin Pajkowski <marcin.pajkowski@gmail.com>
Date: Sun, 20 Nov 2022 20:03:57 +0100
Subject: [PATCH] Eglot: Advertise completion.resolveSupport capabilities

Some servers avoid reporting completion items that require
"additionalTextEdits" capability. Actually eglot-completion-at-point
function supports such feature so it can be advertised to LSP server.

* lisp/progmodes/eglot.el
  (eglot-client-capabilities): Advertise resolveSupport
---
 lisp/progmodes/eglot.el | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index bbd902c1c7..fab3b1cac0 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -737,7 +737,10 @@ eglot-client-capabilities
                                            t
                                          :json-false)
                                       :deprecatedSupport t
+                                      :resolveSupport (:properties
+                                                       ["documentation"
+                                                        "details"
+                                                        "additionalTextEdits"])
                                       :tagSupport (:valueSet [1]))
                                     :contextSupport t)
              :hover              (list :dynamicRegistration :json-false
--
2.38.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-24 14:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 21:04 bug#59465: Eglot does not advertise resolveSupport capabilities Marcin Pajkowski
2022-11-22 20:24 ` Marcin Pajkowski
2022-11-24 11:52   ` Eli Zaretskii
2022-11-24 12:47     ` João Távora
2022-11-24 14:18       ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).