From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Marcin Pajkowski Newsgroups: gmane.emacs.bugs Subject: bug#59465: Eglot does not advertise resolveSupport capabilities Date: Mon, 21 Nov 2022 22:04:27 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000004776a505ee01673d" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29363"; mail-complaints-to="usenet@ciao.gmane.io" To: 59465@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 22 02:29:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxI6j-0007QE-01 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Nov 2022 02:29:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxI5z-0000xG-Ah; Mon, 21 Nov 2022 20:29:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxI5x-0000vA-GZ for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 20:29:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxI5x-0002nG-8E for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 20:29:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxI5x-00070e-59 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 20:29:05 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Marcin Pajkowski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 01:29:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59465 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166908052726849 (code B ref -1); Tue, 22 Nov 2022 01:29:04 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Nov 2022 01:28:47 +0000 Original-Received: from localhost ([127.0.0.1]:49215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxI5e-0006yt-NP for submit@debbugs.gnu.org; Mon, 21 Nov 2022 20:28:47 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:53776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxDy6-0006nU-T4 for submit@debbugs.gnu.org; Mon, 21 Nov 2022 16:04:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxDy6-0001o3-Nz for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 16:04:42 -0500 Original-Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxDy5-0003Ac-1d for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 16:04:42 -0500 Original-Received: by mail-pj1-x1036.google.com with SMTP id a22-20020a17090a6d9600b0021896eb5554so6413707pjk.1 for ; Mon, 21 Nov 2022 13:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=fyAcRMaMw5Z2QmihllVs+vJXX6upDUUHnojpl0cJUkQ=; b=BikLKkmzgmmHVmUy1c+nbVtQ3+v6d7dhnaDQWOOMwiRXN3saKcFXHJAMNX7BYlqefV xQ67X+ZVrgQYEXAeFG5dRsZtgdCiq0M1P9tfnlLPNzq5TXIleYmrEF7ydZrVVAgR/oWA rMA0ywIE4zAcGZ5ZxQmCup4St0g/XjVD83vfWEz8THS4m9qd3JCNBc6LTxS3AyGDC+fH GQ7ly44Z6HHDPb1a+NV2Z2iKmaB+0wIEE/kShPxepVeFcvdWlVc/CbREDcDmxzowgqva RRvCLrGWE+eG1OcJD1mcO1uHej4d1Jwy01XBojIqmbjk7x5rpJZXQJ7jyt7Mw8rzGyEz jXOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fyAcRMaMw5Z2QmihllVs+vJXX6upDUUHnojpl0cJUkQ=; b=HUmF1t2Rocw1jByoGFyFFXfUSerSuBzBKtajERf5YMvzrrw7JFfWPSt0maZKLvQ+Yx G5/ar3Z4Bg3sS466ckmXL7+CHwn8BaBZwHVOC9jqCjBSBnPFlBiRiFkMJLMdS3xcpoi3 HOJPGSnvImZtO1DG7Kr3rkKyFV+60JWDI8i5VME+EBwPtukmOWVfTFRLWkSnCkyDZeDA BMm7Mksvu4i53jPw9cUC+sN8dph053gZT42UfeRCoTRyEVzkw5VIK2fmE+KgnD8EdjS+ p0XkvtPvuXcmpoV+5gSqSt7JMldxYK+I0/YGjUFWDsB1u4zZXzO5VYHatc24PWl2ZwMW mR7g== X-Gm-Message-State: ANoB5pkCvlaWdyXI9JynSieTNCxahUL3EIewTD8QT7NQJ5j4N5ypEsaw RNu58LBDIXSeEoK/6Grhmf2BvL+wmlJJoalavDMDh9q3JKM= X-Google-Smtp-Source: AA0mqf5Bnk3tcewB1OMxALsfI0Gz+ae+HMVf+pzZtnNZPYD0n04LpYb3+PrRdFKyacSLbnx1Ga/eb2HeYYV08sp0TUc= X-Received: by 2002:a17:90a:d24e:b0:218:b478:f44f with SMTP id o14-20020a17090ad24e00b00218b478f44fmr352005pjw.232.1669064678624; Mon, 21 Nov 2022 13:04:38 -0800 (PST) Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=marcin.pajkowski@gmail.com; helo=mail-pj1-x1036.google.com X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, THIS_AD=1.3 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 21 Nov 2022 20:28:40 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248588 Archived-At: --0000000000004776a505ee01673d Content-Type: multipart/alternative; boundary="0000000000004776a205ee01673b" --0000000000004776a205ee01673b Content-Type: text/plain; charset="UTF-8" Hi Emacs developers, I recently found that Eglot does not receive completions with additional text edits from servers that expect such capability to be advertised by client. This advertisement is required by rust-analyzer server to provide completions for symbols that are not resolved but can be automatically imported. This patch fixes this issue. Marcin --0000000000004776a205ee01673b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Emacs developers,

I recently found that Eglot do= es not receive
completions with additional text edits from servers
th= at expect such capability to be advertised by client.

This advertise= ment is required by rust-analyzer server
to provide completions for symb= ols that are not resolved
but can be automatically imported.

This= patch fixes this issue.

Marcin
--0000000000004776a205ee01673b-- --0000000000004776a505ee01673d Content-Type: text/x-patch; charset="US-ASCII"; name="Eglot-Advertise-completion.resolveSupport-capabilities.patch" Content-Disposition: attachment; filename="Eglot-Advertise-completion.resolveSupport-capabilities.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lara067q0 RnJvbSBiMjkwZmFjZTI3OTJiMjU0YWQ5NTY3ZDAwNzIwNWU3MTVkYTQ4MjgzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJjaW4gUGFqa293c2tpIDxtYXJjaW4ucGFqa293c2tpQGdt YWlsLmNvbT4KRGF0ZTogU3VuLCAyMCBOb3YgMjAyMiAyMDowMzo1NyArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIEVnbG90OiBBZHZlcnRpc2UgY29tcGxldGlvbi5yZXNvbHZlU3VwcG9ydCBjYXBhYmls aXRpZXMKClNvbWUgc2VydmVycyBhdm9pZCByZXBvcnRpbmcgY29tcGxldGlvbiBpdGVtcyB0aGF0 IHJlcXVpcmUKImFkZGl0aW9uYWxUZXh0RWRpdHMiIGNhcGFiaWxpdHkuIEFjdHVhbGx5IGVnbG90 LWNvbXBsZXRpb24tYXQtcG9pbnQKZnVuY3Rpb24gc3VwcG9ydHMgc3VjaCBmZWF0dXJlIHNvIGl0 IGNhbiBiZSBhZHZlcnRpc2VkIHRvIExTUCBzZXJ2ZXIuCgoqIGxpc3AvcHJvZ21vZGVzL2VnbG90 LmVsCiAgKGVnbG90LWNsaWVudC1jYXBhYmlsaXRpZXMpOiBBZHZlcnRpc2UgcmVzb2x2ZVN1cHBv cnQKLS0tCiBsaXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbCB8IDQgKysrKwogMSBmaWxlIGNoYW5nZWQs IDQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsIGIv bGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwKaW5kZXggYmJkOTAyYzFjNy4uZmFiM2IxY2FjMCAxMDA2 NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvZWds b3QuZWwKQEAgLTczNyw3ICs3MzcsMTAgQEAgZWdsb3QtY2xpZW50LWNhcGFiaWxpdGllcwogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHQKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgOmpzb24tZmFsc2UpCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIDpkZXByZWNhdGVkU3VwcG9ydCB0CisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDpyZXNvbHZlU3VwcG9ydCAoOnByb3BlcnRpZXMKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBbImRv Y3VtZW50YXRpb24iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICJkZXRhaWxzIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiYWRkaXRpb25hbFRleHRFZGl0cyJdKQogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6dGFnU3VwcG9ydCAoOnZhbHVlU2V0IFsxXSkp CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6Y29udGV4dFN1cHBvcnQgdCkK ICAgICAgICAgICAgICA6aG92ZXIgICAgICAgICAgICAgIChsaXN0IDpkeW5hbWljUmVnaXN0cmF0 aW9uIDpqc29uLWZhbHNlCi0tCjIuMzguMQ== --0000000000004776a505ee01673d--