From: Simon Katz <sk@nomistech.com>
To: 50042@debbugs.gnu.org
Subject: bug#50042: acknowledged by developer (control message for bug #50042)
Date: Wed, 18 Aug 2021 16:33:03 +0100 [thread overview]
Message-ID: <CAPXG94-NPY=7d=3O4hJZnU4qU8w1Lk0f2Rjsq1rU4PovJn37Dw@mail.gmail.com> (raw)
In-Reply-To: <CAPXG949xOih77Ag-Ez3-JnqtH+CpmD-NCtUHi=VAs2v_4HN4Ug@mail.gmail.com>
Oh, I'm really sorry…
I was playing around and I accidentally left in the `(setq
suggest-key-bindings nil)` form.
Please remove that in order to reproduce the problem!
On Wed, 18 Aug 2021 at 16:27, Simon Katz <sk@nomistech.com> wrote:
>
> Hi Lars,
>
> Thanks for fixing the bug I reported.
>
> You mentioned that there might be some peculiarities in this
> area, and indeed that seems to be the case.
>
> I still have a problem. If you are interested in what I am trying
> to fix, see https://github.com/emacs-lsp/lsp-ui/issues/647
>
> Note that everything is fine if I set `suggest-key-bindings` to
> `nil`.
>
> The problems seem to be with commands that both (a) write
> messages to the echo area, and (b) have key bindings.
>
> The code below reproduces the problem. See the comments at the
> beginning for instructions.
>
>
> --------------------------------------------------------------------------------
>
> ;;; demo-post-command-hook-slow-with-m-x-commands-v2.el --- Demo that
> post-command hooks are slow with M-x commands -*-
> lexical-binding: t; -*-
>
> ;; This demonstrates an issue with:
> ;; `(add-hook 'post-command-hook ...)`.
> ;; It's a follow-up to an already-reported and partially-fixed problem -- see
> ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=50042
>
> ;; To reproduce the problem:
> ;;
> ;; - Run `emacs -q -l <this-file>`
> ;;
> ;; - Enter `M-x **-msg-cmd-without-key-binding`.
> ;; - Observe that it takes many seconds (~15 for me) to produce output to the
> ;; "my-output" buffer, and that the "*Messages*" buffer has the message:
> ;; You can run the command ‘**-msg-cmd-without-key-binding’ with
> M-x -witho RET
> ;;
> ;; - Enter `M-x **-msg-cmd-without-key-binding` again.
> ;; - Observe that both the "*Messages*" buffer and the "my-output" buffer update
> ;; immediately.
> ;; - Repeatedly enter `M-x **-msg-cmd-without-key-binding` and observe the same
> ;; - result.
> ;;
> ;; - Enter `M-x **-msg-cmd-with-key-binding`.
> ;; - Observe that it takes 2 seconds for output to appear in the "my-output"
> ;; buffer.
> ;; - Observe that the behaviour is the same if the command is repeated.
> ;;
> ;; - Use the `C-c C-c` key binding, to invoke `**-msg-cmd-with-key-binding`.
> ;; - Observe that there are no delays.
>
>
> ;; Emacs displays the "*GNU Emacs*" buffer after loading this file, so use
> ;; `run-at-time` to delay setting up which buffers are displayed.
> (run-at-time 1
> nil
> (lambda ()
> (switch-to-buffer "*Messages*" nil t)
> (display-buffer (generate-new-buffer "my-output"))
> ;; Arrange things so that we see the output as it appears:
> (select-window (get-buffer-window "my-output"))))
>
> (defun date-time ()
> (format-time-string "%Y-%m-%d %H:%M:%S"))
>
> (defun post-command-message ()
> (when (member this-command
> '(**-msg-cmd-with-key-binding
> **-msg-cmd-without-key-binding))
> (with-current-buffer "my-output"
> (goto-char (point-max))
> (insert (date-time)
> " The command `"
> (format "%s" this-command)
> "` was executed\n")
> (goto-char (point-max)))))
>
> (add-hook 'post-command-hook 'post-command-message)
>
> (defun **-msg-cmd-without-key-binding ()
> (interactive)
> (message "%s Hello from `**-msg-cmd-without-key-binding`"
> (date-time)))
>
> (defun **-msg-cmd-with-key-binding ()
> (interactive)
> (message "%s Hello from `**-msg-cmd-with-key-binding`"
> (date-time)))
>
> (define-key global-map (kbd "C-c C-c") '**-msg-cmd-with-key-binding)
>
> (setq suggest-key-bindings nil)
>
> (when t ; Whether to load the changes in Emacs commit 42a98feb5b
>
> (defvar execute-extended-command--binding-timer nil)
>
> (defun execute-extended-command (prefixarg &optional command-name typed)
> ;; Based on Fexecute_extended_command in keyboard.c of Emacs.
> ;; Aaron S. Hawley <aaron.s.hawley(at)gmail.com> 2009-08-24
> "Read a command name, then read the arguments and call the command.
> To pass a prefix argument to the command you are
> invoking, give a prefix argument to `execute-extended-command'."
> (declare (interactive-only command-execute))
> ;; FIXME: Remember the actual text typed by the user before completion,
> ;; so that we don't later on suggest the same shortening.
> (interactive
> (let ((execute-extended-command--last-typed nil))
> (list current-prefix-arg
> (read-extended-command)
> execute-extended-command--last-typed)))
> ;; Emacs<24 calling-convention was with a single `prefixarg' argument.
> (unless command-name
> (let ((current-prefix-arg prefixarg) ; for prompt
> (execute-extended-command--last-typed nil))
> (setq command-name (read-extended-command))
> (setq typed execute-extended-command--last-typed)))
> (let* ((function (and (stringp command-name) (intern-soft command-name)))
> (binding (and suggest-key-bindings
> (not executing-kbd-macro)
> (where-is-internal function overriding-local-map t))))
> (unless (commandp function)
> (error "`%s' is not a valid command name" command-name))
> ;; Some features, such as novice.el, rely on this-command-keys
> ;; including M-x COMMAND-NAME RET.
> (set--this-command-keys (concat "\M-x" (symbol-name function) "\r"))
> (setq this-command function)
> ;; Normally `real-this-command' should never be changed, but
> here we really
> ;; want to pretend that M-x <cmd> RET is nothing more than a "key
> ;; binding" for <cmd>, so the command the user really wanted to run is
> ;; `function' and not `execute-extended-command'. The difference is
> ;; visible in cases such as M-x <cmd> RET and then C-x z (bug#11506).
> (setq real-this-command function)
> (let ((prefix-arg prefixarg))
> (command-execute function 'record))
> ;; If enabled, show which key runs this command.
> ;; But first wait, and skip the message if there is input.
> (let* ((waited
> ;; If this command displayed something in the echo area;
> ;; wait a few seconds, then display our suggestion message.
> ;; FIXME: Wait *after* running post-command-hook!
> ;; FIXME: If execute-extended-command--shorter were
> ;; faster, we could compute the result here first too.
> (when (and suggest-key-bindings
> (or binding
> (and extended-command-suggest-shorter typed)))
> (sit-for (cond
> ((zerop (length (current-message))) 0)
> ((numberp suggest-key-bindings) suggest-key-bindings)
> (t 2))))))
> (when (and waited (not (consp unread-command-events)))
> (unless (or (not extended-command-suggest-shorter)
> binding executing-kbd-macro (not (symbolp function))
> (<= (length (symbol-name function)) 2))
> ;; There's no binding for CMD. Let's try and find the shortest
> ;; string to use in M-x.
> ;; FIXME: Can be slow. Cache it maybe?
> (while-no-input
> (setq binding (execute-extended-command--shorter
> (symbol-name function) typed))))
> (when binding
> ;; This is normally not necessary -- the timer should run
> ;; immediately, but be defensive and ensure that we never
> ;; have two of these timers in flight.
> (when execute-extended-command--binding-timer
> (cancel-timer execute-extended-command--binding-timer))
> (setq execute-extended-command--binding-timer
> (run-at-time
> 0 nil
> (lambda ()
> (with-temp-message
> (format-message "You can run the command `%s' with %s"
> function
> (if (stringp binding)
> (concat "M-x " binding " RET")
> (key-description binding)))
> (sit-for (if (numberp suggest-key-bindings)
> suggest-key-bindings
> 2))))))))))))
>
> (provide 'demo-post-command-hook-slow-with-m-x-commands-v2)
> ;;; demo-post-command-hook-slow-with-m-x-commands-v2.el ends here
>
> --------------------------------------------------------------------------------
next prev parent reply other threads:[~2021-08-18 15:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <878s13os3a.fsf@gnus.org>
2021-08-13 11:52 ` bug#50042: 26.3; Post-command hooks slow with M-x commands Simon Katz
2021-08-13 12:27 ` Lars Ingebrigtsen
2021-08-13 12:40 ` Simon Katz
2021-08-14 16:36 ` Lars Ingebrigtsen
2021-08-14 20:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-15 11:38 ` Lars Ingebrigtsen
2021-08-17 0:41 ` Dmitry Gutov
[not found] ` <handler.50042.C.162902754922550.notifdonectrl.0@debbugs.gnu.org>
2021-08-18 15:27 ` bug#50042: acknowledged by developer (control message for bug #50042) Simon Katz
2021-08-18 15:33 ` Simon Katz [this message]
2021-08-18 15:37 ` Simon Katz
2021-08-19 13:07 ` Lars Ingebrigtsen
2021-08-19 14:55 ` Simon Katz
2021-08-20 13:09 ` Lars Ingebrigtsen
2021-08-20 16:14 ` Simon Katz
2021-08-21 12:55 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPXG94-NPY=7d=3O4hJZnU4qU8w1Lk0f2Rjsq1rU4PovJn37Dw@mail.gmail.com' \
--to=sk@nomistech.com \
--cc=50042@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).