From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Akira Kyle Newsgroups: gmane.emacs.bugs Subject: bug#53013: 29.0.50; xwidget-webkit: SIGCHLD not being caught after xwidget-webkit buffer killed Date: Tue, 4 Jan 2022 22:04:22 -0700 Message-ID: References: <86bl0r6wcy.fsf@akirakyle.com> <87r19m9a6v.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24264"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53013@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 05 06:05:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4yUJ-00067K-3K for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jan 2022 06:05:27 +0100 Original-Received: from localhost ([::1]:60046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4yUG-0007wZ-Tk for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jan 2022 00:05:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4yTu-0007w3-Bg for bug-gnu-emacs@gnu.org; Wed, 05 Jan 2022 00:05:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4yTt-0007I1-Vp for bug-gnu-emacs@gnu.org; Wed, 05 Jan 2022 00:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n4yTt-0000fR-Rb for bug-gnu-emacs@gnu.org; Wed, 05 Jan 2022 00:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Akira Kyle Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jan 2022 05:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53013 X-GNU-PR-Package: emacs Original-Received: via spool by 53013-submit@debbugs.gnu.org id=B53013.16413590812530 (code B ref 53013); Wed, 05 Jan 2022 05:05:01 +0000 Original-Received: (at 53013) by debbugs.gnu.org; 5 Jan 2022 05:04:41 +0000 Original-Received: from localhost ([127.0.0.1]:39364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4yTY-0000ek-QV for submit@debbugs.gnu.org; Wed, 05 Jan 2022 00:04:41 -0500 Original-Received: from mail-lj1-f171.google.com ([209.85.208.171]:45849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4yTX-0000eX-8j for 53013@debbugs.gnu.org; Wed, 05 Jan 2022 00:04:40 -0500 Original-Received: by mail-lj1-f171.google.com with SMTP id h15so50624815ljh.12 for <53013@debbugs.gnu.org>; Tue, 04 Jan 2022 21:04:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yhmzExMeJsGWtv/TX3X6TQKltfcUGvITS4ZWLFS3my0=; b=XwWztwI7rdqLmyZ43PKnmnlDzXBjZKU2hoTQrRbT4foszBO98pvjgldO3lCQel7l4J 3dXj+jobgqIvrNDREX0FT2VJqnBlL3/+7ep8ApvhxkZ0bPxZ4s74TAmwctgAiRfQOGcS Rx3jzY8TU/mGPZ/BGmheC36a1pTETdnOoA3NloiUTf16dMfSkQQnq28N/AXG1wHAhtdx zyE1Pi89lUbJN3xMgzZrv49yPqzXuwa/iLbIq77kWNd5/Dn9mkUABN1+p4AtsNwg9EAz MQ8xf4gAcKadVK5WiMkp1ZueWFD45YwwVML1cdRV/9JCuguBD1w90PKkjOl9itszc0US uBIg== X-Gm-Message-State: AOAM530HUjSXXElTzWkxZTinGj0U8vhltXajhXMfDSRlC/JIa3GEFeDp JpnCZtBofMaTtHJVoE1uuioGTK+zciJErKNp X-Google-Smtp-Source: ABdhPJxtV1NDPKBK9yEucUFFjJsNK0tXquBjFuGxZR3iWjwxwtulu22+ZPQ99j0my3yNNcV1T0/guQ== X-Received: by 2002:a2e:a0d8:: with SMTP id f24mr41765452ljm.368.1641359073359; Tue, 04 Jan 2022 21:04:33 -0800 (PST) Original-Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com. [209.85.167.50]) by smtp.gmail.com with ESMTPSA id x7sm4076078lfe.159.2022.01.04.21.04.33 for <53013@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 21:04:33 -0800 (PST) Original-Received: by mail-lf1-f50.google.com with SMTP id i31so86417400lfv.10 for <53013@debbugs.gnu.org>; Tue, 04 Jan 2022 21:04:33 -0800 (PST) X-Received: by 2002:a05:6512:3182:: with SMTP id i2mr44222914lfe.673.1641359073088; Tue, 04 Jan 2022 21:04:33 -0800 (PST) In-Reply-To: <87r19m9a6v.fsf@yahoo.com> X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223682 Archived-At: On Tue, Jan 4, 2022 at 7:40 PM Po Lu wrote: > > > I suspect that a call to catch_child_signal might also be needed in > > kill_xwidget so emacs reinstalls its signal handler. > > Should be fixed now on master. > It looks like SIGCHLD is now being caught by emacs for me. Thanks! > Making kill_xwidget call catch_child_signal wasn't enough, since GLib > was resetting SIGCHLD inside a timer set by WebKitGTK and about a dozen > other places as well, hence the very ugly (and unreliable) hack on > master. > > It's a temporary solution that just motivated me to look at making Emacs > use GLib for handling subprocesses. Indeed GLib does appear to want to always own the signal handling and I imagine the current hacks of trying to constantly reinstall the handler are also potentially brittle solutions to the problem.